You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

1004 lines
40 KiB

Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Repository avatars (#6986) * Repository avatars - first variant of code from old work for gogs - add migration 87 - add new option in app.ini - add en-US locale string - add new class in repository.less * Add changed index.css, remove unused template name * Update en-us doc about configuration options * Add comments to new functions, add new option to docker app.ini * Add comment for lint * Remove variable, not needed * Fix formatting * Update swagger api template * Check if avatar exists * Fix avatar link/path checks * Typo * TEXT column can't have a default value * Fixes: - remove old avatar file on upload - use ID in name of avatar file - users may upload same files - add simple tests * Fix fmt check * Generate PNG instead of "static" GIF * More informative comment * Fix error message * Update avatar upload checks: - add file size check - add new option - update config docs - add new string to en-us locale * Fixes: - use FileHEader field for check file size - add new test - upload big image * Fix formatting * Update comments * Update log message * Removed wrong style - not needed * Use Sync2 to migrate * Update repos list view - bigger avatar - fix html blocks alignment * A little adjust avatar size * Use small icons for explore/repo list * Use new cool avatar preparation func by @lafriks * Missing changes for new function * Remove unused import, move imports * Missed new option definition in app.ini Add file size check in user/profile avatar upload * Use smaller field length for Avatar * Use session to update repo DB data, update DeleteAvatar - use session too * Fix err variable definition * As suggested @lafriks - return as soon as possible, code readability
5 years ago
Repository avatars (#6986) * Repository avatars - first variant of code from old work for gogs - add migration 87 - add new option in app.ini - add en-US locale string - add new class in repository.less * Add changed index.css, remove unused template name * Update en-us doc about configuration options * Add comments to new functions, add new option to docker app.ini * Add comment for lint * Remove variable, not needed * Fix formatting * Update swagger api template * Check if avatar exists * Fix avatar link/path checks * Typo * TEXT column can't have a default value * Fixes: - remove old avatar file on upload - use ID in name of avatar file - users may upload same files - add simple tests * Fix fmt check * Generate PNG instead of "static" GIF * More informative comment * Fix error message * Update avatar upload checks: - add file size check - add new option - update config docs - add new string to en-us locale * Fixes: - use FileHEader field for check file size - add new test - upload big image * Fix formatting * Update comments * Update log message * Removed wrong style - not needed * Use Sync2 to migrate * Update repos list view - bigger avatar - fix html blocks alignment * A little adjust avatar size * Use small icons for explore/repo list * Use new cool avatar preparation func by @lafriks * Missing changes for new function * Remove unused import, move imports * Missed new option definition in app.ini Add file size check in user/profile avatar upload * Use smaller field length for Avatar * Use session to update repo DB data, update DeleteAvatar - use session too * Fix err variable definition * As suggested @lafriks - return as soon as possible, code readability
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Graceful Queues: Issue Indexing and Tasks (#9363) * Queue: Add generic graceful queues with settings * Queue & Setting: Add worker pool implementation * Queue: Add worker settings * Queue: Make resizing worker pools * Queue: Add name variable to queues * Queue: Add monitoring * Queue: Improve logging * Issues: Gracefulise the issues indexer Remove the old now unused specific queues * Task: Move to generic queue and gracefulise * Issues: Standardise the issues indexer queue settings * Fix test * Queue: Allow Redis to connect to unix * Prevent deadlock during early shutdown of issue indexer * Add MaxWorker settings to queues * Merge branch 'master' into graceful-queues * Update modules/indexer/issues/indexer.go Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * Update modules/indexer/issues/indexer.go Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * Update modules/queue/queue_channel.go Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * Update modules/queue/queue_disk.go * Update modules/queue/queue_disk_channel.go Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * Rename queue.Description to queue.ManagedQueue as per @guillep2k * Cancel pool workers when removed * Remove dependency on queue from setting * Update modules/queue/queue_redis.go Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * As per @guillep2k add mutex locks on shutdown/terminate * move unlocking out of setInternal * Add warning if number of workers < 0 * Small changes as per @guillep2k * No redis host specified not found * Clean up documentation for queues * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md * Update modules/indexer/issues/indexer_test.go * Ensure that persistable channel queue is added to manager * Rename QUEUE_NAME REDIS_QUEUE_NAME * Revert "Rename QUEUE_NAME REDIS_QUEUE_NAME" This reverts commit 1f83b4fc9b9dabda186257b38c265fe7012f90df. Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
4 years ago
Repository avatars (#6986) * Repository avatars - first variant of code from old work for gogs - add migration 87 - add new option in app.ini - add en-US locale string - add new class in repository.less * Add changed index.css, remove unused template name * Update en-us doc about configuration options * Add comments to new functions, add new option to docker app.ini * Add comment for lint * Remove variable, not needed * Fix formatting * Update swagger api template * Check if avatar exists * Fix avatar link/path checks * Typo * TEXT column can't have a default value * Fixes: - remove old avatar file on upload - use ID in name of avatar file - users may upload same files - add simple tests * Fix fmt check * Generate PNG instead of "static" GIF * More informative comment * Fix error message * Update avatar upload checks: - add file size check - add new option - update config docs - add new string to en-us locale * Fixes: - use FileHEader field for check file size - add new test - upload big image * Fix formatting * Update comments * Update log message * Removed wrong style - not needed * Use Sync2 to migrate * Update repos list view - bigger avatar - fix html blocks alignment * A little adjust avatar size * Use small icons for explore/repo list * Use new cool avatar preparation func by @lafriks * Missing changes for new function * Remove unused import, move imports * Missed new option definition in app.ini Add file size check in user/profile avatar upload * Use smaller field length for Avatar * Use session to update repo DB data, update DeleteAvatar - use session too * Fix err variable definition * As suggested @lafriks - return as soon as possible, code readability
5 years ago
Feature: Timetracking (#2211) * Added comment's hashtag to url for mail notifications. * Added explanation to return statement + documentation. * Replacing in-line link generation with HTMLURL. (+gofmt) * Replaced action-based model with nil-based model. (+gofmt) * Replaced mailIssueActionToParticipants with mailIssueCommentToParticipants. * Updating comment for mailIssueCommentToParticipants * Added link to comment in "Dashboard" * Deleting feed entry if a comment is going to be deleted * Added migration * Added improved migration to add a CommentID column to action. * Added improved links to comments in feed entries. * Fixes #1956 by filtering for deleted comments that are referenced in actions. * Introducing "IsDeleted" column to action. * Adding design draft (not functional) * Adding database models for stopwatches and trackedtimes * See go-gitea/gitea#967 * Adding design draft (not functional) * Adding translations and improving design * Implementing stopwatch (for timetracking) * Make UI functional * Add hints in timeline for time tracking events * Implementing timetracking feature * Adding "Add time manual" option * Improved stopwatch * Created report of total spent time by user * Only showing total time spent if theire is something to show. * Adding license headers. * Improved error handling for "Add Time Manual" * Adding @sapks 's changes, refactoring * Adding API for feature tracking * Adding unit test * Adding DISABLE/ENABLE option to Repository settings page * Improving translations * Applying @sapk 's changes * Removing repo_unit and using IssuesSetting for disabling/enabling timetracker * Adding DEFAULT_ENABLE_TIMETRACKER to config, installation and admin menu * Improving documentation * Fixing vendor/ folder * Changing timtracking routes by adding subgroups /times and /times/stopwatch (Proposed by @lafriks ) * Restricting write access to timetracking based on the repo settings (Proposed by @lafriks ) * Fixed minor permissions bug. * Adding CanUseTimetracker and IsTimetrackerEnabled in ctx.Repo * Allow assignees and authors to track there time too. * Fixed some build-time-errors + logical errors. * Removing unused Get...ByID functions * Moving IsTimetrackerEnabled from context.Repository to models.Repository * Adding a seperate file for issue related repo functions * Adding license headers * Fixed GetUserByParams return 404 * Moving /users/:username/times to /repos/:username/:reponame/times/:username for security reasons * Adding /repos/:username/times to get all tracked times of the repo * Updating sdk-dependency * Updating swagger.v1.json * Adding warning if user has already a running stopwatch (auto-timetracker) * Replacing GetTrackedTimesBy... with GetTrackedTimes(options FindTrackedTimesOptions) * Changing code.gitea.io/sdk back to code.gitea.io/sdk * Correcting spelling mistake * Updating vendor.json * Changing GET stopwatch/toggle to POST stopwatch/toggle * Changing GET stopwatch/cancel to POST stopwatch/cancel * Added migration for stopwatches/timetracking * Fixed some access bugs for read-only users * Added default allow only contributors to track time value to config * Fixed migration by chaging x.Iterate to x.Find * Resorted imports * Moved Add Time Manually form to repo_form.go * Removed "Seconds" field from Add Time Manually * Resorted imports * Improved permission checking * Fixed some bugs * Added integration test * gofmt * Adding integration test by @lafriks * Added created_unix to comment fixtures * Using last event instead of a fixed event * Adding another integration test by @lafriks * Fixing bug Timetracker enabled causing error 500 at sidebar.tpl * Fixed a refactoring bug that resulted in hiding "HasUserStopwatch" warning. * Returning TrackedTime instead of AddTimeOption at AddTime. * Updating SDK from go-gitea/go-sdk#69 * Resetting Go-SDK back to default repository * Fixing test-vendor by changing ini back to original repository * Adding "tags" to swagger spec * govendor sync * Removed duplicate * Formatting templates * Adding IsTimetrackingEnabled checks to API * Improving translations / english texts * Improving documentation * Updating swagger spec * Fixing integration test caused be translation-changes * Removed encoding issues in local_en-US.ini. * "Added" copyright line * Moved unit.IssuesConfig().EnableTimetracker into a != nil check * Removed some other encoding issues in local_en-US.ini * Improved javascript by checking if data-context exists * Replaced manual comment creation with CreateComment * Removed unnecessary code * Improved error checking * Small cosmetic changes * Replaced int>string>duration parsing with int>duration parsing * Fixed encoding issues * Removed unused imports Signed-off-by: Jonas Franz <info@jonasfranz.software>
7 years ago
Compare branches, commits and tags with each other (#6991) * Supports tags when comparing commits or branches Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Hide headline when only comparing and don't load unused data Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Merges compare logics to allow comparing branches, commits and tags with eachother Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Display branch or tag instead of commit when used for comparing Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Show pull request form after click on button Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Transfers relevant pull.go changes from master to compare.go Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Fixes error when comparing forks against a commit or tag Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Removes console.log from JavaScript file Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Show icon next to commit reference when comparing branch or tag Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Updates css file Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Fixes import order * Renames template variable * Update routers/repo/compare.go Co-Authored-By: zeripath <art27@cantab.net> * Update from master Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Allow short-shas in compare * Renames prInfo to compareInfo Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Check PR permissions only if compare is pull request Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Adjusts comment Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Use compareInfo instead of prInfo
5 years ago
Change target branch for pull request (#6488) * Adds functionality to change target branch of created pull requests Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Use const instead of var in JavaScript additions Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Check if branches are equal and if PR already exists before changing target branch Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Make sure to check all commits Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Print error messages for user as error flash message Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Disallow changing target branch of closed or merged pull requests Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Resolve conflicts after merge of upstream/master Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Change order of branch select fields Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Removes duplicate check Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Use ctx.Tr for translations Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Recompile JS Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Use correct translation namespace Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Remove redundant if condition Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Moves most change branch logic into pull service Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Completes comment Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Add Ref to ChangesPayload for logging changed target branches instead of creating a new struct Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Revert changes to go.mod Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Directly use createComment method Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Return 404 if pull request is not found. Move written check up Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Remove variable declaration Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Return client errors on change pull request target errors Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Return error in commit.HasPreviousCommit Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Adds blank line Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Test patch before persisting new target branch Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Update patch before testing (not working) Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Removes patch calls when changeing pull request target Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Removes unneeded check for base name Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Moves ChangeTargetBranch completely to pull service. Update patch status. Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Set webhook mode after errors were validated Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Update PR in one transaction Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Move logic for check if head is equal with branch to pull model Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Adds missing comment and simplify return Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Adjust CreateComment method call Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
4 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
6 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
6 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
6 years ago
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package routes
  5. import (
  6. "bytes"
  7. "encoding/gob"
  8. "net/http"
  9. "path"
  10. "text/template"
  11. "time"
  12. "code.gitea.io/gitea/models"
  13. "code.gitea.io/gitea/modules/auth"
  14. "code.gitea.io/gitea/modules/context"
  15. "code.gitea.io/gitea/modules/lfs"
  16. "code.gitea.io/gitea/modules/log"
  17. "code.gitea.io/gitea/modules/metrics"
  18. "code.gitea.io/gitea/modules/options"
  19. "code.gitea.io/gitea/modules/public"
  20. "code.gitea.io/gitea/modules/setting"
  21. "code.gitea.io/gitea/modules/templates"
  22. "code.gitea.io/gitea/modules/validation"
  23. "code.gitea.io/gitea/routers"
  24. "code.gitea.io/gitea/routers/admin"
  25. apiv1 "code.gitea.io/gitea/routers/api/v1"
  26. "code.gitea.io/gitea/routers/dev"
  27. "code.gitea.io/gitea/routers/org"
  28. "code.gitea.io/gitea/routers/private"
  29. "code.gitea.io/gitea/routers/repo"
  30. "code.gitea.io/gitea/routers/user"
  31. userSetting "code.gitea.io/gitea/routers/user/setting"
  32. "code.gitea.io/gitea/services/mailer"
  33. // to registers all internal adapters
  34. _ "code.gitea.io/gitea/modules/session"
  35. "gitea.com/macaron/binding"
  36. "gitea.com/macaron/cache"
  37. "gitea.com/macaron/captcha"
  38. "gitea.com/macaron/cors"
  39. "gitea.com/macaron/csrf"
  40. "gitea.com/macaron/gzip"
  41. "gitea.com/macaron/i18n"
  42. "gitea.com/macaron/macaron"
  43. "gitea.com/macaron/session"
  44. "gitea.com/macaron/toolbox"
  45. "github.com/prometheus/client_golang/prometheus"
  46. "github.com/tstranex/u2f"
  47. )
  48. type routerLoggerOptions struct {
  49. Ctx *macaron.Context
  50. Identity *string
  51. Start *time.Time
  52. ResponseWriter *macaron.ResponseWriter
  53. }
  54. func setupAccessLogger(m *macaron.Macaron) {
  55. logger := log.GetLogger("access")
  56. logTemplate, _ := template.New("log").Parse(setting.AccessLogTemplate)
  57. m.Use(func(ctx *macaron.Context) {
  58. start := time.Now()
  59. ctx.Next()
  60. identity := "-"
  61. if val, ok := ctx.Data["SignedUserName"]; ok {
  62. if stringVal, ok := val.(string); ok && stringVal != "" {
  63. identity = stringVal
  64. }
  65. }
  66. rw := ctx.Resp.(macaron.ResponseWriter)
  67. buf := bytes.NewBuffer([]byte{})
  68. err := logTemplate.Execute(buf, routerLoggerOptions{
  69. Ctx: ctx,
  70. Identity: &identity,
  71. Start: &start,
  72. ResponseWriter: &rw,
  73. })
  74. if err != nil {
  75. log.Error("Could not set up macaron access logger: %v", err.Error())
  76. }
  77. err = logger.SendLog(log.INFO, "", "", 0, buf.String(), "")
  78. if err != nil {
  79. log.Error("Could not set up macaron access logger: %v", err.Error())
  80. }
  81. })
  82. }
  83. // RouterHandler is a macaron handler that will log the routing to the default gitea log
  84. func RouterHandler(level log.Level) func(ctx *macaron.Context) {
  85. return func(ctx *macaron.Context) {
  86. start := time.Now()
  87. _ = log.GetLogger("router").Log(0, level, "Started %s %s for %s", log.ColoredMethod(ctx.Req.Method), ctx.Req.URL.RequestURI(), ctx.RemoteAddr())
  88. rw := ctx.Resp.(macaron.ResponseWriter)
  89. ctx.Next()
  90. status := rw.Status()
  91. _ = log.GetLogger("router").Log(0, level, "Completed %s %s %v %s in %v", log.ColoredMethod(ctx.Req.Method), ctx.Req.URL.RequestURI(), log.ColoredStatus(status), log.ColoredStatus(status, http.StatusText(rw.Status())), log.ColoredTime(time.Since(start)))
  92. }
  93. }
  94. // NewMacaron initializes Macaron instance.
  95. func NewMacaron() *macaron.Macaron {
  96. gob.Register(&u2f.Challenge{})
  97. var m *macaron.Macaron
  98. if setting.RedirectMacaronLog {
  99. loggerAsWriter := log.NewLoggerAsWriter("INFO", log.GetLogger("macaron"))
  100. m = macaron.NewWithLogger(loggerAsWriter)
  101. if !setting.DisableRouterLog && setting.RouterLogLevel != log.NONE {
  102. if log.GetLogger("router").GetLevel() <= setting.RouterLogLevel {
  103. m.Use(RouterHandler(setting.RouterLogLevel))
  104. }
  105. }
  106. } else {
  107. m = macaron.New()
  108. if !setting.DisableRouterLog {
  109. m.Use(macaron.Logger())
  110. }
  111. }
  112. // Access Logger is similar to Router Log but more configurable and by default is more like the NCSA Common Log format
  113. if setting.EnableAccessLog {
  114. setupAccessLogger(m)
  115. }
  116. m.Use(macaron.Recovery())
  117. if setting.EnableGzip {
  118. m.Use(gzip.Middleware())
  119. }
  120. if setting.Protocol == setting.FCGI || setting.Protocol == setting.FCGIUnix {
  121. m.SetURLPrefix(setting.AppSubURL)
  122. }
  123. m.Use(public.Custom(
  124. &public.Options{
  125. SkipLogging: setting.DisableRouterLog,
  126. ExpiresAfter: setting.StaticCacheTime,
  127. },
  128. ))
  129. m.Use(public.Static(
  130. &public.Options{
  131. Directory: path.Join(setting.StaticRootPath, "public"),
  132. SkipLogging: setting.DisableRouterLog,
  133. ExpiresAfter: setting.StaticCacheTime,
  134. },
  135. ))
  136. m.Use(public.StaticHandler(
  137. setting.AvatarUploadPath,
  138. &public.Options{
  139. Prefix: "avatars",
  140. SkipLogging: setting.DisableRouterLog,
  141. ExpiresAfter: setting.StaticCacheTime,
  142. },
  143. ))
  144. m.Use(public.StaticHandler(
  145. setting.RepositoryAvatarUploadPath,
  146. &public.Options{
  147. Prefix: "repo-avatars",
  148. SkipLogging: setting.DisableRouterLog,
  149. ExpiresAfter: setting.StaticCacheTime,
  150. },
  151. ))
  152. m.Use(templates.HTMLRenderer())
  153. mailer.InitMailRender(templates.Mailer())
  154. localeNames, err := options.Dir("locale")
  155. if err != nil {
  156. log.Fatal("Failed to list locale files: %v", err)
  157. }
  158. localFiles := make(map[string][]byte)
  159. for _, name := range localeNames {
  160. localFiles[name], err = options.Locale(name)
  161. if err != nil {
  162. log.Fatal("Failed to load %s locale file. %v", name, err)
  163. }
  164. }
  165. m.Use(i18n.I18n(i18n.Options{
  166. SubURL: setting.AppSubURL,
  167. Files: localFiles,
  168. Langs: setting.Langs,
  169. Names: setting.Names,
  170. DefaultLang: "en-US",
  171. Redirect: false,
  172. CookieDomain: setting.SessionConfig.Domain,
  173. }))
  174. m.Use(cache.Cacher(cache.Options{
  175. Adapter: setting.CacheService.Adapter,
  176. AdapterConfig: setting.CacheService.Conn,
  177. Interval: setting.CacheService.Interval,
  178. }))
  179. m.Use(captcha.Captchaer(captcha.Options{
  180. SubURL: setting.AppSubURL,
  181. }))
  182. m.Use(session.Sessioner(setting.SessionConfig))
  183. m.Use(csrf.Csrfer(csrf.Options{
  184. Secret: setting.SecretKey,
  185. Cookie: setting.CSRFCookieName,
  186. SetCookie: true,
  187. Secure: setting.SessionConfig.Secure,
  188. CookieHttpOnly: setting.CSRFCookieHTTPOnly,
  189. Header: "X-Csrf-Token",
  190. CookieDomain: setting.SessionConfig.Domain,
  191. CookiePath: setting.AppSubURL,
  192. }))
  193. m.Use(toolbox.Toolboxer(m, toolbox.Options{
  194. HealthCheckFuncs: []*toolbox.HealthCheckFuncDesc{
  195. {
  196. Desc: "Database connection",
  197. Func: models.Ping,
  198. },
  199. },
  200. DisableDebug: !setting.EnablePprof,
  201. }))
  202. m.Use(context.Contexter())
  203. // OK we are now set-up enough to allow us to create a nicer recovery than
  204. // the default macaron recovery
  205. m.Use(context.Recovery())
  206. m.SetAutoHead(true)
  207. return m
  208. }
  209. // RegisterRoutes routes routes to Macaron
  210. func RegisterRoutes(m *macaron.Macaron) {
  211. reqSignIn := context.Toggle(&context.ToggleOptions{SignInRequired: true})
  212. ignSignIn := context.Toggle(&context.ToggleOptions{SignInRequired: setting.Service.RequireSignInView})
  213. ignSignInAndCsrf := context.Toggle(&context.ToggleOptions{DisableCSRF: true})
  214. reqSignOut := context.Toggle(&context.ToggleOptions{SignOutRequired: true})
  215. bindIgnErr := binding.BindIgnErr
  216. validation.AddBindingRules()
  217. openIDSignInEnabled := func(ctx *context.Context) {
  218. if !setting.Service.EnableOpenIDSignIn {
  219. ctx.Error(403)
  220. return
  221. }
  222. }
  223. openIDSignUpEnabled := func(ctx *context.Context) {
  224. if !setting.Service.EnableOpenIDSignUp {
  225. ctx.Error(403)
  226. return
  227. }
  228. }
  229. reqMilestonesDashboardPageEnabled := func(ctx *context.Context) {
  230. if !setting.Service.ShowMilestonesDashboardPage {
  231. ctx.Error(403)
  232. return
  233. }
  234. }
  235. m.Use(user.GetNotificationCount)
  236. // FIXME: not all routes need go through same middlewares.
  237. // Especially some AJAX requests, we can reduce middleware number to improve performance.
  238. // Routers.
  239. // for health check
  240. m.Head("/", func() string {
  241. return ""
  242. })
  243. m.Get("/", routers.Home)
  244. m.Group("/explore", func() {
  245. m.Get("", func(ctx *context.Context) {
  246. ctx.Redirect(setting.AppSubURL + "/explore/repos")
  247. })
  248. m.Get("/repos", routers.ExploreRepos)
  249. m.Get("/users", routers.ExploreUsers)
  250. m.Get("/organizations", routers.ExploreOrganizations)
  251. m.Get("/code", routers.ExploreCode)
  252. }, ignSignIn)
  253. m.Combo("/install", routers.InstallInit).Get(routers.Install).
  254. Post(bindIgnErr(auth.InstallForm{}), routers.InstallPost)
  255. m.Get("/^:type(issues|pulls)$", reqSignIn, user.Issues)
  256. m.Get("/milestones", reqSignIn, reqMilestonesDashboardPageEnabled, user.Milestones)
  257. // ***** START: User *****
  258. m.Group("/user", func() {
  259. m.Get("/login", user.SignIn)
  260. m.Post("/login", bindIgnErr(auth.SignInForm{}), user.SignInPost)
  261. m.Group("", func() {
  262. m.Combo("/login/openid").
  263. Get(user.SignInOpenID).
  264. Post(bindIgnErr(auth.SignInOpenIDForm{}), user.SignInOpenIDPost)
  265. }, openIDSignInEnabled)
  266. m.Group("/openid", func() {
  267. m.Combo("/connect").
  268. Get(user.ConnectOpenID).
  269. Post(bindIgnErr(auth.ConnectOpenIDForm{}), user.ConnectOpenIDPost)
  270. m.Group("/register", func() {
  271. m.Combo("").
  272. Get(user.RegisterOpenID, openIDSignUpEnabled).
  273. Post(bindIgnErr(auth.SignUpOpenIDForm{}), user.RegisterOpenIDPost)
  274. }, openIDSignUpEnabled)
  275. }, openIDSignInEnabled)
  276. m.Get("/sign_up", user.SignUp)
  277. m.Post("/sign_up", bindIgnErr(auth.RegisterForm{}), user.SignUpPost)
  278. m.Group("/oauth2", func() {
  279. m.Get("/:provider", user.SignInOAuth)
  280. m.Get("/:provider/callback", user.SignInOAuthCallback)
  281. })
  282. m.Get("/link_account", user.LinkAccount)
  283. m.Post("/link_account_signin", bindIgnErr(auth.SignInForm{}), user.LinkAccountPostSignIn)
  284. m.Post("/link_account_signup", bindIgnErr(auth.RegisterForm{}), user.LinkAccountPostRegister)
  285. m.Group("/two_factor", func() {
  286. m.Get("", user.TwoFactor)
  287. m.Post("", bindIgnErr(auth.TwoFactorAuthForm{}), user.TwoFactorPost)
  288. m.Get("/scratch", user.TwoFactorScratch)
  289. m.Post("/scratch", bindIgnErr(auth.TwoFactorScratchAuthForm{}), user.TwoFactorScratchPost)
  290. })
  291. m.Group("/u2f", func() {
  292. m.Get("", user.U2F)
  293. m.Get("/challenge", user.U2FChallenge)
  294. m.Post("/sign", bindIgnErr(u2f.SignResponse{}), user.U2FSign)
  295. })
  296. }, reqSignOut)
  297. m.Group("/login/oauth", func() {
  298. m.Get("/authorize", bindIgnErr(auth.AuthorizationForm{}), user.AuthorizeOAuth)
  299. m.Post("/grant", bindIgnErr(auth.GrantApplicationForm{}), user.GrantApplicationOAuth)
  300. // TODO manage redirection
  301. m.Post("/authorize", bindIgnErr(auth.AuthorizationForm{}), user.AuthorizeOAuth)
  302. }, ignSignInAndCsrf, reqSignIn)
  303. m.Post("/login/oauth/access_token", bindIgnErr(auth.AccessTokenForm{}), ignSignInAndCsrf, user.AccessTokenOAuth)
  304. m.Group("/user/settings", func() {
  305. m.Get("", userSetting.Profile)
  306. m.Post("", bindIgnErr(auth.UpdateProfileForm{}), userSetting.ProfilePost)
  307. m.Get("/change_password", user.MustChangePassword)
  308. m.Post("/change_password", bindIgnErr(auth.MustChangePasswordForm{}), user.MustChangePasswordPost)
  309. m.Post("/avatar", binding.MultipartForm(auth.AvatarForm{}), userSetting.AvatarPost)
  310. m.Post("/avatar/delete", userSetting.DeleteAvatar)
  311. m.Group("/account", func() {
  312. m.Combo("").Get(userSetting.Account).Post(bindIgnErr(auth.ChangePasswordForm{}), userSetting.AccountPost)
  313. m.Post("/email", bindIgnErr(auth.AddEmailForm{}), userSetting.EmailPost)
  314. m.Post("/email/delete", userSetting.DeleteEmail)
  315. m.Post("/delete", userSetting.DeleteAccount)
  316. m.Post("/theme", bindIgnErr(auth.UpdateThemeForm{}), userSetting.UpdateUIThemePost)
  317. })
  318. m.Group("/security", func() {
  319. m.Get("", userSetting.Security)
  320. m.Group("/two_factor", func() {
  321. m.Post("/regenerate_scratch", userSetting.RegenerateScratchTwoFactor)
  322. m.Post("/disable", userSetting.DisableTwoFactor)
  323. m.Get("/enroll", userSetting.EnrollTwoFactor)
  324. m.Post("/enroll", bindIgnErr(auth.TwoFactorAuthForm{}), userSetting.EnrollTwoFactorPost)
  325. })
  326. m.Group("/u2f", func() {
  327. m.Post("/request_register", bindIgnErr(auth.U2FRegistrationForm{}), userSetting.U2FRegister)
  328. m.Post("/register", bindIgnErr(u2f.RegisterResponse{}), userSetting.U2FRegisterPost)
  329. m.Post("/delete", bindIgnErr(auth.U2FDeleteForm{}), userSetting.U2FDelete)
  330. })
  331. m.Group("/openid", func() {
  332. m.Post("", bindIgnErr(auth.AddOpenIDForm{}), userSetting.OpenIDPost)
  333. m.Post("/delete", userSetting.DeleteOpenID)
  334. m.Post("/toggle_visibility", userSetting.ToggleOpenIDVisibility)
  335. }, openIDSignInEnabled)
  336. m.Post("/account_link", userSetting.DeleteAccountLink)
  337. })
  338. m.Group("/applications/oauth2", func() {
  339. m.Get("/:id", userSetting.OAuth2ApplicationShow)
  340. m.Post("/:id", bindIgnErr(auth.EditOAuth2ApplicationForm{}), userSetting.OAuthApplicationsEdit)
  341. m.Post("/:id/regenerate_secret", userSetting.OAuthApplicationsRegenerateSecret)
  342. m.Post("", bindIgnErr(auth.EditOAuth2ApplicationForm{}), userSetting.OAuthApplicationsPost)
  343. m.Post("/delete", userSetting.DeleteOAuth2Application)
  344. m.Post("/revoke", userSetting.RevokeOAuth2Grant)
  345. })
  346. m.Combo("/applications").Get(userSetting.Applications).
  347. Post(bindIgnErr(auth.NewAccessTokenForm{}), userSetting.ApplicationsPost)
  348. m.Post("/applications/delete", userSetting.DeleteApplication)
  349. m.Combo("/keys").Get(userSetting.Keys).
  350. Post(bindIgnErr(auth.AddKeyForm{}), userSetting.KeysPost)
  351. m.Post("/keys/delete", userSetting.DeleteKey)
  352. m.Get("/organization", userSetting.Organization)
  353. m.Get("/repos", userSetting.Repos)
  354. }, reqSignIn, func(ctx *context.Context) {
  355. ctx.Data["PageIsUserSettings"] = true
  356. ctx.Data["AllThemes"] = setting.UI.Themes
  357. })
  358. m.Group("/user", func() {
  359. // r.Get("/feeds", binding.Bind(auth.FeedsForm{}), user.Feeds)
  360. m.Any("/activate", user.Activate, reqSignIn)
  361. m.Any("/activate_email", user.ActivateEmail)
  362. m.Get("/avatar/:username/:size", user.Avatar)
  363. m.Get("/email2user", user.Email2User)
  364. m.Get("/recover_account", user.ResetPasswd)
  365. m.Post("/recover_account", user.ResetPasswdPost)
  366. m.Get("/forgot_password", user.ForgotPasswd)
  367. m.Post("/forgot_password", user.ForgotPasswdPost)
  368. m.Get("/logout", user.SignOut)
  369. })
  370. // ***** END: User *****
  371. adminReq := context.Toggle(&context.ToggleOptions{SignInRequired: true, AdminRequired: true})
  372. // ***** START: Admin *****
  373. m.Group("/admin", func() {
  374. m.Get("", adminReq, admin.Dashboard)
  375. m.Get("/config", admin.Config)
  376. m.Post("/config/test_mail", admin.SendTestMail)
  377. m.Group("/monitor", func() {
  378. m.Get("", admin.Monitor)
  379. m.Post("/cancel/:pid", admin.MonitorCancel)
  380. m.Group("/queue/:qid", func() {
  381. m.Get("", admin.Queue)
  382. m.Post("/set", admin.SetQueueSettings)
  383. m.Post("/add", admin.AddWorkers)
  384. m.Post("/cancel/:pid", admin.WorkerCancel)
  385. })
  386. })
  387. m.Group("/users", func() {
  388. m.Get("", admin.Users)
  389. m.Combo("/new").Get(admin.NewUser).Post(bindIgnErr(auth.AdminCreateUserForm{}), admin.NewUserPost)
  390. m.Combo("/:userid").Get(admin.EditUser).Post(bindIgnErr(auth.AdminEditUserForm{}), admin.EditUserPost)
  391. m.Post("/:userid/delete", admin.DeleteUser)
  392. })
  393. m.Group("/orgs", func() {
  394. m.Get("", admin.Organizations)
  395. })
  396. m.Group("/repos", func() {
  397. m.Get("", admin.Repos)
  398. m.Post("/delete", admin.DeleteRepo)
  399. })
  400. m.Group("/hooks", func() {
  401. m.Get("", admin.DefaultWebhooks)
  402. m.Post("/delete", admin.DeleteDefaultWebhook)
  403. m.Get("/:type/new", repo.WebhooksNew)
  404. m.Post("/gitea/new", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksNewPost)
  405. m.Post("/gogs/new", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksNewPost)
  406. m.Post("/slack/new", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksNewPost)
  407. m.Post("/discord/new", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksNewPost)
  408. m.Post("/dingtalk/new", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksNewPost)
  409. m.Post("/telegram/new", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksNewPost)
  410. m.Post("/msteams/new", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksNewPost)
  411. m.Get("/:id", repo.WebHooksEdit)
  412. m.Post("/gitea/:id", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksEditPost)
  413. m.Post("/gogs/:id", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksEditPost)
  414. m.Post("/slack/:id", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksEditPost)
  415. m.Post("/discord/:id", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksEditPost)
  416. m.Post("/dingtalk/:id", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksEditPost)
  417. m.Post("/telegram/:id", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksEditPost)
  418. m.Post("/msteams/:id", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksNewPost)
  419. })
  420. m.Group("/auths", func() {
  421. m.Get("", admin.Authentications)
  422. m.Combo("/new").Get(admin.NewAuthSource).Post(bindIgnErr(auth.AuthenticationForm{}), admin.NewAuthSourcePost)
  423. m.Combo("/:authid").Get(admin.EditAuthSource).
  424. Post(bindIgnErr(auth.AuthenticationForm{}), admin.EditAuthSourcePost)
  425. m.Post("/:authid/delete", admin.DeleteAuthSource)
  426. })
  427. m.Group("/notices", func() {
  428. m.Get("", admin.Notices)
  429. m.Post("/delete", admin.DeleteNotices)
  430. m.Get("/empty", admin.EmptyNotices)
  431. })
  432. }, adminReq)
  433. // ***** END: Admin *****
  434. m.Group("", func() {
  435. m.Group("/:username", func() {
  436. m.Get("", user.Profile)
  437. m.Get("/followers", user.Followers)
  438. m.Get("/following", user.Following)
  439. })
  440. m.Get("/attachments/:uuid", repo.GetAttachment)
  441. }, ignSignIn)
  442. m.Group("/attachments", func() {
  443. m.Post("", repo.UploadAttachment)
  444. m.Post("/delete", repo.DeleteAttachment)
  445. }, reqSignIn)
  446. m.Group("/:username", func() {
  447. m.Get("/action/:action", user.Action)
  448. }, reqSignIn)
  449. if macaron.Env == macaron.DEV {
  450. m.Get("/template/*", dev.TemplatePreview)
  451. }
  452. reqRepoAdmin := context.RequireRepoAdmin()
  453. reqRepoCodeWriter := context.RequireRepoWriter(models.UnitTypeCode)
  454. reqRepoCodeReader := context.RequireRepoReader(models.UnitTypeCode)
  455. reqRepoReleaseWriter := context.RequireRepoWriter(models.UnitTypeReleases)
  456. reqRepoReleaseReader := context.RequireRepoReader(models.UnitTypeReleases)
  457. reqRepoWikiWriter := context.RequireRepoWriter(models.UnitTypeWiki)
  458. reqRepoIssueReader := context.RequireRepoReader(models.UnitTypeIssues)
  459. reqRepoPullsWriter := context.RequireRepoWriter(models.UnitTypePullRequests)
  460. reqRepoPullsReader := context.RequireRepoReader(models.UnitTypePullRequests)
  461. reqRepoIssuesOrPullsWriter := context.RequireRepoWriterOr(models.UnitTypeIssues, models.UnitTypePullRequests)
  462. reqRepoIssuesOrPullsReader := context.RequireRepoReaderOr(models.UnitTypeIssues, models.UnitTypePullRequests)
  463. reqRepoIssueWriter := func(ctx *context.Context) {
  464. if !ctx.Repo.CanWrite(models.UnitTypeIssues) {
  465. ctx.Error(403)
  466. return
  467. }
  468. }
  469. // ***** START: Organization *****
  470. m.Group("/org", func() {
  471. m.Group("", func() {
  472. m.Get("/create", org.Create)
  473. m.Post("/create", bindIgnErr(auth.CreateOrgForm{}), org.CreatePost)
  474. })
  475. m.Group("/:org", func() {
  476. m.Get("/dashboard", user.Dashboard)
  477. m.Get("/^:type(issues|pulls)$", user.Issues)
  478. m.Get("/milestones", reqMilestonesDashboardPageEnabled, user.Milestones)
  479. m.Get("/members", org.Members)
  480. m.Get("/members/action/:action", org.MembersAction)
  481. m.Get("/teams", org.Teams)
  482. }, context.OrgAssignment(true))
  483. m.Group("/:org", func() {
  484. m.Get("/teams/:team", org.TeamMembers)
  485. m.Get("/teams/:team/repositories", org.TeamRepositories)
  486. m.Route("/teams/:team/action/:action", "GET,POST", org.TeamsAction)
  487. m.Route("/teams/:team/action/repo/:action", "GET,POST", org.TeamsRepoAction)
  488. }, context.OrgAssignment(true, false, true))
  489. m.Group("/:org", func() {
  490. m.Get("/teams/new", org.NewTeam)
  491. m.Post("/teams/new", bindIgnErr(auth.CreateTeamForm{}), org.NewTeamPost)
  492. m.Get("/teams/:team/edit", org.EditTeam)
  493. m.Post("/teams/:team/edit", bindIgnErr(auth.CreateTeamForm{}), org.EditTeamPost)
  494. m.Post("/teams/:team/delete", org.DeleteTeam)
  495. m.Group("/settings", func() {
  496. m.Combo("").Get(org.Settings).
  497. Post(bindIgnErr(auth.UpdateOrgSettingForm{}), org.SettingsPost)
  498. m.Post("/avatar", binding.MultipartForm(auth.AvatarForm{}), org.SettingsAvatar)
  499. m.Post("/avatar/delete", org.SettingsDeleteAvatar)
  500. m.Group("/hooks", func() {
  501. m.Get("", org.Webhooks)
  502. m.Post("/delete", org.DeleteWebhook)
  503. m.Get("/:type/new", repo.WebhooksNew)
  504. m.Post("/gitea/new", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksNewPost)
  505. m.Post("/gogs/new", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksNewPost)
  506. m.Post("/slack/new", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksNewPost)
  507. m.Post("/discord/new", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksNewPost)
  508. m.Post("/dingtalk/new", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksNewPost)
  509. m.Post("/telegram/new", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksNewPost)
  510. m.Get("/:id", repo.WebHooksEdit)
  511. m.Post("/gitea/:id", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksEditPost)
  512. m.Post("/gogs/:id", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksEditPost)
  513. m.Post("/slack/:id", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksEditPost)
  514. m.Post("/discord/:id", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksEditPost)
  515. m.Post("/dingtalk/:id", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksEditPost)
  516. m.Post("/telegram/:id", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksEditPost)
  517. })
  518. m.Route("/delete", "GET,POST", org.SettingsDelete)
  519. })
  520. }, context.OrgAssignment(true, true))
  521. }, reqSignIn)
  522. // ***** END: Organization *****
  523. // ***** START: Repository *****
  524. m.Group("/repo", func() {
  525. m.Get("/create", repo.Create)
  526. m.Post("/create", bindIgnErr(auth.CreateRepoForm{}), repo.CreatePost)
  527. m.Get("/migrate", repo.Migrate)
  528. m.Post("/migrate", bindIgnErr(auth.MigrateRepoForm{}), repo.MigratePost)
  529. m.Group("/fork", func() {
  530. m.Combo("/:repoid").Get(repo.Fork).
  531. Post(bindIgnErr(auth.CreateRepoForm{}), repo.ForkPost)
  532. }, context.RepoIDAssignment(), context.UnitTypes(), reqRepoCodeReader)
  533. }, reqSignIn)
  534. // ***** Release Attachment Download without Signin
  535. m.Get("/:username/:reponame/releases/download/:vTag/:fileName", ignSignIn, context.RepoAssignment(), repo.MustBeNotEmpty, repo.RedirectDownload)
  536. m.Group("/:username/:reponame", func() {
  537. m.Group("/settings", func() {
  538. m.Combo("").Get(repo.Settings).
  539. Post(bindIgnErr(auth.RepoSettingForm{}), repo.SettingsPost)
  540. m.Post("/avatar", binding.MultipartForm(auth.AvatarForm{}), repo.SettingsAvatar)
  541. m.Post("/avatar/delete", repo.SettingsDeleteAvatar)
  542. m.Group("/collaboration", func() {
  543. m.Combo("").Get(repo.Collaboration).Post(repo.CollaborationPost)
  544. m.Post("/access_mode", repo.ChangeCollaborationAccessMode)
  545. m.Post("/delete", repo.DeleteCollaboration)
  546. m.Group("/team", func() {
  547. m.Post("", repo.AddTeamPost)
  548. m.Post("/delete", repo.DeleteTeam)
  549. })
  550. })
  551. m.Group("/branches", func() {
  552. m.Combo("").Get(repo.ProtectedBranch).Post(repo.ProtectedBranchPost)
  553. m.Combo("/*").Get(repo.SettingsProtectedBranch).
  554. Post(bindIgnErr(auth.ProtectBranchForm{}), context.RepoMustNotBeArchived(), repo.SettingsProtectedBranchPost)
  555. }, repo.MustBeNotEmpty)
  556. m.Group("/hooks", func() {
  557. m.Get("", repo.Webhooks)
  558. m.Post("/delete", repo.DeleteWebhook)
  559. m.Get("/:type/new", repo.WebhooksNew)
  560. m.Post("/gitea/new", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksNewPost)
  561. m.Post("/gogs/new", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksNewPost)
  562. m.Post("/slack/new", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksNewPost)
  563. m.Post("/discord/new", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksNewPost)
  564. m.Post("/dingtalk/new", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksNewPost)
  565. m.Post("/telegram/new", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksNewPost)
  566. m.Post("/msteams/new", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksNewPost)
  567. m.Get("/:id", repo.WebHooksEdit)
  568. m.Post("/:id/test", repo.TestWebhook)
  569. m.Post("/gitea/:id", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksEditPost)
  570. m.Post("/gogs/:id", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksEditPost)
  571. m.Post("/slack/:id", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksEditPost)
  572. m.Post("/discord/:id", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksEditPost)
  573. m.Post("/dingtalk/:id", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksEditPost)
  574. m.Post("/telegram/:id", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksEditPost)
  575. m.Post("/msteams/:id", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksEditPost)
  576. m.Group("/git", func() {
  577. m.Get("", repo.GitHooks)
  578. m.Combo("/:name").Get(repo.GitHooksEdit).
  579. Post(repo.GitHooksEditPost)
  580. }, context.GitHookService())
  581. })
  582. m.Group("/keys", func() {
  583. m.Combo("").Get(repo.DeployKeys).
  584. Post(bindIgnErr(auth.AddKeyForm{}), repo.DeployKeysPost)
  585. m.Post("/delete", repo.DeleteDeployKey)
  586. })
  587. m.Group("/lfs", func() {
  588. m.Get("", repo.LFSFiles)
  589. m.Get("/show/:oid", repo.LFSFileGet)
  590. m.Post("/delete/:oid", repo.LFSDelete)
  591. m.Get("/pointers", repo.LFSPointerFiles)
  592. m.Post("/pointers/associate", repo.LFSAutoAssociate)
  593. m.Get("/find", repo.LFSFileFind)
  594. m.Group("/locks", func() {
  595. m.Get("/", repo.LFSLocks)
  596. m.Post("/", repo.LFSLockFile)
  597. m.Post("/:lid/unlock", repo.LFSUnlock)
  598. })
  599. })
  600. }, func(ctx *context.Context) {
  601. ctx.Data["PageIsSettings"] = true
  602. ctx.Data["LFSStartServer"] = setting.LFS.StartServer
  603. })
  604. }, reqSignIn, context.RepoAssignment(), context.UnitTypes(), reqRepoAdmin, context.RepoRef())
  605. m.Get("/:username/:reponame/action/:action", reqSignIn, context.RepoAssignment(), context.UnitTypes(), repo.Action)
  606. m.Group("/:username/:reponame", func() {
  607. m.Group("/issues", func() {
  608. m.Combo("/new").Get(context.RepoRef(), repo.NewIssue).
  609. Post(bindIgnErr(auth.CreateIssueForm{}), repo.NewIssuePost)
  610. }, context.RepoMustNotBeArchived(), reqRepoIssueReader)
  611. // FIXME: should use different URLs but mostly same logic for comments of issue and pull reuqest.
  612. // So they can apply their own enable/disable logic on routers.
  613. m.Group("/issues", func() {
  614. m.Group("/:index", func() {
  615. m.Post("/title", repo.UpdateIssueTitle)
  616. m.Post("/content", repo.UpdateIssueContent)
  617. m.Post("/watch", repo.IssueWatch)
  618. m.Group("/dependency", func() {
  619. m.Post("/add", repo.AddDependency)
  620. m.Post("/delete", repo.RemoveDependency)
  621. })
  622. m.Combo("/comments").Post(repo.MustAllowUserComment, bindIgnErr(auth.CreateCommentForm{}), repo.NewComment)
  623. m.Group("/times", func() {
  624. m.Post("/add", bindIgnErr(auth.AddTimeManuallyForm{}), repo.AddTimeManually)
  625. m.Group("/stopwatch", func() {
  626. m.Post("/toggle", repo.IssueStopwatch)
  627. m.Post("/cancel", repo.CancelStopwatch)
  628. })
  629. })
  630. m.Post("/reactions/:action", bindIgnErr(auth.ReactionForm{}), repo.ChangeIssueReaction)
  631. m.Post("/lock", reqRepoIssueWriter, bindIgnErr(auth.IssueLockForm{}), repo.LockIssue)
  632. m.Post("/unlock", reqRepoIssueWriter, repo.UnlockIssue)
  633. m.Get("/attachments", repo.GetIssueAttachments)
  634. }, context.RepoMustNotBeArchived())
  635. m.Post("/labels", reqRepoIssuesOrPullsWriter, repo.UpdateIssueLabel)
  636. m.Post("/milestone", reqRepoIssuesOrPullsWriter, repo.UpdateIssueMilestone)
  637. m.Post("/assignee", reqRepoIssuesOrPullsWriter, repo.UpdateIssueAssignee)
  638. m.Post("/status", reqRepoIssuesOrPullsWriter, repo.UpdateIssueStatus)
  639. }, context.RepoMustNotBeArchived())
  640. m.Group("/comments/:id", func() {
  641. m.Post("", repo.UpdateCommentContent)
  642. m.Post("/delete", repo.DeleteComment)
  643. m.Post("/reactions/:action", bindIgnErr(auth.ReactionForm{}), repo.ChangeCommentReaction)
  644. m.Get("/attachments", repo.GetCommentAttachments)
  645. }, context.RepoMustNotBeArchived())
  646. m.Group("/labels", func() {
  647. m.Post("/new", bindIgnErr(auth.CreateLabelForm{}), repo.NewLabel)
  648. m.Post("/edit", bindIgnErr(auth.CreateLabelForm{}), repo.UpdateLabel)
  649. m.Post("/delete", repo.DeleteLabel)
  650. m.Post("/initialize", bindIgnErr(auth.InitializeLabelsForm{}), repo.InitializeLabels)
  651. }, context.RepoMustNotBeArchived(), reqRepoIssuesOrPullsWriter, context.RepoRef())
  652. m.Group("/milestones", func() {
  653. m.Combo("/new").Get(repo.NewMilestone).
  654. Post(bindIgnErr(auth.CreateMilestoneForm{}), repo.NewMilestonePost)
  655. m.Get("/:id/edit", repo.EditMilestone)
  656. m.Post("/:id/edit", bindIgnErr(auth.CreateMilestoneForm{}), repo.EditMilestonePost)
  657. m.Get("/:id/:action", repo.ChangeMilestonStatus)
  658. m.Post("/delete", repo.DeleteMilestone)
  659. }, context.RepoMustNotBeArchived(), reqRepoIssuesOrPullsWriter, context.RepoRef())
  660. m.Group("/milestone", func() {
  661. m.Get("/:id", repo.MilestoneIssuesAndPulls)
  662. }, reqRepoIssuesOrPullsReader, context.RepoRef())
  663. m.Combo("/compare/*", repo.MustBeNotEmpty, reqRepoCodeReader, repo.SetEditorconfigIfExists).
  664. Get(repo.SetDiffViewStyle, repo.CompareDiff).
  665. Post(context.RepoMustNotBeArchived(), reqRepoPullsReader, repo.MustAllowPulls, bindIgnErr(auth.CreateIssueForm{}), repo.CompareAndPullRequestPost)
  666. m.Group("/pull", func() {
  667. m.Post("/:index/target_branch", repo.UpdatePullRequestTarget)
  668. }, context.RepoMustNotBeArchived())
  669. m.Group("", func() {
  670. m.Group("", func() {
  671. m.Combo("/_edit/*").Get(repo.EditFile).
  672. Post(bindIgnErr(auth.EditRepoFileForm{}), repo.EditFilePost)
  673. m.Combo("/_new/*").Get(repo.NewFile).
  674. Post(bindIgnErr(auth.EditRepoFileForm{}), repo.NewFilePost)
  675. m.Post("/_preview/*", bindIgnErr(auth.EditPreviewDiffForm{}), repo.DiffPreviewPost)
  676. m.Combo("/_delete/*").Get(repo.DeleteFile).
  677. Post(bindIgnErr(auth.DeleteRepoFileForm{}), repo.DeleteFilePost)
  678. m.Combo("/_upload/*", repo.MustBeAbleToUpload).
  679. Get(repo.UploadFile).
  680. Post(bindIgnErr(auth.UploadRepoFileForm{}), repo.UploadFilePost)
  681. }, context.RepoRefByType(context.RepoRefBranch), repo.MustBeEditable)
  682. m.Group("", func() {
  683. m.Post("/upload-file", repo.UploadFileToServer)
  684. m.Post("/upload-remove", bindIgnErr(auth.RemoveUploadFileForm{}), repo.RemoveUploadFileFromServer)
  685. }, context.RepoRef(), repo.MustBeEditable, repo.MustBeAbleToUpload)
  686. }, context.RepoMustNotBeArchived(), reqRepoCodeWriter, repo.MustBeNotEmpty)
  687. m.Group("/branches", func() {
  688. m.Group("/_new/", func() {
  689. m.Post("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.CreateBranch)
  690. m.Post("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.CreateBranch)
  691. m.Post("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.CreateBranch)
  692. }, bindIgnErr(auth.NewBranchForm{}))
  693. m.Post("/delete", repo.DeleteBranchPost)
  694. m.Post("/restore", repo.RestoreBranchPost)
  695. }, context.RepoMustNotBeArchived(), reqRepoCodeWriter, repo.MustBeNotEmpty)
  696. }, reqSignIn, context.RepoAssignment(), context.UnitTypes())
  697. // Releases
  698. m.Group("/:username/:reponame", func() {
  699. m.Group("/releases", func() {
  700. m.Get("/", repo.MustBeNotEmpty, repo.Releases)
  701. }, repo.MustBeNotEmpty, context.RepoRef())
  702. m.Group("/releases", func() {
  703. m.Get("/new", repo.NewRelease)
  704. m.Post("/new", bindIgnErr(auth.NewReleaseForm{}), repo.NewReleasePost)
  705. m.Post("/delete", repo.DeleteRelease)
  706. }, reqSignIn, repo.MustBeNotEmpty, context.RepoMustNotBeArchived(), reqRepoReleaseWriter, context.RepoRef())
  707. m.Group("/releases", func() {
  708. m.Get("/edit/*", repo.EditRelease)
  709. m.Post("/edit/*", bindIgnErr(auth.EditReleaseForm{}), repo.EditReleasePost)
  710. }, reqSignIn, repo.MustBeNotEmpty, context.RepoMustNotBeArchived(), reqRepoReleaseWriter, func(ctx *context.Context) {
  711. var err error
  712. ctx.Repo.Commit, err = ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch)
  713. if err != nil {
  714. ctx.ServerError("GetBranchCommit", err)
  715. return
  716. }
  717. ctx.Repo.CommitsCount, err = ctx.Repo.GetCommitsCount()
  718. if err != nil {
  719. ctx.ServerError("GetCommitsCount", err)
  720. return
  721. }
  722. ctx.Data["CommitsCount"] = ctx.Repo.CommitsCount
  723. })
  724. }, ignSignIn, context.RepoAssignment(), context.UnitTypes(), reqRepoReleaseReader)
  725. m.Group("/:username/:reponame", func() {
  726. m.Post("/topics", repo.TopicsPost)
  727. }, context.RepoAssignment(), context.RepoMustNotBeArchived(), reqRepoAdmin)
  728. m.Group("/:username/:reponame", func() {
  729. m.Group("", func() {
  730. m.Get("/^:type(issues|pulls)$", repo.Issues)
  731. m.Get("/^:type(issues|pulls)$/:index", repo.ViewIssue)
  732. m.Get("/labels/", reqRepoIssuesOrPullsReader, repo.RetrieveLabels, repo.Labels)
  733. m.Get("/milestones", reqRepoIssuesOrPullsReader, repo.Milestones)
  734. }, context.RepoRef())
  735. m.Group("/wiki", func() {
  736. m.Get("/?:page", repo.Wiki)
  737. m.Get("/_pages", repo.WikiPages)
  738. m.Get("/:page/_revision", repo.WikiRevision)
  739. m.Group("", func() {
  740. m.Combo("/_new").Get(repo.NewWiki).
  741. Post(bindIgnErr(auth.NewWikiForm{}), repo.NewWikiPost)
  742. m.Combo("/:page/_edit").Get(repo.EditWiki).
  743. Post(bindIgnErr(auth.NewWikiForm{}), repo.EditWikiPost)
  744. m.Post("/:page/delete", repo.DeleteWikiPagePost)
  745. }, context.RepoMustNotBeArchived(), reqSignIn, reqRepoWikiWriter)
  746. }, repo.MustEnableWiki, context.RepoRef())
  747. m.Group("/wiki", func() {
  748. m.Get("/raw/*", repo.WikiRaw)
  749. }, repo.MustEnableWiki)
  750. m.Group("/activity", func() {
  751. m.Get("", repo.Activity)
  752. m.Get("/:period", repo.Activity)
  753. }, context.RepoRef(), repo.MustBeNotEmpty, context.RequireRepoReaderOr(models.UnitTypePullRequests, models.UnitTypeIssues, models.UnitTypeReleases))
  754. m.Group("/activity_author_data", func() {
  755. m.Get("", repo.ActivityAuthors)
  756. m.Get("/:period", repo.ActivityAuthors)
  757. }, context.RepoRef(), repo.MustBeNotEmpty, context.RequireRepoReaderOr(models.UnitTypeCode))
  758. m.Get("/archive/*", repo.MustBeNotEmpty, reqRepoCodeReader, repo.Download)
  759. m.Get("/status", reqRepoCodeReader, repo.Status)
  760. m.Group("/branches", func() {
  761. m.Get("", repo.Branches)
  762. }, repo.MustBeNotEmpty, context.RepoRef(), reqRepoCodeReader)
  763. m.Group("/blob_excerpt", func() {
  764. m.Get("/:sha", repo.SetEditorconfigIfExists, repo.SetDiffViewStyle, repo.ExcerptBlob)
  765. }, repo.MustBeNotEmpty, context.RepoRef(), reqRepoCodeReader)
  766. m.Group("/pulls/:index", func() {
  767. m.Get(".diff", repo.DownloadPullDiff)
  768. m.Get(".patch", repo.DownloadPullPatch)
  769. m.Get("/commits", context.RepoRef(), repo.ViewPullCommits)
  770. m.Post("/merge", context.RepoMustNotBeArchived(), reqRepoPullsWriter, bindIgnErr(auth.MergePullRequestForm{}), repo.MergePullRequest)
  771. m.Post("/cleanup", context.RepoMustNotBeArchived(), context.RepoRef(), repo.CleanUpPullRequest)
  772. m.Group("/files", func() {
  773. m.Get("", context.RepoRef(), repo.SetEditorconfigIfExists, repo.SetDiffViewStyle, repo.SetWhitespaceBehavior, repo.ViewPullFiles)
  774. m.Group("/reviews", func() {
  775. m.Post("/comments", bindIgnErr(auth.CodeCommentForm{}), repo.CreateCodeComment)
  776. m.Post("/submit", bindIgnErr(auth.SubmitReviewForm{}), repo.SubmitReview)
  777. }, context.RepoMustNotBeArchived())
  778. })
  779. }, repo.MustAllowPulls)
  780. m.Group("/media", func() {
  781. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.SingleDownloadOrLFS)
  782. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.SingleDownloadOrLFS)
  783. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.SingleDownloadOrLFS)
  784. m.Get("/blob/:sha", context.RepoRefByType(context.RepoRefBlob), repo.DownloadByIDOrLFS)
  785. // "/*" route is deprecated, and kept for backward compatibility
  786. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.SingleDownloadOrLFS)
  787. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  788. m.Group("/raw", func() {
  789. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.SingleDownload)
  790. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.SingleDownload)
  791. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.SingleDownload)
  792. m.Get("/blob/:sha", context.RepoRefByType(context.RepoRefBlob), repo.DownloadByID)
  793. // "/*" route is deprecated, and kept for backward compatibility
  794. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.SingleDownload)
  795. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  796. m.Group("/commits", func() {
  797. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.RefCommits)
  798. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.RefCommits)
  799. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.RefCommits)
  800. // "/*" route is deprecated, and kept for backward compatibility
  801. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.RefCommits)
  802. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  803. m.Group("/blame", func() {
  804. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.RefBlame)
  805. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.RefBlame)
  806. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.RefBlame)
  807. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  808. m.Group("", func() {
  809. m.Get("/graph", repo.Graph)
  810. m.Get("/commit/:sha([a-f0-9]{7,40})$", repo.SetEditorconfigIfExists, repo.SetDiffViewStyle, repo.Diff)
  811. }, repo.MustBeNotEmpty, context.RepoRef(), reqRepoCodeReader)
  812. m.Group("/src", func() {
  813. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.Home)
  814. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.Home)
  815. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.Home)
  816. // "/*" route is deprecated, and kept for backward compatibility
  817. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.Home)
  818. }, repo.SetEditorconfigIfExists)
  819. m.Group("", func() {
  820. m.Get("/forks", repo.Forks)
  821. }, context.RepoRef(), reqRepoCodeReader)
  822. m.Get("/commit/:sha([a-f0-9]{7,40})\\.:ext(patch|diff)",
  823. repo.MustBeNotEmpty, reqRepoCodeReader, repo.RawDiff)
  824. }, ignSignIn, context.RepoAssignment(), context.UnitTypes())
  825. m.Group("/:username/:reponame", func() {
  826. m.Get("/stars", repo.Stars)
  827. m.Get("/watchers", repo.Watchers)
  828. m.Get("/search", reqRepoCodeReader, repo.Search)
  829. }, ignSignIn, context.RepoAssignment(), context.RepoRef(), context.UnitTypes())
  830. m.Group("/:username", func() {
  831. m.Group("/:reponame", func() {
  832. m.Get("", repo.SetEditorconfigIfExists, repo.Home)
  833. m.Get("\\.git$", repo.SetEditorconfigIfExists, repo.Home)
  834. }, ignSignIn, context.RepoAssignment(), context.RepoRef(), context.UnitTypes())
  835. m.Group("/:reponame", func() {
  836. m.Group("\\.git/info/lfs", func() {
  837. m.Post("/objects/batch", lfs.BatchHandler)
  838. m.Get("/objects/:oid/:filename", lfs.ObjectOidHandler)
  839. m.Any("/objects/:oid", lfs.ObjectOidHandler)
  840. m.Post("/objects", lfs.PostHandler)
  841. m.Post("/verify", lfs.VerifyHandler)
  842. m.Group("/locks", func() {
  843. m.Get("/", lfs.GetListLockHandler)
  844. m.Post("/", lfs.PostLockHandler)
  845. m.Post("/verify", lfs.VerifyLockHandler)
  846. m.Post("/:lid/unlock", lfs.UnLockHandler)
  847. })
  848. m.Any("/*", func(ctx *context.Context) {
  849. ctx.NotFound("", nil)
  850. })
  851. }, ignSignInAndCsrf)
  852. m.Any("/*", ignSignInAndCsrf, repo.HTTP)
  853. m.Head("/tasks/trigger", repo.TriggerTask)
  854. })
  855. })
  856. // ***** END: Repository *****
  857. m.Group("/notifications", func() {
  858. m.Get("", user.Notifications)
  859. m.Post("/status", user.NotificationStatusPost)
  860. m.Post("/purge", user.NotificationPurgePost)
  861. }, reqSignIn)
  862. if setting.API.EnableSwagger {
  863. m.Get("/swagger.v1.json", templates.JSONRenderer(), routers.SwaggerV1Json)
  864. }
  865. var handlers []macaron.Handler
  866. if setting.EnableCORS {
  867. handlers = append(handlers, cors.CORS(setting.CORSConfig))
  868. }
  869. handlers = append(handlers, ignSignIn)
  870. m.Group("/api", func() {
  871. apiv1.RegisterRoutes(m)
  872. }, handlers...)
  873. m.Group("/api/internal", func() {
  874. // package name internal is ideal but Golang is not allowed, so we use private as package name.
  875. private.RegisterRoutes(m)
  876. })
  877. // robots.txt
  878. m.Get("/robots.txt", func(ctx *context.Context) {
  879. if setting.HasRobotsTxt {
  880. ctx.ServeFileContent(path.Join(setting.CustomPath, "robots.txt"))
  881. } else {
  882. ctx.NotFound("", nil)
  883. }
  884. })
  885. // Progressive Web App
  886. m.Get("/manifest.json", templates.JSONRenderer(), func(ctx *context.Context) {
  887. ctx.HTML(200, "pwa/manifest_json")
  888. })
  889. m.Get("/serviceworker.js", templates.JSRenderer(), func(ctx *context.Context) {
  890. ctx.HTML(200, "pwa/serviceworker_js")
  891. })
  892. // prometheus metrics endpoint
  893. if setting.Metrics.Enabled {
  894. c := metrics.NewCollector()
  895. prometheus.MustRegister(c)
  896. m.Get("/metrics", routers.Metrics)
  897. }
  898. // Not found handler.
  899. m.NotFound(routers.NotFound)
  900. }