You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

316 lines
8.3 KiB

10 years ago
10 years ago
API add/generalize pagination (#9452) * paginate results * fixed deadlock * prevented breaking change * updated swagger * go fmt * fixed find topic * go mod tidy * go mod vendor with go1.13.5 * fixed repo find topics * fixed unit test * added Limit method to Engine struct; use engine variable when provided; fixed gitignore * use ItemsPerPage for default pagesize; fix GetWatchers, getOrgUsersByOrgID and GetStargazers; fix GetAllCommits headers; reverted some changed behaviors * set Page value on Home route * improved memory allocations * fixed response headers * removed logfiles * fixed import order * import order * improved swagger * added function to get models.ListOptions from context * removed pagesize diff on unit test * fixed imports * removed unnecessary struct field * fixed go fmt * scoped PR * code improvements * code improvements * go mod tidy * fixed import order * fixed commit statuses session * fixed files headers * fixed headers; added pagination for notifications * go mod tidy * go fmt * removed Private from user search options; added setting.UI.IssuePagingNum as default valeu on repo's issues list * Apply suggestions from code review Co-Authored-By: 6543 <6543@obermui.de> Co-Authored-By: zeripath <art27@cantab.net> * fixed build error * CI.restart() * fixed merge conflicts resolve * fixed conflicts resolve * improved FindTrackedTimesOptions.ToOptions() method * added backwards compatibility on ListReleases request; fixed issue tracked time ToSession * fixed build error; fixed swagger template * fixed swagger template * fixed ListReleases backwards compatibility * added page to user search route Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: zeripath <art27@cantab.net>
4 years ago
10 years ago
Feature: Timetracking (#2211) * Added comment's hashtag to url for mail notifications. * Added explanation to return statement + documentation. * Replacing in-line link generation with HTMLURL. (+gofmt) * Replaced action-based model with nil-based model. (+gofmt) * Replaced mailIssueActionToParticipants with mailIssueCommentToParticipants. * Updating comment for mailIssueCommentToParticipants * Added link to comment in "Dashboard" * Deleting feed entry if a comment is going to be deleted * Added migration * Added improved migration to add a CommentID column to action. * Added improved links to comments in feed entries. * Fixes #1956 by filtering for deleted comments that are referenced in actions. * Introducing "IsDeleted" column to action. * Adding design draft (not functional) * Adding database models for stopwatches and trackedtimes * See go-gitea/gitea#967 * Adding design draft (not functional) * Adding translations and improving design * Implementing stopwatch (for timetracking) * Make UI functional * Add hints in timeline for time tracking events * Implementing timetracking feature * Adding "Add time manual" option * Improved stopwatch * Created report of total spent time by user * Only showing total time spent if theire is something to show. * Adding license headers. * Improved error handling for "Add Time Manual" * Adding @sapks 's changes, refactoring * Adding API for feature tracking * Adding unit test * Adding DISABLE/ENABLE option to Repository settings page * Improving translations * Applying @sapk 's changes * Removing repo_unit and using IssuesSetting for disabling/enabling timetracker * Adding DEFAULT_ENABLE_TIMETRACKER to config, installation and admin menu * Improving documentation * Fixing vendor/ folder * Changing timtracking routes by adding subgroups /times and /times/stopwatch (Proposed by @lafriks ) * Restricting write access to timetracking based on the repo settings (Proposed by @lafriks ) * Fixed minor permissions bug. * Adding CanUseTimetracker and IsTimetrackerEnabled in ctx.Repo * Allow assignees and authors to track there time too. * Fixed some build-time-errors + logical errors. * Removing unused Get...ByID functions * Moving IsTimetrackerEnabled from context.Repository to models.Repository * Adding a seperate file for issue related repo functions * Adding license headers * Fixed GetUserByParams return 404 * Moving /users/:username/times to /repos/:username/:reponame/times/:username for security reasons * Adding /repos/:username/times to get all tracked times of the repo * Updating sdk-dependency * Updating swagger.v1.json * Adding warning if user has already a running stopwatch (auto-timetracker) * Replacing GetTrackedTimesBy... with GetTrackedTimes(options FindTrackedTimesOptions) * Changing code.gitea.io/sdk back to code.gitea.io/sdk * Correcting spelling mistake * Updating vendor.json * Changing GET stopwatch/toggle to POST stopwatch/toggle * Changing GET stopwatch/cancel to POST stopwatch/cancel * Added migration for stopwatches/timetracking * Fixed some access bugs for read-only users * Added default allow only contributors to track time value to config * Fixed migration by chaging x.Iterate to x.Find * Resorted imports * Moved Add Time Manually form to repo_form.go * Removed "Seconds" field from Add Time Manually * Resorted imports * Improved permission checking * Fixed some bugs * Added integration test * gofmt * Adding integration test by @lafriks * Added created_unix to comment fixtures * Using last event instead of a fixed event * Adding another integration test by @lafriks * Fixing bug Timetracker enabled causing error 500 at sidebar.tpl * Fixed a refactoring bug that resulted in hiding "HasUserStopwatch" warning. * Returning TrackedTime instead of AddTimeOption at AddTime. * Updating SDK from go-gitea/go-sdk#69 * Resetting Go-SDK back to default repository * Fixing test-vendor by changing ini back to original repository * Adding "tags" to swagger spec * govendor sync * Removed duplicate * Formatting templates * Adding IsTimetrackingEnabled checks to API * Improving translations / english texts * Improving documentation * Updating swagger spec * Fixing integration test caused be translation-changes * Removed encoding issues in local_en-US.ini. * "Added" copyright line * Moved unit.IssuesConfig().EnableTimetracker into a != nil check * Removed some other encoding issues in local_en-US.ini * Improved javascript by checking if data-context exists * Replaced manual comment creation with CreateComment * Removed unnecessary code * Improved error checking * Small cosmetic changes * Replaced int>string>duration parsing with int>duration parsing * Fixed encoding issues * Removed unused imports Signed-off-by: Jonas Franz <info@jonasfranz.software>
7 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
6 years ago
10 years ago
10 years ago
9 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
10 years ago
  1. // Copyright 2014 The Gogs Authors. All rights reserved.
  2. // Copyright 2018 The Gitea Authors. All rights reserved.
  3. // Use of this source code is governed by a MIT-style
  4. // license that can be found in the LICENSE file.
  5. package models
  6. import (
  7. "context"
  8. "database/sql"
  9. "errors"
  10. "fmt"
  11. "code.gitea.io/gitea/modules/setting"
  12. // Needed for the MySQL driver
  13. _ "github.com/go-sql-driver/mysql"
  14. "xorm.io/xorm"
  15. "xorm.io/xorm/names"
  16. "xorm.io/xorm/schemas"
  17. // Needed for the Postgresql driver
  18. _ "github.com/lib/pq"
  19. // Needed for the MSSQL driver
  20. _ "github.com/denisenkom/go-mssqldb"
  21. )
  22. // Engine represents a xorm engine or session.
  23. type Engine interface {
  24. Table(tableNameOrBean interface{}) *xorm.Session
  25. Count(...interface{}) (int64, error)
  26. Decr(column string, arg ...interface{}) *xorm.Session
  27. Delete(interface{}) (int64, error)
  28. Exec(...interface{}) (sql.Result, error)
  29. Find(interface{}, ...interface{}) error
  30. Get(interface{}) (bool, error)
  31. ID(interface{}) *xorm.Session
  32. In(string, ...interface{}) *xorm.Session
  33. Incr(column string, arg ...interface{}) *xorm.Session
  34. Insert(...interface{}) (int64, error)
  35. InsertOne(interface{}) (int64, error)
  36. Iterate(interface{}, xorm.IterFunc) error
  37. Join(joinOperator string, tablename interface{}, condition string, args ...interface{}) *xorm.Session
  38. SQL(interface{}, ...interface{}) *xorm.Session
  39. Where(interface{}, ...interface{}) *xorm.Session
  40. Asc(colNames ...string) *xorm.Session
  41. Desc(colNames ...string) *xorm.Session
  42. Limit(limit int, start ...int) *xorm.Session
  43. SumInt(bean interface{}, columnName string) (res int64, err error)
  44. }
  45. const (
  46. // When queries are broken down in parts because of the number
  47. // of parameters, attempt to break by this amount
  48. maxQueryParameters = 300
  49. )
  50. var (
  51. x *xorm.Engine
  52. tables []interface{}
  53. // HasEngine specifies if we have a xorm.Engine
  54. HasEngine bool
  55. )
  56. func init() {
  57. tables = append(tables,
  58. new(User),
  59. new(PublicKey),
  60. new(AccessToken),
  61. new(Repository),
  62. new(DeployKey),
  63. new(Collaboration),
  64. new(Access),
  65. new(Upload),
  66. new(Watch),
  67. new(Star),
  68. new(Follow),
  69. new(Action),
  70. new(Issue),
  71. new(PullRequest),
  72. new(Comment),
  73. new(Attachment),
  74. new(Label),
  75. new(IssueLabel),
  76. new(Milestone),
  77. new(Mirror),
  78. new(Release),
  79. new(LoginSource),
  80. new(Webhook),
  81. new(HookTask),
  82. new(Team),
  83. new(OrgUser),
  84. new(TeamUser),
  85. new(TeamRepo),
  86. new(Notice),
  87. new(EmailAddress),
  88. new(Notification),
  89. new(IssueUser),
  90. new(LFSMetaObject),
  91. new(TwoFactor),
  92. new(GPGKey),
  93. new(GPGKeyImport),
  94. new(RepoUnit),
  95. new(RepoRedirect),
  96. new(ExternalLoginUser),
  97. new(ProtectedBranch),
  98. new(UserOpenID),
  99. new(IssueWatch),
  100. new(CommitStatus),
  101. new(Stopwatch),
  102. new(TrackedTime),
  103. new(DeletedBranch),
  104. new(RepoIndexerStatus),
  105. new(IssueDependency),
  106. new(LFSLock),
  107. new(Reaction),
  108. new(IssueAssignees),
  109. new(U2FRegistration),
  110. new(TeamUnit),
  111. new(Review),
  112. new(OAuth2Application),
  113. new(OAuth2AuthorizationCode),
  114. new(OAuth2Grant),
  115. new(Task),
  116. new(LanguageStat),
  117. new(EmailHash),
  118. new(Project),
  119. new(ProjectBoard),
  120. new(ProjectIssue),
  121. )
  122. gonicNames := []string{"SSL", "UID"}
  123. for _, name := range gonicNames {
  124. names.LintGonicMapper[name] = true
  125. }
  126. }
  127. func getEngine() (*xorm.Engine, error) {
  128. connStr, err := setting.DBConnStr()
  129. if err != nil {
  130. return nil, err
  131. }
  132. engine, err := xorm.NewEngine(setting.Database.Type, connStr)
  133. if err != nil {
  134. return nil, err
  135. }
  136. if setting.Database.Type == "mysql" {
  137. engine.Dialect().SetParams(map[string]string{"rowFormat": "DYNAMIC"})
  138. } else if setting.Database.Type == "mssql" {
  139. engine.Dialect().SetParams(map[string]string{"DEFAULT_VARCHAR": "nvarchar"})
  140. }
  141. engine.SetSchema(setting.Database.Schema)
  142. return engine, nil
  143. }
  144. // NewTestEngine sets a new test xorm.Engine
  145. func NewTestEngine() (err error) {
  146. x, err = getEngine()
  147. if err != nil {
  148. return fmt.Errorf("Connect to database: %v", err)
  149. }
  150. x.SetMapper(names.GonicMapper{})
  151. x.SetLogger(NewXORMLogger(!setting.ProdMode))
  152. x.ShowSQL(!setting.ProdMode)
  153. return x.StoreEngine("InnoDB").Sync2(tables...)
  154. }
  155. // SetEngine sets the xorm.Engine
  156. func SetEngine() (err error) {
  157. x, err = getEngine()
  158. if err != nil {
  159. return fmt.Errorf("Failed to connect to database: %v", err)
  160. }
  161. x.SetMapper(names.GonicMapper{})
  162. // WARNING: for serv command, MUST remove the output to os.stdout,
  163. // so use log file to instead print to stdout.
  164. x.SetLogger(NewXORMLogger(setting.Database.LogSQL))
  165. x.ShowSQL(setting.Database.LogSQL)
  166. x.SetMaxOpenConns(setting.Database.MaxOpenConns)
  167. x.SetMaxIdleConns(setting.Database.MaxIdleConns)
  168. x.SetConnMaxLifetime(setting.Database.ConnMaxLifetime)
  169. return nil
  170. }
  171. // NewEngine initializes a new xorm.Engine
  172. // This function must never call .Sync2() if the provided migration function fails.
  173. // When called from the "doctor" command, the migration function is a version check
  174. // that prevents the doctor from fixing anything in the database if the migration level
  175. // is different from the expected value.
  176. func NewEngine(ctx context.Context, migrateFunc func(*xorm.Engine) error) (err error) {
  177. if err = SetEngine(); err != nil {
  178. return err
  179. }
  180. x.SetDefaultContext(ctx)
  181. if err = x.Ping(); err != nil {
  182. return err
  183. }
  184. if err = migrateFunc(x); err != nil {
  185. return fmt.Errorf("migrate: %v", err)
  186. }
  187. if err = x.StoreEngine("InnoDB").Sync2(tables...); err != nil {
  188. return fmt.Errorf("sync database struct error: %v", err)
  189. }
  190. return nil
  191. }
  192. // Statistic contains the database statistics
  193. type Statistic struct {
  194. Counter struct {
  195. User, Org, PublicKey,
  196. Repo, Watch, Star, Action, Access,
  197. Issue, Comment, Oauth, Follow,
  198. Mirror, Release, LoginSource, Webhook,
  199. Milestone, Label, HookTask,
  200. Team, UpdateTask, Attachment int64
  201. }
  202. }
  203. // GetStatistic returns the database statistics
  204. func GetStatistic() (stats Statistic) {
  205. stats.Counter.User = CountUsers()
  206. stats.Counter.Org = CountOrganizations()
  207. stats.Counter.PublicKey, _ = x.Count(new(PublicKey))
  208. stats.Counter.Repo = CountRepositories(true)
  209. stats.Counter.Watch, _ = x.Count(new(Watch))
  210. stats.Counter.Star, _ = x.Count(new(Star))
  211. stats.Counter.Action, _ = x.Count(new(Action))
  212. stats.Counter.Access, _ = x.Count(new(Access))
  213. stats.Counter.Issue, _ = x.Count(new(Issue))
  214. stats.Counter.Comment, _ = x.Count(new(Comment))
  215. stats.Counter.Oauth = 0
  216. stats.Counter.Follow, _ = x.Count(new(Follow))
  217. stats.Counter.Mirror, _ = x.Count(new(Mirror))
  218. stats.Counter.Release, _ = x.Count(new(Release))
  219. stats.Counter.LoginSource = CountLoginSources()
  220. stats.Counter.Webhook, _ = x.Count(new(Webhook))
  221. stats.Counter.Milestone, _ = x.Count(new(Milestone))
  222. stats.Counter.Label, _ = x.Count(new(Label))
  223. stats.Counter.HookTask, _ = x.Count(new(HookTask))
  224. stats.Counter.Team, _ = x.Count(new(Team))
  225. stats.Counter.Attachment, _ = x.Count(new(Attachment))
  226. return
  227. }
  228. // Ping tests if database is alive
  229. func Ping() error {
  230. if x != nil {
  231. return x.Ping()
  232. }
  233. return errors.New("database not configured")
  234. }
  235. // DumpDatabase dumps all data from database according the special database SQL syntax to file system.
  236. func DumpDatabase(filePath string, dbType string) error {
  237. var tbs []*schemas.Table
  238. for _, t := range tables {
  239. t, err := x.TableInfo(t)
  240. if err != nil {
  241. return err
  242. }
  243. tbs = append(tbs, t)
  244. }
  245. if len(dbType) > 0 {
  246. return x.DumpTablesToFile(tbs, filePath, schemas.DBType(dbType))
  247. }
  248. return x.DumpTablesToFile(tbs, filePath)
  249. }
  250. // MaxBatchInsertSize returns the table's max batch insert size
  251. func MaxBatchInsertSize(bean interface{}) int {
  252. t, err := x.TableInfo(bean)
  253. if err != nil {
  254. return 50
  255. }
  256. return 999 / len(t.ColumnsSeq())
  257. }
  258. // Count returns records number according struct's fields as database query conditions
  259. func Count(bean interface{}) (int64, error) {
  260. return x.Count(bean)
  261. }
  262. // IsTableNotEmpty returns true if table has at least one record
  263. func IsTableNotEmpty(tableName string) (bool, error) {
  264. return x.Table(tableName).Exist()
  265. }
  266. // DeleteAllRecords will delete all the records of this table
  267. func DeleteAllRecords(tableName string) error {
  268. _, err := x.Exec(fmt.Sprintf("DELETE FROM %s", tableName))
  269. return err
  270. }
  271. // GetMaxID will return max id of the table
  272. func GetMaxID(beanOrTableName interface{}) (maxID int64, err error) {
  273. _, err = x.Select("MAX(id)").Table(beanOrTableName).Get(&maxID)
  274. return
  275. }
  276. // FindByMaxID filled results as the condition from database
  277. func FindByMaxID(maxID int64, limit int, results interface{}) error {
  278. return x.Where("id <= ?", maxID).
  279. OrderBy("id DESC").
  280. Limit(limit).
  281. Find(results)
  282. }