You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

1020 lines
40 KiB

Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Repository avatars (#6986) * Repository avatars - first variant of code from old work for gogs - add migration 87 - add new option in app.ini - add en-US locale string - add new class in repository.less * Add changed index.css, remove unused template name * Update en-us doc about configuration options * Add comments to new functions, add new option to docker app.ini * Add comment for lint * Remove variable, not needed * Fix formatting * Update swagger api template * Check if avatar exists * Fix avatar link/path checks * Typo * TEXT column can't have a default value * Fixes: - remove old avatar file on upload - use ID in name of avatar file - users may upload same files - add simple tests * Fix fmt check * Generate PNG instead of "static" GIF * More informative comment * Fix error message * Update avatar upload checks: - add file size check - add new option - update config docs - add new string to en-us locale * Fixes: - use FileHEader field for check file size - add new test - upload big image * Fix formatting * Update comments * Update log message * Removed wrong style - not needed * Use Sync2 to migrate * Update repos list view - bigger avatar - fix html blocks alignment * A little adjust avatar size * Use small icons for explore/repo list * Use new cool avatar preparation func by @lafriks * Missing changes for new function * Remove unused import, move imports * Missed new option definition in app.ini Add file size check in user/profile avatar upload * Use smaller field length for Avatar * Use session to update repo DB data, update DeleteAvatar - use session too * Fix err variable definition * As suggested @lafriks - return as soon as possible, code readability
5 years ago
Repository avatars (#6986) * Repository avatars - first variant of code from old work for gogs - add migration 87 - add new option in app.ini - add en-US locale string - add new class in repository.less * Add changed index.css, remove unused template name * Update en-us doc about configuration options * Add comments to new functions, add new option to docker app.ini * Add comment for lint * Remove variable, not needed * Fix formatting * Update swagger api template * Check if avatar exists * Fix avatar link/path checks * Typo * TEXT column can't have a default value * Fixes: - remove old avatar file on upload - use ID in name of avatar file - users may upload same files - add simple tests * Fix fmt check * Generate PNG instead of "static" GIF * More informative comment * Fix error message * Update avatar upload checks: - add file size check - add new option - update config docs - add new string to en-us locale * Fixes: - use FileHEader field for check file size - add new test - upload big image * Fix formatting * Update comments * Update log message * Removed wrong style - not needed * Use Sync2 to migrate * Update repos list view - bigger avatar - fix html blocks alignment * A little adjust avatar size * Use small icons for explore/repo list * Use new cool avatar preparation func by @lafriks * Missing changes for new function * Remove unused import, move imports * Missed new option definition in app.ini Add file size check in user/profile avatar upload * Use smaller field length for Avatar * Use session to update repo DB data, update DeleteAvatar - use session too * Fix err variable definition * As suggested @lafriks - return as soon as possible, code readability
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Better logging (#6038) (#6095) * Panic don't fatal on create new logger Fixes #5854 Signed-off-by: Andrew Thornton <art27@cantab.net> * partial broken * Update the logging infrastrcture Signed-off-by: Andrew Thornton <art27@cantab.net> * Reset the skip levels for Fatal and Error Signed-off-by: Andrew Thornton <art27@cantab.net> * broken ncsa * More log.Error fixes Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove nal * set log-levels to lowercase * Make console_test test all levels * switch to lowercased levels * OK now working * Fix vetting issues * Fix lint * Fix tests * change default logging to match current gitea * Improve log testing Signed-off-by: Andrew Thornton <art27@cantab.net> * reset error skip levels to 0 * Update documentation and access logger configuration * Redirect the router log back to gitea if redirect macaron log but also allow setting the log level - i.e. TRACE * Fix broken level caching * Refactor the router log * Add Router logger * Add colorizing options * Adjust router colors * Only create logger if they will be used * update app.ini.sample * rename Attribute ColorAttribute * Change from white to green for function * Set fatal/error levels * Restore initial trace logger * Fix Trace arguments in modules/auth/auth.go * Properly handle XORMLogger * Improve admin/config page * fix fmt * Add auto-compression of old logs * Update error log levels * Remove the unnecessary skip argument from Error, Fatal and Critical * Add stacktrace support * Fix tests * Remove x/sync from vendors? * Add stderr option to console logger * Use filepath.ToSlash to protect against Windows in tests * Remove prefixed underscores from names in colors.go * Remove not implemented database logger This was removed from Gogs on 4 Mar 2016 but left in the configuration since then. * Ensure that log paths are relative to ROOT_PATH * use path.Join * rename jsonConfig to logConfig * Rename "config" to "jsonConfig" to make it clearer * Requested changes * Requested changes: XormLogger * Try to color the windows terminal If successful default to colorizing the console logs * fixup * Colorize initially too * update vendor * Colorize logs on default and remove if this is not a colorizing logger * Fix documentation * fix test * Use go-isatty to detect if on windows we are on msys or cygwin * Fix spelling mistake * Add missing vendors * More changes * Rationalise the ANSI writer protection * Adjust colors on advice from @0x5c * Make Flags a comma separated list * Move to use the windows constant for ENABLE_VIRTUAL_TERMINAL_PROCESSING * Ensure matching is done on the non-colored message - to simpify EXPRESSION
5 years ago
Repository avatars (#6986) * Repository avatars - first variant of code from old work for gogs - add migration 87 - add new option in app.ini - add en-US locale string - add new class in repository.less * Add changed index.css, remove unused template name * Update en-us doc about configuration options * Add comments to new functions, add new option to docker app.ini * Add comment for lint * Remove variable, not needed * Fix formatting * Update swagger api template * Check if avatar exists * Fix avatar link/path checks * Typo * TEXT column can't have a default value * Fixes: - remove old avatar file on upload - use ID in name of avatar file - users may upload same files - add simple tests * Fix fmt check * Generate PNG instead of "static" GIF * More informative comment * Fix error message * Update avatar upload checks: - add file size check - add new option - update config docs - add new string to en-us locale * Fixes: - use FileHEader field for check file size - add new test - upload big image * Fix formatting * Update comments * Update log message * Removed wrong style - not needed * Use Sync2 to migrate * Update repos list view - bigger avatar - fix html blocks alignment * A little adjust avatar size * Use small icons for explore/repo list * Use new cool avatar preparation func by @lafriks * Missing changes for new function * Remove unused import, move imports * Missed new option definition in app.ini Add file size check in user/profile avatar upload * Use smaller field length for Avatar * Use session to update repo DB data, update DeleteAvatar - use session too * Fix err variable definition * As suggested @lafriks - return as soon as possible, code readability
5 years ago
Feature: Timetracking (#2211) * Added comment's hashtag to url for mail notifications. * Added explanation to return statement + documentation. * Replacing in-line link generation with HTMLURL. (+gofmt) * Replaced action-based model with nil-based model. (+gofmt) * Replaced mailIssueActionToParticipants with mailIssueCommentToParticipants. * Updating comment for mailIssueCommentToParticipants * Added link to comment in "Dashboard" * Deleting feed entry if a comment is going to be deleted * Added migration * Added improved migration to add a CommentID column to action. * Added improved links to comments in feed entries. * Fixes #1956 by filtering for deleted comments that are referenced in actions. * Introducing "IsDeleted" column to action. * Adding design draft (not functional) * Adding database models for stopwatches and trackedtimes * See go-gitea/gitea#967 * Adding design draft (not functional) * Adding translations and improving design * Implementing stopwatch (for timetracking) * Make UI functional * Add hints in timeline for time tracking events * Implementing timetracking feature * Adding "Add time manual" option * Improved stopwatch * Created report of total spent time by user * Only showing total time spent if theire is something to show. * Adding license headers. * Improved error handling for "Add Time Manual" * Adding @sapks 's changes, refactoring * Adding API for feature tracking * Adding unit test * Adding DISABLE/ENABLE option to Repository settings page * Improving translations * Applying @sapk 's changes * Removing repo_unit and using IssuesSetting for disabling/enabling timetracker * Adding DEFAULT_ENABLE_TIMETRACKER to config, installation and admin menu * Improving documentation * Fixing vendor/ folder * Changing timtracking routes by adding subgroups /times and /times/stopwatch (Proposed by @lafriks ) * Restricting write access to timetracking based on the repo settings (Proposed by @lafriks ) * Fixed minor permissions bug. * Adding CanUseTimetracker and IsTimetrackerEnabled in ctx.Repo * Allow assignees and authors to track there time too. * Fixed some build-time-errors + logical errors. * Removing unused Get...ByID functions * Moving IsTimetrackerEnabled from context.Repository to models.Repository * Adding a seperate file for issue related repo functions * Adding license headers * Fixed GetUserByParams return 404 * Moving /users/:username/times to /repos/:username/:reponame/times/:username for security reasons * Adding /repos/:username/times to get all tracked times of the repo * Updating sdk-dependency * Updating swagger.v1.json * Adding warning if user has already a running stopwatch (auto-timetracker) * Replacing GetTrackedTimesBy... with GetTrackedTimes(options FindTrackedTimesOptions) * Changing code.gitea.io/sdk back to code.gitea.io/sdk * Correcting spelling mistake * Updating vendor.json * Changing GET stopwatch/toggle to POST stopwatch/toggle * Changing GET stopwatch/cancel to POST stopwatch/cancel * Added migration for stopwatches/timetracking * Fixed some access bugs for read-only users * Added default allow only contributors to track time value to config * Fixed migration by chaging x.Iterate to x.Find * Resorted imports * Moved Add Time Manually form to repo_form.go * Removed "Seconds" field from Add Time Manually * Resorted imports * Improved permission checking * Fixed some bugs * Added integration test * gofmt * Adding integration test by @lafriks * Added created_unix to comment fixtures * Using last event instead of a fixed event * Adding another integration test by @lafriks * Fixing bug Timetracker enabled causing error 500 at sidebar.tpl * Fixed a refactoring bug that resulted in hiding "HasUserStopwatch" warning. * Returning TrackedTime instead of AddTimeOption at AddTime. * Updating SDK from go-gitea/go-sdk#69 * Resetting Go-SDK back to default repository * Fixing test-vendor by changing ini back to original repository * Adding "tags" to swagger spec * govendor sync * Removed duplicate * Formatting templates * Adding IsTimetrackingEnabled checks to API * Improving translations / english texts * Improving documentation * Updating swagger spec * Fixing integration test caused be translation-changes * Removed encoding issues in local_en-US.ini. * "Added" copyright line * Moved unit.IssuesConfig().EnableTimetracker into a != nil check * Removed some other encoding issues in local_en-US.ini * Improved javascript by checking if data-context exists * Replaced manual comment creation with CreateComment * Removed unnecessary code * Improved error checking * Small cosmetic changes * Replaced int>string>duration parsing with int>duration parsing * Fixed encoding issues * Removed unused imports Signed-off-by: Jonas Franz <info@jonasfranz.software>
7 years ago
Compare branches, commits and tags with each other (#6991) * Supports tags when comparing commits or branches Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Hide headline when only comparing and don't load unused data Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Merges compare logics to allow comparing branches, commits and tags with eachother Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Display branch or tag instead of commit when used for comparing Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Show pull request form after click on button Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Transfers relevant pull.go changes from master to compare.go Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Fixes error when comparing forks against a commit or tag Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Removes console.log from JavaScript file Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Show icon next to commit reference when comparing branch or tag Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Updates css file Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Fixes import order * Renames template variable * Update routers/repo/compare.go Co-Authored-By: zeripath <art27@cantab.net> * Update from master Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Allow short-shas in compare * Renames prInfo to compareInfo Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Check PR permissions only if compare is pull request Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Adjusts comment Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Use compareInfo instead of prInfo
5 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
6 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
6 years ago
Pull request review/approval and comment on code (#3748) * Initial ui components for pull request review * Add Review Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software> * Replace ReviewComment with Content Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add load functions Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add create review comment implementation Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Simplified create and find functions for review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved "Pending" to first position Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add GetCurrentReview to simplify fetching current review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Preview for listing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Move new comment form to its own file Signed-off-by: Jonas Franz <info@jonasfranz.software> * Implement Review form Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for single comments Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add pending tag to pending review comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add unit tests for Review Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fetch all review ids at once Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improved comment rendering in "Files" view by adding Comments to DiffLine Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for invalidating comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Switched back to code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Moved review migration from v64 to v65 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Rebuild css Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Improve translations Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit tests by updating fixtures and updating outdated test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Comments will be shown at the right place now Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for deleting CodeComments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems caused by files in subdirectories Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for showing code comments of reviews in conversation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for "Show/Hide outdated" Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update code.gitea.io/git Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add support for new webhooks Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update comparison Signed-off-by: Jonas Franz <info@jonasfranz.software> * Resolve conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Minor UI improvements * update code.gitea.io/git * Fix ui bug reported by @lunny causing wrong position of add button Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Prepare solving conflicts Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show add button only if no comments already exist for the line Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add missing vendor files Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if reviewer is nil Signed-off-by: Jonas Franz <info@jonasfranz.software> * Show forms only to users who are logged in Signed-off-by: Jonas Franz <info@jonasfranz.software> * Revert "Show forms only to users who are logged in" This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Save patch in comment Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add link to comment in code Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add reply form to comment list Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add 'Reply' as translatable Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix problems introduced by checking for singed in user Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add v70 Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update generated stylesheet Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix preview Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add new algo to generate diff for line range Remove old algo used for cutting big diffs (it was very buggy) * Add documentation and example for CutDiffAroundLine * Fix example of CutDiffAroundLine * Fix some comment UI rendering bugs * Add code comment edit mode * Send notifications / actions to users until review gets published Fix diff generation bug Fix wrong hashtag * Fix vet errors * Send notifications also for single comments * Fix some notification bugs, fix link * Fix: add comment icon is only shown on code lines * Add lint comment * Add unit tests for git diff * Add more error messages * Regenerated css Signed-off-by: Jonas Franz <info@jonasfranz.software> * fmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Regenerated CSS with latest less version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by updating comment type to new ID Signed-off-by: Jonas Franz <info@jonasfranz.software> * Introducing CodeComments as type for map[string]map[int64][]*Comment Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix data-tab issues Signed-off-by: Jonas Franz <info@jonasfranz.software> * Remove unnecessary change Signed-off-by: Jonas Franz <info@jonasfranz.software> * refactored checkForInvalidation Signed-off-by: Jonas Franz <info@jonasfranz.software> * Append comments instead of setting Signed-off-by: Jonas Franz <info@jonasfranz.software> * Use HeadRepo instead of BaseRepo Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update migration Signed-off-by: Jonas Franz <info@jonasfranz.de> * Regenerated CSS Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add copyright Signed-off-by: Jonas Franz <info@jonasfranz.software> * Update index.css Signed-off-by: Jonas Franz <info@jonasfranz.software>
6 years ago
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package routes
  5. import (
  6. "bytes"
  7. "encoding/gob"
  8. "net/http"
  9. "os"
  10. "path"
  11. "text/template"
  12. "time"
  13. "code.gitea.io/gitea/models"
  14. "code.gitea.io/gitea/modules/auth"
  15. "code.gitea.io/gitea/modules/context"
  16. "code.gitea.io/gitea/modules/gzip"
  17. "code.gitea.io/gitea/modules/lfs"
  18. "code.gitea.io/gitea/modules/log"
  19. "code.gitea.io/gitea/modules/metrics"
  20. "code.gitea.io/gitea/modules/options"
  21. "code.gitea.io/gitea/modules/public"
  22. "code.gitea.io/gitea/modules/setting"
  23. "code.gitea.io/gitea/modules/templates"
  24. "code.gitea.io/gitea/modules/validation"
  25. "code.gitea.io/gitea/routers"
  26. "code.gitea.io/gitea/routers/admin"
  27. apiv1 "code.gitea.io/gitea/routers/api/v1"
  28. "code.gitea.io/gitea/routers/dev"
  29. "code.gitea.io/gitea/routers/org"
  30. "code.gitea.io/gitea/routers/private"
  31. "code.gitea.io/gitea/routers/repo"
  32. "code.gitea.io/gitea/routers/user"
  33. userSetting "code.gitea.io/gitea/routers/user/setting"
  34. "code.gitea.io/gitea/services/mailer"
  35. // to registers all internal adapters
  36. _ "code.gitea.io/gitea/modules/session"
  37. "gitea.com/macaron/binding"
  38. "gitea.com/macaron/cache"
  39. "gitea.com/macaron/captcha"
  40. "gitea.com/macaron/cors"
  41. "gitea.com/macaron/csrf"
  42. "gitea.com/macaron/i18n"
  43. "gitea.com/macaron/macaron"
  44. "gitea.com/macaron/session"
  45. "gitea.com/macaron/toolbox"
  46. "github.com/prometheus/client_golang/prometheus"
  47. "github.com/tstranex/u2f"
  48. )
  49. type routerLoggerOptions struct {
  50. Ctx *macaron.Context
  51. Identity *string
  52. Start *time.Time
  53. ResponseWriter *macaron.ResponseWriter
  54. }
  55. func setupAccessLogger(m *macaron.Macaron) {
  56. logger := log.GetLogger("access")
  57. logTemplate, _ := template.New("log").Parse(setting.AccessLogTemplate)
  58. m.Use(func(ctx *macaron.Context) {
  59. start := time.Now()
  60. ctx.Next()
  61. identity := "-"
  62. if val, ok := ctx.Data["SignedUserName"]; ok {
  63. if stringVal, ok := val.(string); ok && stringVal != "" {
  64. identity = stringVal
  65. }
  66. }
  67. rw := ctx.Resp.(macaron.ResponseWriter)
  68. buf := bytes.NewBuffer([]byte{})
  69. err := logTemplate.Execute(buf, routerLoggerOptions{
  70. Ctx: ctx,
  71. Identity: &identity,
  72. Start: &start,
  73. ResponseWriter: &rw,
  74. })
  75. if err != nil {
  76. log.Error("Could not set up macaron access logger: %v", err.Error())
  77. }
  78. err = logger.SendLog(log.INFO, "", "", 0, buf.String(), "")
  79. if err != nil {
  80. log.Error("Could not set up macaron access logger: %v", err.Error())
  81. }
  82. })
  83. }
  84. // RouterHandler is a macaron handler that will log the routing to the default gitea log
  85. func RouterHandler(level log.Level) func(ctx *macaron.Context) {
  86. return func(ctx *macaron.Context) {
  87. start := time.Now()
  88. _ = log.GetLogger("router").Log(0, level, "Started %s %s for %s", log.ColoredMethod(ctx.Req.Method), ctx.Req.RequestURI, ctx.RemoteAddr())
  89. rw := ctx.Resp.(macaron.ResponseWriter)
  90. ctx.Next()
  91. status := rw.Status()
  92. _ = log.GetLogger("router").Log(0, level, "Completed %s %s %v %s in %v", log.ColoredMethod(ctx.Req.Method), ctx.Req.RequestURI, log.ColoredStatus(status), log.ColoredStatus(status, http.StatusText(rw.Status())), log.ColoredTime(time.Since(start)))
  93. }
  94. }
  95. // NewMacaron initializes Macaron instance.
  96. func NewMacaron() *macaron.Macaron {
  97. gob.Register(&u2f.Challenge{})
  98. var m *macaron.Macaron
  99. if setting.RedirectMacaronLog {
  100. loggerAsWriter := log.NewLoggerAsWriter("INFO", log.GetLogger("macaron"))
  101. m = macaron.NewWithLogger(loggerAsWriter)
  102. if !setting.DisableRouterLog && setting.RouterLogLevel != log.NONE {
  103. if log.GetLogger("router").GetLevel() <= setting.RouterLogLevel {
  104. m.Use(RouterHandler(setting.RouterLogLevel))
  105. }
  106. }
  107. } else {
  108. m = macaron.New()
  109. if !setting.DisableRouterLog {
  110. m.Use(macaron.Logger())
  111. }
  112. }
  113. // Access Logger is similar to Router Log but more configurable and by default is more like the NCSA Common Log format
  114. if setting.EnableAccessLog {
  115. setupAccessLogger(m)
  116. }
  117. m.Use(macaron.Recovery())
  118. if setting.EnableGzip {
  119. m.Use(gzip.Middleware())
  120. }
  121. if setting.Protocol == setting.FCGI {
  122. m.SetURLPrefix(setting.AppSubURL)
  123. }
  124. m.Use(public.Custom(
  125. &public.Options{
  126. SkipLogging: setting.DisableRouterLog,
  127. ExpiresAfter: setting.StaticCacheTime,
  128. },
  129. ))
  130. m.Use(public.Static(
  131. &public.Options{
  132. Directory: path.Join(setting.StaticRootPath, "public"),
  133. SkipLogging: setting.DisableRouterLog,
  134. ExpiresAfter: setting.StaticCacheTime,
  135. },
  136. ))
  137. m.Use(public.StaticHandler(
  138. setting.AvatarUploadPath,
  139. &public.Options{
  140. Prefix: "avatars",
  141. SkipLogging: setting.DisableRouterLog,
  142. ExpiresAfter: setting.StaticCacheTime,
  143. },
  144. ))
  145. m.Use(public.StaticHandler(
  146. setting.RepositoryAvatarUploadPath,
  147. &public.Options{
  148. Prefix: "repo-avatars",
  149. SkipLogging: setting.DisableRouterLog,
  150. ExpiresAfter: setting.StaticCacheTime,
  151. },
  152. ))
  153. m.Use(templates.HTMLRenderer())
  154. mailer.InitMailRender(templates.Mailer())
  155. localeNames, err := options.Dir("locale")
  156. if err != nil {
  157. log.Fatal("Failed to list locale files: %v", err)
  158. }
  159. localFiles := make(map[string][]byte)
  160. for _, name := range localeNames {
  161. localFiles[name], err = options.Locale(name)
  162. if err != nil {
  163. log.Fatal("Failed to load %s locale file. %v", name, err)
  164. }
  165. }
  166. m.Use(i18n.I18n(i18n.Options{
  167. SubURL: setting.AppSubURL,
  168. Files: localFiles,
  169. Langs: setting.Langs,
  170. Names: setting.Names,
  171. DefaultLang: "en-US",
  172. Redirect: false,
  173. CookieDomain: setting.SessionConfig.Domain,
  174. }))
  175. m.Use(cache.Cacher(cache.Options{
  176. Adapter: setting.CacheService.Adapter,
  177. AdapterConfig: setting.CacheService.Conn,
  178. Interval: setting.CacheService.Interval,
  179. }))
  180. m.Use(captcha.Captchaer(captcha.Options{
  181. SubURL: setting.AppSubURL,
  182. }))
  183. m.Use(session.Sessioner(setting.SessionConfig))
  184. m.Use(csrf.Csrfer(csrf.Options{
  185. Secret: setting.SecretKey,
  186. Cookie: setting.CSRFCookieName,
  187. SetCookie: true,
  188. Secure: setting.SessionConfig.Secure,
  189. CookieHttpOnly: setting.CSRFCookieHTTPOnly,
  190. Header: "X-Csrf-Token",
  191. CookieDomain: setting.SessionConfig.Domain,
  192. CookiePath: setting.AppSubURL,
  193. }))
  194. m.Use(toolbox.Toolboxer(m, toolbox.Options{
  195. HealthCheckFuncs: []*toolbox.HealthCheckFuncDesc{
  196. {
  197. Desc: "Database connection",
  198. Func: models.Ping,
  199. },
  200. },
  201. DisableDebug: !setting.EnablePprof,
  202. }))
  203. m.Use(context.Contexter())
  204. // OK we are now set-up enough to allow us to create a nicer recovery than
  205. // the default macaron recovery
  206. m.Use(context.Recovery())
  207. m.SetAutoHead(true)
  208. return m
  209. }
  210. // RegisterRoutes routes routes to Macaron
  211. func RegisterRoutes(m *macaron.Macaron) {
  212. reqSignIn := context.Toggle(&context.ToggleOptions{SignInRequired: true})
  213. ignSignIn := context.Toggle(&context.ToggleOptions{SignInRequired: setting.Service.RequireSignInView})
  214. ignSignInAndCsrf := context.Toggle(&context.ToggleOptions{DisableCSRF: true})
  215. reqSignOut := context.Toggle(&context.ToggleOptions{SignOutRequired: true})
  216. bindIgnErr := binding.BindIgnErr
  217. validation.AddBindingRules()
  218. openIDSignInEnabled := func(ctx *context.Context) {
  219. if !setting.Service.EnableOpenIDSignIn {
  220. ctx.Error(403)
  221. return
  222. }
  223. }
  224. openIDSignUpEnabled := func(ctx *context.Context) {
  225. if !setting.Service.EnableOpenIDSignUp {
  226. ctx.Error(403)
  227. return
  228. }
  229. }
  230. m.Use(user.GetNotificationCount)
  231. // FIXME: not all routes need go through same middlewares.
  232. // Especially some AJAX requests, we can reduce middleware number to improve performance.
  233. // Routers.
  234. // for health check
  235. m.Head("/", func() string {
  236. return ""
  237. })
  238. m.Get("/", routers.Home)
  239. m.Group("/explore", func() {
  240. m.Get("", func(ctx *context.Context) {
  241. ctx.Redirect(setting.AppSubURL + "/explore/repos")
  242. })
  243. m.Get("/repos", routers.ExploreRepos)
  244. m.Get("/users", routers.ExploreUsers)
  245. m.Get("/organizations", routers.ExploreOrganizations)
  246. m.Get("/code", routers.ExploreCode)
  247. }, ignSignIn)
  248. m.Combo("/install", routers.InstallInit).Get(routers.Install).
  249. Post(bindIgnErr(auth.InstallForm{}), routers.InstallPost)
  250. m.Get("/^:type(issues|pulls)$", reqSignIn, user.Issues)
  251. // ***** START: User *****
  252. m.Group("/user", func() {
  253. m.Get("/login", user.SignIn)
  254. m.Post("/login", bindIgnErr(auth.SignInForm{}), user.SignInPost)
  255. m.Group("", func() {
  256. m.Combo("/login/openid").
  257. Get(user.SignInOpenID).
  258. Post(bindIgnErr(auth.SignInOpenIDForm{}), user.SignInOpenIDPost)
  259. }, openIDSignInEnabled)
  260. m.Group("/openid", func() {
  261. m.Combo("/connect").
  262. Get(user.ConnectOpenID).
  263. Post(bindIgnErr(auth.ConnectOpenIDForm{}), user.ConnectOpenIDPost)
  264. m.Group("/register", func() {
  265. m.Combo("").
  266. Get(user.RegisterOpenID, openIDSignUpEnabled).
  267. Post(bindIgnErr(auth.SignUpOpenIDForm{}), user.RegisterOpenIDPost)
  268. }, openIDSignUpEnabled)
  269. }, openIDSignInEnabled)
  270. m.Get("/sign_up", user.SignUp)
  271. m.Post("/sign_up", bindIgnErr(auth.RegisterForm{}), user.SignUpPost)
  272. m.Group("/oauth2", func() {
  273. m.Get("/:provider", user.SignInOAuth)
  274. m.Get("/:provider/callback", user.SignInOAuthCallback)
  275. })
  276. m.Get("/link_account", user.LinkAccount)
  277. m.Post("/link_account_signin", bindIgnErr(auth.SignInForm{}), user.LinkAccountPostSignIn)
  278. m.Post("/link_account_signup", bindIgnErr(auth.RegisterForm{}), user.LinkAccountPostRegister)
  279. m.Group("/two_factor", func() {
  280. m.Get("", user.TwoFactor)
  281. m.Post("", bindIgnErr(auth.TwoFactorAuthForm{}), user.TwoFactorPost)
  282. m.Get("/scratch", user.TwoFactorScratch)
  283. m.Post("/scratch", bindIgnErr(auth.TwoFactorScratchAuthForm{}), user.TwoFactorScratchPost)
  284. })
  285. m.Group("/u2f", func() {
  286. m.Get("", user.U2F)
  287. m.Get("/challenge", user.U2FChallenge)
  288. m.Post("/sign", bindIgnErr(u2f.SignResponse{}), user.U2FSign)
  289. })
  290. }, reqSignOut)
  291. m.Group("/login/oauth", func() {
  292. m.Get("/authorize", bindIgnErr(auth.AuthorizationForm{}), user.AuthorizeOAuth)
  293. m.Post("/grant", bindIgnErr(auth.GrantApplicationForm{}), user.GrantApplicationOAuth)
  294. // TODO manage redirection
  295. m.Post("/authorize", bindIgnErr(auth.AuthorizationForm{}), user.AuthorizeOAuth)
  296. }, ignSignInAndCsrf, reqSignIn)
  297. m.Post("/login/oauth/access_token", bindIgnErr(auth.AccessTokenForm{}), ignSignInAndCsrf, user.AccessTokenOAuth)
  298. m.Group("/user/settings", func() {
  299. m.Get("", userSetting.Profile)
  300. m.Post("", bindIgnErr(auth.UpdateProfileForm{}), userSetting.ProfilePost)
  301. m.Get("/change_password", user.MustChangePassword)
  302. m.Post("/change_password", bindIgnErr(auth.MustChangePasswordForm{}), user.MustChangePasswordPost)
  303. m.Post("/avatar", binding.MultipartForm(auth.AvatarForm{}), userSetting.AvatarPost)
  304. m.Post("/avatar/delete", userSetting.DeleteAvatar)
  305. m.Group("/account", func() {
  306. m.Combo("").Get(userSetting.Account).Post(bindIgnErr(auth.ChangePasswordForm{}), userSetting.AccountPost)
  307. m.Post("/email", bindIgnErr(auth.AddEmailForm{}), userSetting.EmailPost)
  308. m.Post("/email/delete", userSetting.DeleteEmail)
  309. m.Post("/delete", userSetting.DeleteAccount)
  310. m.Post("/theme", bindIgnErr(auth.UpdateThemeForm{}), userSetting.UpdateUIThemePost)
  311. })
  312. m.Group("/security", func() {
  313. m.Get("", userSetting.Security)
  314. m.Group("/two_factor", func() {
  315. m.Post("/regenerate_scratch", userSetting.RegenerateScratchTwoFactor)
  316. m.Post("/disable", userSetting.DisableTwoFactor)
  317. m.Get("/enroll", userSetting.EnrollTwoFactor)
  318. m.Post("/enroll", bindIgnErr(auth.TwoFactorAuthForm{}), userSetting.EnrollTwoFactorPost)
  319. })
  320. m.Group("/u2f", func() {
  321. m.Post("/request_register", bindIgnErr(auth.U2FRegistrationForm{}), userSetting.U2FRegister)
  322. m.Post("/register", bindIgnErr(u2f.RegisterResponse{}), userSetting.U2FRegisterPost)
  323. m.Post("/delete", bindIgnErr(auth.U2FDeleteForm{}), userSetting.U2FDelete)
  324. })
  325. m.Group("/openid", func() {
  326. m.Post("", bindIgnErr(auth.AddOpenIDForm{}), userSetting.OpenIDPost)
  327. m.Post("/delete", userSetting.DeleteOpenID)
  328. m.Post("/toggle_visibility", userSetting.ToggleOpenIDVisibility)
  329. }, openIDSignInEnabled)
  330. m.Post("/account_link", userSetting.DeleteAccountLink)
  331. })
  332. m.Group("/applications/oauth2", func() {
  333. m.Get("/:id", userSetting.OAuth2ApplicationShow)
  334. m.Post("/:id", bindIgnErr(auth.EditOAuth2ApplicationForm{}), userSetting.OAuthApplicationsEdit)
  335. m.Post("/:id/regenerate_secret", userSetting.OAuthApplicationsRegenerateSecret)
  336. m.Post("", bindIgnErr(auth.EditOAuth2ApplicationForm{}), userSetting.OAuthApplicationsPost)
  337. m.Post("/delete", userSetting.DeleteOAuth2Application)
  338. m.Post("/revoke", userSetting.RevokeOAuth2Grant)
  339. })
  340. m.Combo("/applications").Get(userSetting.Applications).
  341. Post(bindIgnErr(auth.NewAccessTokenForm{}), userSetting.ApplicationsPost)
  342. m.Post("/applications/delete", userSetting.DeleteApplication)
  343. m.Combo("/keys").Get(userSetting.Keys).
  344. Post(bindIgnErr(auth.AddKeyForm{}), userSetting.KeysPost)
  345. m.Post("/keys/delete", userSetting.DeleteKey)
  346. m.Get("/organization", userSetting.Organization)
  347. m.Get("/repos", userSetting.Repos)
  348. // redirects from old settings urls to new ones
  349. // TODO: can be removed on next major version
  350. m.Get("/avatar", func(ctx *context.Context) {
  351. ctx.Redirect(setting.AppSubURL+"/user/settings", http.StatusMovedPermanently)
  352. })
  353. m.Get("/email", func(ctx *context.Context) {
  354. ctx.Redirect(setting.AppSubURL+"/user/settings/account", http.StatusMovedPermanently)
  355. })
  356. m.Get("/delete", func(ctx *context.Context) {
  357. ctx.Redirect(setting.AppSubURL+"/user/settings/account", http.StatusMovedPermanently)
  358. })
  359. m.Get("/openid", func(ctx *context.Context) {
  360. ctx.Redirect(setting.AppSubURL+"/user/settings/security", http.StatusMovedPermanently)
  361. })
  362. m.Get("/account_link", func(ctx *context.Context) {
  363. ctx.Redirect(setting.AppSubURL+"/user/settings/security", http.StatusMovedPermanently)
  364. })
  365. }, reqSignIn, func(ctx *context.Context) {
  366. ctx.Data["PageIsUserSettings"] = true
  367. ctx.Data["AllThemes"] = setting.UI.Themes
  368. })
  369. m.Group("/user", func() {
  370. // r.Get("/feeds", binding.Bind(auth.FeedsForm{}), user.Feeds)
  371. m.Any("/activate", user.Activate, reqSignIn)
  372. m.Any("/activate_email", user.ActivateEmail)
  373. m.Get("/avatar/:username/:size", user.Avatar)
  374. m.Get("/email2user", user.Email2User)
  375. m.Get("/recover_account", user.ResetPasswd)
  376. m.Post("/recover_account", user.ResetPasswdPost)
  377. m.Get("/forgot_password", user.ForgotPasswd)
  378. m.Post("/forgot_password", user.ForgotPasswdPost)
  379. m.Get("/logout", user.SignOut)
  380. })
  381. // ***** END: User *****
  382. adminReq := context.Toggle(&context.ToggleOptions{SignInRequired: true, AdminRequired: true})
  383. // ***** START: Admin *****
  384. m.Group("/admin", func() {
  385. m.Get("", adminReq, admin.Dashboard)
  386. m.Get("/config", admin.Config)
  387. m.Post("/config/test_mail", admin.SendTestMail)
  388. m.Get("/monitor", admin.Monitor)
  389. m.Group("/users", func() {
  390. m.Get("", admin.Users)
  391. m.Combo("/new").Get(admin.NewUser).Post(bindIgnErr(auth.AdminCreateUserForm{}), admin.NewUserPost)
  392. m.Combo("/:userid").Get(admin.EditUser).Post(bindIgnErr(auth.AdminEditUserForm{}), admin.EditUserPost)
  393. m.Post("/:userid/delete", admin.DeleteUser)
  394. })
  395. m.Group("/orgs", func() {
  396. m.Get("", admin.Organizations)
  397. })
  398. m.Group("/repos", func() {
  399. m.Get("", admin.Repos)
  400. m.Post("/delete", admin.DeleteRepo)
  401. })
  402. m.Group("/hooks", func() {
  403. m.Get("", admin.DefaultWebhooks)
  404. m.Post("/delete", admin.DeleteDefaultWebhook)
  405. m.Get("/:type/new", repo.WebhooksNew)
  406. m.Post("/gitea/new", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksNewPost)
  407. m.Post("/gogs/new", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksNewPost)
  408. m.Post("/slack/new", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksNewPost)
  409. m.Post("/discord/new", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksNewPost)
  410. m.Post("/dingtalk/new", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksNewPost)
  411. m.Post("/telegram/new", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksNewPost)
  412. m.Post("/msteams/new", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksNewPost)
  413. m.Get("/:id", repo.WebHooksEdit)
  414. m.Post("/gitea/:id", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksEditPost)
  415. m.Post("/gogs/:id", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksEditPost)
  416. m.Post("/slack/:id", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksEditPost)
  417. m.Post("/discord/:id", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksEditPost)
  418. m.Post("/dingtalk/:id", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksEditPost)
  419. m.Post("/telegram/:id", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksEditPost)
  420. m.Post("/msteams/:id", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksNewPost)
  421. })
  422. m.Group("/auths", func() {
  423. m.Get("", admin.Authentications)
  424. m.Combo("/new").Get(admin.NewAuthSource).Post(bindIgnErr(auth.AuthenticationForm{}), admin.NewAuthSourcePost)
  425. m.Combo("/:authid").Get(admin.EditAuthSource).
  426. Post(bindIgnErr(auth.AuthenticationForm{}), admin.EditAuthSourcePost)
  427. m.Post("/:authid/delete", admin.DeleteAuthSource)
  428. })
  429. m.Group("/notices", func() {
  430. m.Get("", admin.Notices)
  431. m.Post("/delete", admin.DeleteNotices)
  432. m.Get("/empty", admin.EmptyNotices)
  433. })
  434. }, adminReq)
  435. // ***** END: Admin *****
  436. m.Group("", func() {
  437. m.Group("/:username", func() {
  438. m.Get("", user.Profile)
  439. m.Get("/followers", user.Followers)
  440. m.Get("/following", user.Following)
  441. })
  442. m.Get("/attachments/:uuid", func(ctx *context.Context) {
  443. attach, err := models.GetAttachmentByUUID(ctx.Params(":uuid"))
  444. if err != nil {
  445. if models.IsErrAttachmentNotExist(err) {
  446. ctx.Error(404)
  447. } else {
  448. ctx.ServerError("GetAttachmentByUUID", err)
  449. }
  450. return
  451. }
  452. fr, err := os.Open(attach.LocalPath())
  453. if err != nil {
  454. ctx.ServerError("Open", err)
  455. return
  456. }
  457. defer fr.Close()
  458. if err := attach.IncreaseDownloadCount(); err != nil {
  459. ctx.ServerError("Update", err)
  460. return
  461. }
  462. if err = repo.ServeData(ctx, attach.Name, fr); err != nil {
  463. ctx.ServerError("ServeData", err)
  464. return
  465. }
  466. })
  467. }, ignSignIn)
  468. m.Group("/attachments", func() {
  469. m.Post("", repo.UploadAttachment)
  470. m.Post("/delete", repo.DeleteAttachment)
  471. }, reqSignIn)
  472. m.Group("/:username", func() {
  473. m.Get("/action/:action", user.Action)
  474. }, reqSignIn)
  475. if macaron.Env == macaron.DEV {
  476. m.Get("/template/*", dev.TemplatePreview)
  477. }
  478. reqRepoAdmin := context.RequireRepoAdmin()
  479. reqRepoCodeWriter := context.RequireRepoWriter(models.UnitTypeCode)
  480. reqRepoCodeReader := context.RequireRepoReader(models.UnitTypeCode)
  481. reqRepoReleaseWriter := context.RequireRepoWriter(models.UnitTypeReleases)
  482. reqRepoReleaseReader := context.RequireRepoReader(models.UnitTypeReleases)
  483. reqRepoWikiWriter := context.RequireRepoWriter(models.UnitTypeWiki)
  484. reqRepoIssueReader := context.RequireRepoReader(models.UnitTypeIssues)
  485. reqRepoPullsWriter := context.RequireRepoWriter(models.UnitTypePullRequests)
  486. reqRepoPullsReader := context.RequireRepoReader(models.UnitTypePullRequests)
  487. reqRepoIssuesOrPullsWriter := context.RequireRepoWriterOr(models.UnitTypeIssues, models.UnitTypePullRequests)
  488. reqRepoIssuesOrPullsReader := context.RequireRepoReaderOr(models.UnitTypeIssues, models.UnitTypePullRequests)
  489. reqRepoIssueWriter := func(ctx *context.Context) {
  490. if !ctx.Repo.CanWrite(models.UnitTypeIssues) {
  491. ctx.Error(403)
  492. return
  493. }
  494. }
  495. // ***** START: Organization *****
  496. m.Group("/org", func() {
  497. m.Group("", func() {
  498. m.Get("/create", org.Create)
  499. m.Post("/create", bindIgnErr(auth.CreateOrgForm{}), org.CreatePost)
  500. })
  501. m.Group("/:org", func() {
  502. m.Get("/dashboard", user.Dashboard)
  503. m.Get("/^:type(issues|pulls)$", user.Issues)
  504. m.Get("/members", org.Members)
  505. m.Get("/members/action/:action", org.MembersAction)
  506. m.Get("/teams", org.Teams)
  507. }, context.OrgAssignment(true))
  508. m.Group("/:org", func() {
  509. m.Get("/teams/:team", org.TeamMembers)
  510. m.Get("/teams/:team/repositories", org.TeamRepositories)
  511. m.Route("/teams/:team/action/:action", "GET,POST", org.TeamsAction)
  512. m.Route("/teams/:team/action/repo/:action", "GET,POST", org.TeamsRepoAction)
  513. }, context.OrgAssignment(true, false, true))
  514. m.Group("/:org", func() {
  515. m.Get("/teams/new", org.NewTeam)
  516. m.Post("/teams/new", bindIgnErr(auth.CreateTeamForm{}), org.NewTeamPost)
  517. m.Get("/teams/:team/edit", org.EditTeam)
  518. m.Post("/teams/:team/edit", bindIgnErr(auth.CreateTeamForm{}), org.EditTeamPost)
  519. m.Post("/teams/:team/delete", org.DeleteTeam)
  520. m.Group("/settings", func() {
  521. m.Combo("").Get(org.Settings).
  522. Post(bindIgnErr(auth.UpdateOrgSettingForm{}), org.SettingsPost)
  523. m.Post("/avatar", binding.MultipartForm(auth.AvatarForm{}), org.SettingsAvatar)
  524. m.Post("/avatar/delete", org.SettingsDeleteAvatar)
  525. m.Group("/hooks", func() {
  526. m.Get("", org.Webhooks)
  527. m.Post("/delete", org.DeleteWebhook)
  528. m.Get("/:type/new", repo.WebhooksNew)
  529. m.Post("/gitea/new", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksNewPost)
  530. m.Post("/gogs/new", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksNewPost)
  531. m.Post("/slack/new", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksNewPost)
  532. m.Post("/discord/new", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksNewPost)
  533. m.Post("/dingtalk/new", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksNewPost)
  534. m.Post("/telegram/new", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksNewPost)
  535. m.Get("/:id", repo.WebHooksEdit)
  536. m.Post("/gitea/:id", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksEditPost)
  537. m.Post("/gogs/:id", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksEditPost)
  538. m.Post("/slack/:id", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksEditPost)
  539. m.Post("/discord/:id", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksEditPost)
  540. m.Post("/dingtalk/:id", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksEditPost)
  541. m.Post("/telegram/:id", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksEditPost)
  542. })
  543. m.Route("/delete", "GET,POST", org.SettingsDelete)
  544. })
  545. }, context.OrgAssignment(true, true))
  546. }, reqSignIn)
  547. // ***** END: Organization *****
  548. // ***** START: Repository *****
  549. m.Group("/repo", func() {
  550. m.Get("/create", repo.Create)
  551. m.Post("/create", bindIgnErr(auth.CreateRepoForm{}), repo.CreatePost)
  552. m.Get("/migrate", repo.Migrate)
  553. m.Post("/migrate", bindIgnErr(auth.MigrateRepoForm{}), repo.MigratePost)
  554. m.Group("/fork", func() {
  555. m.Combo("/:repoid").Get(repo.Fork).
  556. Post(bindIgnErr(auth.CreateRepoForm{}), repo.ForkPost)
  557. }, context.RepoIDAssignment(), context.UnitTypes(), reqRepoCodeReader)
  558. }, reqSignIn)
  559. // ***** Release Attachment Download without Signin
  560. m.Get("/:username/:reponame/releases/download/:vTag/:fileName", ignSignIn, context.RepoAssignment(), repo.MustBeNotEmpty, repo.RedirectDownload)
  561. m.Group("/:username/:reponame", func() {
  562. m.Group("/settings", func() {
  563. m.Combo("").Get(repo.Settings).
  564. Post(bindIgnErr(auth.RepoSettingForm{}), repo.SettingsPost)
  565. m.Post("/avatar", binding.MultipartForm(auth.AvatarForm{}), repo.SettingsAvatar)
  566. m.Post("/avatar/delete", repo.SettingsDeleteAvatar)
  567. m.Group("/collaboration", func() {
  568. m.Combo("").Get(repo.Collaboration).Post(repo.CollaborationPost)
  569. m.Post("/access_mode", repo.ChangeCollaborationAccessMode)
  570. m.Post("/delete", repo.DeleteCollaboration)
  571. m.Group("/team", func() {
  572. m.Post("", repo.AddTeamPost)
  573. m.Post("/delete", repo.DeleteTeam)
  574. })
  575. })
  576. m.Group("/branches", func() {
  577. m.Combo("").Get(repo.ProtectedBranch).Post(repo.ProtectedBranchPost)
  578. m.Combo("/*").Get(repo.SettingsProtectedBranch).
  579. Post(bindIgnErr(auth.ProtectBranchForm{}), context.RepoMustNotBeArchived(), repo.SettingsProtectedBranchPost)
  580. }, repo.MustBeNotEmpty)
  581. m.Group("/hooks", func() {
  582. m.Get("", repo.Webhooks)
  583. m.Post("/delete", repo.DeleteWebhook)
  584. m.Get("/:type/new", repo.WebhooksNew)
  585. m.Post("/gitea/new", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksNewPost)
  586. m.Post("/gogs/new", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksNewPost)
  587. m.Post("/slack/new", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksNewPost)
  588. m.Post("/discord/new", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksNewPost)
  589. m.Post("/dingtalk/new", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksNewPost)
  590. m.Post("/telegram/new", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksNewPost)
  591. m.Post("/msteams/new", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksNewPost)
  592. m.Get("/:id", repo.WebHooksEdit)
  593. m.Post("/:id/test", repo.TestWebhook)
  594. m.Post("/gitea/:id", bindIgnErr(auth.NewWebhookForm{}), repo.WebHooksEditPost)
  595. m.Post("/gogs/:id", bindIgnErr(auth.NewGogshookForm{}), repo.GogsHooksEditPost)
  596. m.Post("/slack/:id", bindIgnErr(auth.NewSlackHookForm{}), repo.SlackHooksEditPost)
  597. m.Post("/discord/:id", bindIgnErr(auth.NewDiscordHookForm{}), repo.DiscordHooksEditPost)
  598. m.Post("/dingtalk/:id", bindIgnErr(auth.NewDingtalkHookForm{}), repo.DingtalkHooksEditPost)
  599. m.Post("/telegram/:id", bindIgnErr(auth.NewTelegramHookForm{}), repo.TelegramHooksEditPost)
  600. m.Post("/msteams/:id", bindIgnErr(auth.NewMSTeamsHookForm{}), repo.MSTeamsHooksEditPost)
  601. m.Group("/git", func() {
  602. m.Get("", repo.GitHooks)
  603. m.Combo("/:name").Get(repo.GitHooksEdit).
  604. Post(repo.GitHooksEditPost)
  605. }, context.GitHookService())
  606. })
  607. m.Group("/keys", func() {
  608. m.Combo("").Get(repo.DeployKeys).
  609. Post(bindIgnErr(auth.AddKeyForm{}), repo.DeployKeysPost)
  610. m.Post("/delete", repo.DeleteDeployKey)
  611. })
  612. m.Group("/lfs", func() {
  613. m.Get("", repo.LFSFiles)
  614. m.Get("/show/:oid", repo.LFSFileGet)
  615. m.Post("/delete/:oid", repo.LFSDelete)
  616. m.Get("/pointers", repo.LFSPointerFiles)
  617. m.Post("/pointers/associate", repo.LFSAutoAssociate)
  618. m.Get("/find", repo.LFSFileFind)
  619. })
  620. }, func(ctx *context.Context) {
  621. ctx.Data["PageIsSettings"] = true
  622. ctx.Data["LFSStartServer"] = setting.LFS.StartServer
  623. })
  624. }, reqSignIn, context.RepoAssignment(), context.UnitTypes(), reqRepoAdmin, context.RepoRef())
  625. m.Get("/:username/:reponame/action/:action", reqSignIn, context.RepoAssignment(), context.UnitTypes(), repo.Action)
  626. m.Group("/:username/:reponame", func() {
  627. m.Group("/issues", func() {
  628. m.Combo("/new").Get(context.RepoRef(), repo.NewIssue).
  629. Post(bindIgnErr(auth.CreateIssueForm{}), repo.NewIssuePost)
  630. }, context.RepoMustNotBeArchived(), reqRepoIssueReader)
  631. // FIXME: should use different URLs but mostly same logic for comments of issue and pull reuqest.
  632. // So they can apply their own enable/disable logic on routers.
  633. m.Group("/issues", func() {
  634. m.Group("/:index", func() {
  635. m.Post("/title", repo.UpdateIssueTitle)
  636. m.Post("/content", repo.UpdateIssueContent)
  637. m.Post("/watch", repo.IssueWatch)
  638. m.Group("/dependency", func() {
  639. m.Post("/add", repo.AddDependency)
  640. m.Post("/delete", repo.RemoveDependency)
  641. })
  642. m.Combo("/comments").Post(repo.MustAllowUserComment, bindIgnErr(auth.CreateCommentForm{}), repo.NewComment)
  643. m.Group("/times", func() {
  644. m.Post("/add", bindIgnErr(auth.AddTimeManuallyForm{}), repo.AddTimeManually)
  645. m.Group("/stopwatch", func() {
  646. m.Post("/toggle", repo.IssueStopwatch)
  647. m.Post("/cancel", repo.CancelStopwatch)
  648. })
  649. })
  650. m.Post("/reactions/:action", bindIgnErr(auth.ReactionForm{}), repo.ChangeIssueReaction)
  651. m.Post("/lock", reqRepoIssueWriter, bindIgnErr(auth.IssueLockForm{}), repo.LockIssue)
  652. m.Post("/unlock", reqRepoIssueWriter, repo.UnlockIssue)
  653. m.Get("/attachments", repo.GetIssueAttachments)
  654. }, context.RepoMustNotBeArchived())
  655. m.Post("/labels", reqRepoIssuesOrPullsWriter, repo.UpdateIssueLabel)
  656. m.Post("/milestone", reqRepoIssuesOrPullsWriter, repo.UpdateIssueMilestone)
  657. m.Post("/assignee", reqRepoIssuesOrPullsWriter, repo.UpdateIssueAssignee)
  658. m.Post("/status", reqRepoIssuesOrPullsWriter, repo.UpdateIssueStatus)
  659. }, context.RepoMustNotBeArchived())
  660. m.Group("/comments/:id", func() {
  661. m.Post("", repo.UpdateCommentContent)
  662. m.Post("/delete", repo.DeleteComment)
  663. m.Post("/reactions/:action", bindIgnErr(auth.ReactionForm{}), repo.ChangeCommentReaction)
  664. m.Get("/attachments", repo.GetCommentAttachments)
  665. }, context.RepoMustNotBeArchived())
  666. m.Group("/labels", func() {
  667. m.Post("/new", bindIgnErr(auth.CreateLabelForm{}), repo.NewLabel)
  668. m.Post("/edit", bindIgnErr(auth.CreateLabelForm{}), repo.UpdateLabel)
  669. m.Post("/delete", repo.DeleteLabel)
  670. m.Post("/initialize", bindIgnErr(auth.InitializeLabelsForm{}), repo.InitializeLabels)
  671. }, context.RepoMustNotBeArchived(), reqRepoIssuesOrPullsWriter, context.RepoRef())
  672. m.Group("/milestones", func() {
  673. m.Combo("/new").Get(repo.NewMilestone).
  674. Post(bindIgnErr(auth.CreateMilestoneForm{}), repo.NewMilestonePost)
  675. m.Get("/:id/edit", repo.EditMilestone)
  676. m.Post("/:id/edit", bindIgnErr(auth.CreateMilestoneForm{}), repo.EditMilestonePost)
  677. m.Get("/:id/:action", repo.ChangeMilestonStatus)
  678. m.Post("/delete", repo.DeleteMilestone)
  679. }, context.RepoMustNotBeArchived(), reqRepoIssuesOrPullsWriter, context.RepoRef())
  680. m.Group("/milestone", func() {
  681. m.Get("/:id", repo.MilestoneIssuesAndPulls)
  682. }, reqRepoIssuesOrPullsReader, context.RepoRef())
  683. m.Combo("/compare/*", repo.MustBeNotEmpty, reqRepoCodeReader, repo.SetEditorconfigIfExists).
  684. Get(repo.SetDiffViewStyle, repo.CompareDiff).
  685. Post(context.RepoMustNotBeArchived(), reqRepoPullsReader, repo.MustAllowPulls, bindIgnErr(auth.CreateIssueForm{}), repo.CompareAndPullRequestPost)
  686. m.Group("", func() {
  687. m.Group("", func() {
  688. m.Combo("/_edit/*").Get(repo.EditFile).
  689. Post(bindIgnErr(auth.EditRepoFileForm{}), repo.EditFilePost)
  690. m.Combo("/_new/*").Get(repo.NewFile).
  691. Post(bindIgnErr(auth.EditRepoFileForm{}), repo.NewFilePost)
  692. m.Post("/_preview/*", bindIgnErr(auth.EditPreviewDiffForm{}), repo.DiffPreviewPost)
  693. m.Combo("/_delete/*").Get(repo.DeleteFile).
  694. Post(bindIgnErr(auth.DeleteRepoFileForm{}), repo.DeleteFilePost)
  695. m.Combo("/_upload/*", repo.MustBeAbleToUpload).
  696. Get(repo.UploadFile).
  697. Post(bindIgnErr(auth.UploadRepoFileForm{}), repo.UploadFilePost)
  698. }, context.RepoRefByType(context.RepoRefBranch), repo.MustBeEditable)
  699. m.Group("", func() {
  700. m.Post("/upload-file", repo.UploadFileToServer)
  701. m.Post("/upload-remove", bindIgnErr(auth.RemoveUploadFileForm{}), repo.RemoveUploadFileFromServer)
  702. }, context.RepoRef(), repo.MustBeEditable, repo.MustBeAbleToUpload)
  703. }, context.RepoMustNotBeArchived(), reqRepoCodeWriter, repo.MustBeNotEmpty)
  704. m.Group("/branches", func() {
  705. m.Group("/_new/", func() {
  706. m.Post("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.CreateBranch)
  707. m.Post("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.CreateBranch)
  708. m.Post("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.CreateBranch)
  709. }, bindIgnErr(auth.NewBranchForm{}))
  710. m.Post("/delete", repo.DeleteBranchPost)
  711. m.Post("/restore", repo.RestoreBranchPost)
  712. }, context.RepoMustNotBeArchived(), reqRepoCodeWriter, repo.MustBeNotEmpty)
  713. }, reqSignIn, context.RepoAssignment(), context.UnitTypes())
  714. // Releases
  715. m.Group("/:username/:reponame", func() {
  716. m.Group("/releases", func() {
  717. m.Get("/", repo.MustBeNotEmpty, repo.Releases)
  718. }, repo.MustBeNotEmpty, context.RepoRef())
  719. m.Group("/releases", func() {
  720. m.Get("/new", repo.NewRelease)
  721. m.Post("/new", bindIgnErr(auth.NewReleaseForm{}), repo.NewReleasePost)
  722. m.Post("/delete", repo.DeleteRelease)
  723. }, reqSignIn, repo.MustBeNotEmpty, context.RepoMustNotBeArchived(), reqRepoReleaseWriter, context.RepoRef())
  724. m.Group("/releases", func() {
  725. m.Get("/edit/*", repo.EditRelease)
  726. m.Post("/edit/*", bindIgnErr(auth.EditReleaseForm{}), repo.EditReleasePost)
  727. }, reqSignIn, repo.MustBeNotEmpty, context.RepoMustNotBeArchived(), reqRepoReleaseWriter, func(ctx *context.Context) {
  728. var err error
  729. ctx.Repo.Commit, err = ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch)
  730. if err != nil {
  731. ctx.ServerError("GetBranchCommit", err)
  732. return
  733. }
  734. ctx.Repo.CommitsCount, err = ctx.Repo.GetCommitsCount()
  735. if err != nil {
  736. ctx.ServerError("GetCommitsCount", err)
  737. return
  738. }
  739. ctx.Data["CommitsCount"] = ctx.Repo.CommitsCount
  740. })
  741. }, ignSignIn, context.RepoAssignment(), context.UnitTypes(), reqRepoReleaseReader)
  742. m.Group("/:username/:reponame", func() {
  743. m.Post("/topics", repo.TopicsPost)
  744. }, context.RepoAssignment(), context.RepoMustNotBeArchived(), reqRepoAdmin)
  745. m.Group("/:username/:reponame", func() {
  746. m.Group("", func() {
  747. m.Get("/^:type(issues|pulls)$", repo.Issues)
  748. m.Get("/^:type(issues|pulls)$/:index", repo.ViewIssue)
  749. m.Get("/labels/", reqRepoIssuesOrPullsReader, repo.RetrieveLabels, repo.Labels)
  750. m.Get("/milestones", reqRepoIssuesOrPullsReader, repo.Milestones)
  751. }, context.RepoRef())
  752. m.Group("/wiki", func() {
  753. m.Get("/?:page", repo.Wiki)
  754. m.Get("/_pages", repo.WikiPages)
  755. m.Get("/:page/_revision", repo.WikiRevision)
  756. m.Group("", func() {
  757. m.Combo("/_new").Get(repo.NewWiki).
  758. Post(bindIgnErr(auth.NewWikiForm{}), repo.NewWikiPost)
  759. m.Combo("/:page/_edit").Get(repo.EditWiki).
  760. Post(bindIgnErr(auth.NewWikiForm{}), repo.EditWikiPost)
  761. m.Post("/:page/delete", repo.DeleteWikiPagePost)
  762. }, context.RepoMustNotBeArchived(), reqSignIn, reqRepoWikiWriter)
  763. }, repo.MustEnableWiki, context.RepoRef())
  764. m.Group("/wiki", func() {
  765. m.Get("/raw/*", repo.WikiRaw)
  766. }, repo.MustEnableWiki)
  767. m.Group("/activity", func() {
  768. m.Get("", repo.Activity)
  769. m.Get("/:period", repo.Activity)
  770. }, context.RepoRef(), repo.MustBeNotEmpty, context.RequireRepoReaderOr(models.UnitTypePullRequests, models.UnitTypeIssues, models.UnitTypeReleases))
  771. m.Group("/activity_author_data", func() {
  772. m.Get("", repo.ActivityAuthors)
  773. m.Get("/:period", repo.ActivityAuthors)
  774. }, context.RepoRef(), repo.MustBeNotEmpty, context.RequireRepoReaderOr(models.UnitTypeCode))
  775. m.Get("/archive/*", repo.MustBeNotEmpty, reqRepoCodeReader, repo.Download)
  776. m.Get("/status", reqRepoCodeReader, repo.Status)
  777. m.Group("/branches", func() {
  778. m.Get("", repo.Branches)
  779. }, repo.MustBeNotEmpty, context.RepoRef(), reqRepoCodeReader)
  780. m.Group("/pulls/:index", func() {
  781. m.Get(".diff", repo.DownloadPullDiff)
  782. m.Get(".patch", repo.DownloadPullPatch)
  783. m.Get("/commits", context.RepoRef(), repo.ViewPullCommits)
  784. m.Post("/merge", context.RepoMustNotBeArchived(), reqRepoPullsWriter, bindIgnErr(auth.MergePullRequestForm{}), repo.MergePullRequest)
  785. m.Post("/cleanup", context.RepoMustNotBeArchived(), context.RepoRef(), repo.CleanUpPullRequest)
  786. m.Group("/files", func() {
  787. m.Get("", context.RepoRef(), repo.SetEditorconfigIfExists, repo.SetDiffViewStyle, repo.SetWhitespaceBehavior, repo.ViewPullFiles)
  788. m.Group("/reviews", func() {
  789. m.Post("/comments", bindIgnErr(auth.CodeCommentForm{}), repo.CreateCodeComment)
  790. m.Post("/submit", bindIgnErr(auth.SubmitReviewForm{}), repo.SubmitReview)
  791. }, context.RepoMustNotBeArchived())
  792. })
  793. }, repo.MustAllowPulls)
  794. m.Group("/media", func() {
  795. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.SingleDownloadOrLFS)
  796. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.SingleDownloadOrLFS)
  797. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.SingleDownloadOrLFS)
  798. m.Get("/blob/:sha", context.RepoRefByType(context.RepoRefBlob), repo.DownloadByIDOrLFS)
  799. // "/*" route is deprecated, and kept for backward compatibility
  800. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.SingleDownloadOrLFS)
  801. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  802. m.Group("/raw", func() {
  803. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.SingleDownload)
  804. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.SingleDownload)
  805. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.SingleDownload)
  806. m.Get("/blob/:sha", context.RepoRefByType(context.RepoRefBlob), repo.DownloadByID)
  807. // "/*" route is deprecated, and kept for backward compatibility
  808. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.SingleDownload)
  809. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  810. m.Group("/commits", func() {
  811. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.RefCommits)
  812. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.RefCommits)
  813. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.RefCommits)
  814. // "/*" route is deprecated, and kept for backward compatibility
  815. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.RefCommits)
  816. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  817. m.Group("/blame", func() {
  818. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.RefBlame)
  819. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.RefBlame)
  820. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.RefBlame)
  821. }, repo.MustBeNotEmpty, reqRepoCodeReader)
  822. m.Group("", func() {
  823. m.Get("/graph", repo.Graph)
  824. m.Get("/commit/:sha([a-f0-9]{7,40})$", repo.SetEditorconfigIfExists, repo.SetDiffViewStyle, repo.Diff)
  825. }, repo.MustBeNotEmpty, context.RepoRef(), reqRepoCodeReader)
  826. m.Group("/src", func() {
  827. m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.Home)
  828. m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.Home)
  829. m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.Home)
  830. // "/*" route is deprecated, and kept for backward compatibility
  831. m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.Home)
  832. }, repo.SetEditorconfigIfExists)
  833. m.Group("", func() {
  834. m.Get("/forks", repo.Forks)
  835. }, context.RepoRef(), reqRepoCodeReader)
  836. m.Get("/commit/:sha([a-f0-9]{7,40})\\.:ext(patch|diff)",
  837. repo.MustBeNotEmpty, reqRepoCodeReader, repo.RawDiff)
  838. }, ignSignIn, context.RepoAssignment(), context.UnitTypes())
  839. m.Group("/:username/:reponame", func() {
  840. m.Get("/stars", repo.Stars)
  841. m.Get("/watchers", repo.Watchers)
  842. m.Get("/search", reqRepoCodeReader, repo.Search)
  843. }, ignSignIn, context.RepoAssignment(), context.RepoRef(), context.UnitTypes())
  844. m.Group("/:username", func() {
  845. m.Group("/:reponame", func() {
  846. m.Get("", repo.SetEditorconfigIfExists, repo.Home)
  847. m.Get("\\.git$", repo.SetEditorconfigIfExists, repo.Home)
  848. }, ignSignIn, context.RepoAssignment(), context.RepoRef(), context.UnitTypes())
  849. m.Group("/:reponame", func() {
  850. m.Group("\\.git/info/lfs", func() {
  851. m.Post("/objects/batch", lfs.BatchHandler)
  852. m.Get("/objects/:oid/:filename", lfs.ObjectOidHandler)
  853. m.Any("/objects/:oid", lfs.ObjectOidHandler)
  854. m.Post("/objects", lfs.PostHandler)
  855. m.Post("/verify", lfs.VerifyHandler)
  856. m.Group("/locks", func() {
  857. m.Get("/", lfs.GetListLockHandler)
  858. m.Post("/", lfs.PostLockHandler)
  859. m.Post("/verify", lfs.VerifyLockHandler)
  860. m.Post("/:lid/unlock", lfs.UnLockHandler)
  861. })
  862. m.Any("/*", func(ctx *context.Context) {
  863. ctx.NotFound("", nil)
  864. })
  865. }, ignSignInAndCsrf)
  866. m.Any("/*", ignSignInAndCsrf, repo.HTTP)
  867. m.Head("/tasks/trigger", repo.TriggerTask)
  868. })
  869. })
  870. // ***** END: Repository *****
  871. m.Group("/notifications", func() {
  872. m.Get("", user.Notifications)
  873. m.Post("/status", user.NotificationStatusPost)
  874. m.Post("/purge", user.NotificationPurgePost)
  875. }, reqSignIn)
  876. if setting.API.EnableSwagger {
  877. m.Get("/swagger.v1.json", templates.JSONRenderer(), routers.SwaggerV1Json)
  878. }
  879. var handlers []macaron.Handler
  880. if setting.EnableCORS {
  881. handlers = append(handlers, cors.CORS(setting.CORSConfig))
  882. }
  883. handlers = append(handlers, ignSignIn)
  884. m.Group("/api", func() {
  885. apiv1.RegisterRoutes(m)
  886. }, handlers...)
  887. m.Group("/api/internal", func() {
  888. // package name internal is ideal but Golang is not allowed, so we use private as package name.
  889. private.RegisterRoutes(m)
  890. })
  891. // robots.txt
  892. m.Get("/robots.txt", func(ctx *context.Context) {
  893. if setting.HasRobotsTxt {
  894. ctx.ServeFileContent(path.Join(setting.CustomPath, "robots.txt"))
  895. } else {
  896. ctx.NotFound("", nil)
  897. }
  898. })
  899. // Progressive Web App
  900. m.Get("/manifest.json", templates.JSONRenderer(), func(ctx *context.Context) {
  901. ctx.HTML(200, "pwa/manifest_json")
  902. })
  903. m.Get("/serviceworker.js", templates.JSRenderer(), func(ctx *context.Context) {
  904. ctx.HTML(200, "pwa/serviceworker_js")
  905. })
  906. // prometheus metrics endpoint
  907. if setting.Metrics.Enabled {
  908. c := metrics.NewCollector()
  909. prometheus.MustRegister(c)
  910. m.Get("/metrics", routers.Metrics)
  911. }
  912. // Not found handler.
  913. m.NotFound(routers.NotFound)
  914. }