From 223b9d9a64dee3a3a1c49f88cdd6d93eb6958365 Mon Sep 17 00:00:00 2001 From: David Svantesson Date: Sun, 29 Sep 2019 22:36:52 +0200 Subject: [PATCH] Add 'make revive' to instructions for checking code (#8314) * Add 'make revive' to instructions for checking code This is performed on drone, hacking instructions should contain the same to avoid unnecessary PR builds. * lint is deprecated. Denote revive +vet as code analysis in continuous text. --- docs/content/doc/advanced/hacking-on-gitea.en-us.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/content/doc/advanced/hacking-on-gitea.en-us.md b/docs/content/doc/advanced/hacking-on-gitea.en-us.md index 7358b1014..8c8249c04 100644 --- a/docs/content/doc/advanced/hacking-on-gitea.en-us.md +++ b/docs/content/doc/advanced/hacking-on-gitea.en-us.md @@ -108,10 +108,10 @@ and look at our [`.drone.yml`](https://github.com/go-gitea/gitea/blob/master/.drone.yml) to see how our continuous integration works. -### Formatting, linting, vetting and spell-check +### Formatting, code analysis and spell check Our continous integration will reject PRs that are not properly formatted, fail -linting, vet or spell-check. +code analysis or spell check. You should format your code with `go fmt` using: @@ -130,10 +130,10 @@ You should run the same version of go that is on the continuous integration server as mentioned above. `make fmt-check` will only check if your `go` would format differently - this may be different from the CI server version. -You should lint, vet and spell-check with: +You should run revive, vet and spell-check on the code with: ```bash -make vet lint misspell-check +make revive vet misspell-check ``` ### Updating CSS