Browse Source

Set the initial commit status to Success otherwise it will always be Pending (#10317)

The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
for-closed-social
zeripath 4 years ago
committed by GitHub
parent
commit
e96f3542d0
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      services/pull/commit_status.go

+ 1
- 1
services/pull/commit_status.go View File

@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
return structs.CommitStatusSuccess
}
var returnedStatus = structs.CommitStatusPending
var returnedStatus = structs.CommitStatusSuccess
for _, ctx := range requiredContexts {
var targetStatus structs.CommitStatusState
for _, commitStatus := range commitStatuses {

Loading…
Cancel
Save