Browse Source

Fix 500 when getting user as unauthenticated user (#8653)

When doing GET /api/v1/users/{user} as an unauthenticated user,
gitea throws a 500 because it's trying to dereference elements
from the context user. It wants to do this to see whether to
show the primary email and will do that if the logged in user
is admin or the user in question. However, if ctx.User is nil,
go gets really unhappy.
for-closed-social
Monty Taylor 5 years ago
committed by Lunny Xiao
parent
commit
ee7b153dd9
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      routers/api/v1/user/user.go

+ 1
- 1
routers/api/v1/user/user.go View File

@ -104,7 +104,7 @@ func GetInfo(ctx *context.APIContext) {
return
}
ctx.JSON(200, convert.ToUser(u, ctx.IsSigned, ctx.User.ID == u.ID || ctx.User.IsAdmin))
ctx.JSON(200, convert.ToUser(u, ctx.IsSigned, ctx.User != nil && (ctx.User.ID == u.ID || ctx.User.IsAdmin)))
}
// GetAuthenticatedUser get current user's information

Loading…
Cancel
Save