Browse Source

Prevent double-close of issues (#6233)

for-closed-social
zeripath 5 years ago
committed by techknowlogick
parent
commit
f066bd2b3f
1 changed files with 7 additions and 1 deletions
  1. +7
    -1
      models/issue.go

+ 7
- 1
models/issue.go View File

@ -699,8 +699,14 @@ func UpdateIssueCols(issue *Issue, cols ...string) error {
} }
func (issue *Issue) changeStatus(e *xorm.Session, doer *User, isClosed bool) (err error) { func (issue *Issue) changeStatus(e *xorm.Session, doer *User, isClosed bool) (err error) {
// Reload the issue
currentIssue, err := getIssueByID(e, issue.ID)
if err != nil {
return err
}
// Nothing should be performed if current status is same as target status // Nothing should be performed if current status is same as target status
if issue.IsClosed == isClosed {
if currentIssue.IsClosed == isClosed {
return nil return nil
} }

Loading…
Cancel
Save