You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

755 lines
23 KiB

8 years ago
Account domain blocks (#2381) * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation * Adding account domain blocks that filter notifications and public timelines * Add tests for domain blocks in notifications, public timelines Filter reblogs of blocked domains from home * Add API for listing and creating account domain blocks * API for creating/deleting domain blocks, tests for Status#ancestors and Status#descendants, filter domain blocks from them * Filter domains in streaming API * Update account_domain_block_spec.rb
7 years ago
8 years ago
  1. require 'rails_helper'
  2. RSpec.describe Status, type: :model do
  3. let(:alice) { Fabricate(:account, username: 'alice') }
  4. let(:bob) { Fabricate(:account, username: 'bob') }
  5. let(:other) { Fabricate(:status, account: bob, text: 'Skulls for the skull god! The enemy\'s gates are sideways!') }
  6. subject { Fabricate(:status, account: alice) }
  7. describe '#local?' do
  8. it 'returns true when no remote URI is set' do
  9. expect(subject.local?).to be true
  10. end
  11. it 'returns false if a remote URI is set' do
  12. alice.update(domain: 'example.com')
  13. subject.save
  14. expect(subject.local?).to be false
  15. end
  16. it 'returns true if a URI is set and `local` is true' do
  17. subject.update(uri: 'example.com', local: true)
  18. expect(subject.local?).to be true
  19. end
  20. end
  21. describe '#reblog?' do
  22. it 'returns true when the status reblogs another status' do
  23. subject.reblog = other
  24. expect(subject.reblog?).to be true
  25. end
  26. it 'returns false if the status is self-contained' do
  27. expect(subject.reblog?).to be false
  28. end
  29. end
  30. describe '#reply?' do
  31. it 'returns true if the status references another' do
  32. subject.thread = other
  33. expect(subject.reply?).to be true
  34. end
  35. it 'returns false if the status is self-contained' do
  36. expect(subject.reply?).to be false
  37. end
  38. end
  39. describe '#verb' do
  40. context 'if destroyed?' do
  41. it 'returns :delete' do
  42. subject.destroy!
  43. expect(subject.verb).to be :delete
  44. end
  45. end
  46. context 'unless destroyed?' do
  47. context 'if reblog?' do
  48. it 'returns :share' do
  49. subject.reblog = other
  50. expect(subject.verb).to be :share
  51. end
  52. end
  53. context 'unless reblog?' do
  54. it 'returns :post' do
  55. subject.reblog = nil
  56. expect(subject.verb).to be :post
  57. end
  58. end
  59. end
  60. end
  61. describe '#object_type' do
  62. it 'is note when the status is self-contained' do
  63. expect(subject.object_type).to be :note
  64. end
  65. it 'is comment when the status replies to another' do
  66. subject.thread = other
  67. expect(subject.object_type).to be :comment
  68. end
  69. end
  70. describe '#title' do
  71. # rubocop:disable Style/InterpolationCheck
  72. let(:account) { subject.account }
  73. context 'if destroyed?' do
  74. it 'returns "#{account.acct} deleted status"' do
  75. subject.destroy!
  76. expect(subject.title).to eq "#{account.acct} deleted status"
  77. end
  78. end
  79. context 'unless destroyed?' do
  80. context 'if reblog?' do
  81. it 'returns "#{account.acct} shared a status by #{reblog.account.acct}"' do
  82. reblog = subject.reblog = other
  83. expect(subject.title).to eq "#{account.acct} shared a status by #{reblog.account.acct}"
  84. end
  85. end
  86. context 'unless reblog?' do
  87. it 'returns "New status by #{account.acct}"' do
  88. subject.reblog = nil
  89. expect(subject.title).to eq "New status by #{account.acct}"
  90. end
  91. end
  92. end
  93. end
  94. describe '#hidden?' do
  95. context 'if private_visibility?' do
  96. it 'returns true' do
  97. subject.visibility = :private
  98. expect(subject.hidden?).to be true
  99. end
  100. end
  101. context 'if direct_visibility?' do
  102. it 'returns true' do
  103. subject.visibility = :direct
  104. expect(subject.hidden?).to be true
  105. end
  106. end
  107. context 'if public_visibility?' do
  108. it 'returns false' do
  109. subject.visibility = :public
  110. expect(subject.hidden?).to be false
  111. end
  112. end
  113. context 'if unlisted_visibility?' do
  114. it 'returns false' do
  115. subject.visibility = :unlisted
  116. expect(subject.hidden?).to be false
  117. end
  118. end
  119. end
  120. describe '#content' do
  121. it 'returns the text of the status if it is not a reblog' do
  122. expect(subject.content).to eql subject.text
  123. end
  124. it 'returns the text of the reblogged status' do
  125. subject.reblog = other
  126. expect(subject.content).to eql other.text
  127. end
  128. end
  129. describe '#target' do
  130. it 'returns nil if the status is self-contained' do
  131. expect(subject.target).to be_nil
  132. end
  133. it 'returns nil if the status is a reply' do
  134. subject.thread = other
  135. expect(subject.target).to be_nil
  136. end
  137. it 'returns the reblogged status' do
  138. subject.reblog = other
  139. expect(subject.target).to eq other
  140. end
  141. end
  142. describe '#reblogs_count' do
  143. it 'is the number of reblogs' do
  144. Fabricate(:status, account: bob, reblog: subject)
  145. Fabricate(:status, account: alice, reblog: subject)
  146. expect(subject.reblogs_count).to eq 2
  147. end
  148. end
  149. describe '#favourites_count' do
  150. it 'is the number of favorites' do
  151. Fabricate(:favourite, account: bob, status: subject)
  152. Fabricate(:favourite, account: alice, status: subject)
  153. expect(subject.favourites_count).to eq 2
  154. end
  155. end
  156. describe '#proper' do
  157. it 'is itself for original statuses' do
  158. expect(subject.proper).to eq subject
  159. end
  160. it 'is the source status for reblogs' do
  161. subject.reblog = other
  162. expect(subject.proper).to eq other
  163. end
  164. end
  165. describe 'on create' do
  166. let(:local_account) { Fabricate(:account, username: 'local', domain: nil) }
  167. let(:remote_account) { Fabricate(:account, username: 'remote', domain: 'example.com') }
  168. subject { Status.new }
  169. describe 'on a status that ends with the local-only emoji' do
  170. before do
  171. subject.text = 'A toot ' + subject.local_only_emoji
  172. end
  173. context 'if the status originates from this instance' do
  174. before do
  175. subject.account = local_account
  176. end
  177. it 'is marked local-only' do
  178. subject.save!
  179. expect(subject).to be_local_only
  180. end
  181. end
  182. context 'if the status is remote' do
  183. before do
  184. subject.account = remote_account
  185. end
  186. it 'is not marked local-only' do
  187. subject.save!
  188. expect(subject).to_not be_local_only
  189. end
  190. end
  191. end
  192. end
  193. describe '.mutes_map' do
  194. let(:status) { Fabricate(:status) }
  195. let(:account) { Fabricate(:account) }
  196. subject { Status.mutes_map([status.conversation.id], account) }
  197. it 'returns a hash' do
  198. expect(subject).to be_a Hash
  199. end
  200. it 'contains true value' do
  201. account.mute_conversation!(status.conversation)
  202. expect(subject[status.conversation.id]).to be true
  203. end
  204. end
  205. describe '.favourites_map' do
  206. let(:status) { Fabricate(:status) }
  207. let(:account) { Fabricate(:account) }
  208. subject { Status.favourites_map([status], account) }
  209. it 'returns a hash' do
  210. expect(subject).to be_a Hash
  211. end
  212. it 'contains true value' do
  213. Fabricate(:favourite, status: status, account: account)
  214. expect(subject[status.id]).to be true
  215. end
  216. end
  217. describe '.reblogs_map' do
  218. let(:status) { Fabricate(:status) }
  219. let(:account) { Fabricate(:account) }
  220. subject { Status.reblogs_map([status], account) }
  221. it 'returns a hash' do
  222. expect(subject).to be_a Hash
  223. end
  224. it 'contains true value' do
  225. Fabricate(:status, account: account, reblog: status)
  226. expect(subject[status.id]).to be true
  227. end
  228. end
  229. describe '.not_in_filtered_languages' do
  230. context 'for accounts with language filters' do
  231. let(:user) { Fabricate(:user, filtered_languages: ['en']) }
  232. it 'does not include statuses in filtered languages' do
  233. status = Fabricate(:status, language: 'en')
  234. expect(Status.not_in_filtered_languages(user.account)).not_to include status
  235. end
  236. it 'includes status with unknown language' do
  237. status = Fabricate(:status, language: nil)
  238. expect(Status.not_in_filtered_languages(user.account)).to include status
  239. end
  240. end
  241. end
  242. describe '.as_home_timeline' do
  243. let(:account) { Fabricate(:account) }
  244. let(:followed) { Fabricate(:account) }
  245. let(:not_followed) { Fabricate(:account) }
  246. before do
  247. Fabricate(:follow, account: account, target_account: followed)
  248. @self_status = Fabricate(:status, account: account, visibility: :public)
  249. @self_direct_status = Fabricate(:status, account: account, visibility: :direct)
  250. @followed_status = Fabricate(:status, account: followed, visibility: :public)
  251. @followed_direct_status = Fabricate(:status, account: followed, visibility: :direct)
  252. @not_followed_status = Fabricate(:status, account: not_followed, visibility: :public)
  253. @results = Status.as_home_timeline(account)
  254. end
  255. it 'includes statuses from self' do
  256. expect(@results).to include(@self_status)
  257. end
  258. it 'does not include direct statuses from self' do
  259. expect(@results).to_not include(@self_direct_status)
  260. end
  261. it 'includes statuses from followed' do
  262. expect(@results).to include(@followed_status)
  263. end
  264. it 'does not include direct statuses mentioning recipient from followed' do
  265. Fabricate(:mention, account: account, status: @followed_direct_status)
  266. expect(@results).to_not include(@followed_direct_status)
  267. end
  268. it 'does not include direct statuses not mentioning recipient from followed' do
  269. expect(@results).not_to include(@followed_direct_status)
  270. end
  271. it 'does not include statuses from non-followed' do
  272. expect(@results).not_to include(@not_followed_status)
  273. end
  274. end
  275. describe '.as_direct_timeline' do
  276. let(:account) { Fabricate(:account) }
  277. let(:followed) { Fabricate(:account) }
  278. let(:not_followed) { Fabricate(:account) }
  279. before do
  280. Fabricate(:follow, account: account, target_account: followed)
  281. @self_public_status = Fabricate(:status, account: account, visibility: :public)
  282. @self_direct_status = Fabricate(:status, account: account, visibility: :direct)
  283. @followed_public_status = Fabricate(:status, account: followed, visibility: :public)
  284. @followed_direct_status = Fabricate(:status, account: followed, visibility: :direct)
  285. @not_followed_direct_status = Fabricate(:status, account: not_followed, visibility: :direct)
  286. @results = Status.as_direct_timeline(account)
  287. end
  288. it 'does not include public statuses from self' do
  289. expect(@results).to_not include(@self_public_status)
  290. end
  291. it 'includes direct statuses from self' do
  292. expect(@results).to include(@self_direct_status)
  293. end
  294. it 'does not include public statuses from followed' do
  295. expect(@results).to_not include(@followed_public_status)
  296. end
  297. it 'includes direct statuses mentioning recipient from followed' do
  298. Fabricate(:mention, account: account, status: @followed_direct_status)
  299. expect(@results).to include(@followed_direct_status)
  300. end
  301. it 'does not include direct statuses not mentioning recipient from followed' do
  302. expect(@results).to_not include(@followed_direct_status)
  303. end
  304. it 'includes direct statuses mentioning recipient from non-followed' do
  305. Fabricate(:mention, account: account, status: @not_followed_direct_status)
  306. expect(@results).to include(@not_followed_direct_status)
  307. end
  308. it 'does not include direct statuses not mentioning recipient from non-followed' do
  309. expect(@results).to_not include(@not_followed_direct_status)
  310. end
  311. end
  312. describe '.as_public_timeline' do
  313. it 'only includes statuses with public visibility' do
  314. public_status = Fabricate(:status, visibility: :public)
  315. private_status = Fabricate(:status, visibility: :private)
  316. results = Status.as_public_timeline
  317. expect(results).to include(public_status)
  318. expect(results).not_to include(private_status)
  319. end
  320. it 'does not include replies' do
  321. status = Fabricate(:status)
  322. reply = Fabricate(:status, in_reply_to_id: status.id)
  323. results = Status.as_public_timeline
  324. expect(results).to include(status)
  325. expect(results).not_to include(reply)
  326. end
  327. it 'does not include boosts' do
  328. status = Fabricate(:status)
  329. boost = Fabricate(:status, reblog_of_id: status.id)
  330. results = Status.as_public_timeline
  331. expect(results).to include(status)
  332. expect(results).not_to include(boost)
  333. end
  334. it 'filters out silenced accounts' do
  335. account = Fabricate(:account)
  336. silenced_account = Fabricate(:account, silenced: true)
  337. status = Fabricate(:status, account: account)
  338. silenced_status = Fabricate(:status, account: silenced_account)
  339. results = Status.as_public_timeline
  340. expect(results).to include(status)
  341. expect(results).not_to include(silenced_status)
  342. end
  343. context 'without local_only option' do
  344. let(:viewer) { nil }
  345. let!(:local_account) { Fabricate(:account, domain: nil) }
  346. let!(:remote_account) { Fabricate(:account, domain: 'test.com') }
  347. let!(:local_status) { Fabricate(:status, account: local_account) }
  348. let!(:remote_status) { Fabricate(:status, account: remote_account) }
  349. subject { Status.as_public_timeline(viewer, false) }
  350. context 'without a viewer' do
  351. let(:viewer) { nil }
  352. it 'includes remote instances statuses' do
  353. expect(subject).to include(remote_status)
  354. end
  355. it 'includes local statuses' do
  356. expect(subject).to include(local_status)
  357. end
  358. end
  359. context 'with a viewer' do
  360. let(:viewer) { Fabricate(:account, username: 'viewer') }
  361. it 'includes remote instances statuses' do
  362. expect(subject).to include(remote_status)
  363. end
  364. it 'includes local statuses' do
  365. expect(subject).to include(local_status)
  366. end
  367. end
  368. end
  369. context 'with a local_only option set' do
  370. let!(:local_account) { Fabricate(:account, domain: nil) }
  371. let!(:remote_account) { Fabricate(:account, domain: 'test.com') }
  372. let!(:local_status) { Fabricate(:status, account: local_account) }
  373. let!(:remote_status) { Fabricate(:status, account: remote_account) }
  374. subject { Status.as_public_timeline(viewer, true) }
  375. context 'without a viewer' do
  376. let(:viewer) { nil }
  377. it 'does not include remote instances statuses' do
  378. expect(subject).to include(local_status)
  379. expect(subject).not_to include(remote_status)
  380. end
  381. end
  382. context 'with a viewer' do
  383. let(:viewer) { Fabricate(:account, username: 'viewer') }
  384. it 'does not include remote instances statuses' do
  385. expect(subject).to include(local_status)
  386. expect(subject).not_to include(remote_status)
  387. end
  388. it 'is not affected by personal domain blocks' do
  389. viewer.block_domain!('test.com')
  390. expect(subject).to include(local_status)
  391. expect(subject).not_to include(remote_status)
  392. end
  393. end
  394. end
  395. describe 'with an account passed in' do
  396. before do
  397. @account = Fabricate(:account)
  398. end
  399. it 'excludes statuses from accounts blocked by the account' do
  400. blocked = Fabricate(:account)
  401. Fabricate(:block, account: @account, target_account: blocked)
  402. blocked_status = Fabricate(:status, account: blocked)
  403. results = Status.as_public_timeline(@account)
  404. expect(results).not_to include(blocked_status)
  405. end
  406. it 'excludes statuses from accounts who have blocked the account' do
  407. blocked = Fabricate(:account)
  408. Fabricate(:block, account: blocked, target_account: @account)
  409. blocked_status = Fabricate(:status, account: blocked)
  410. results = Status.as_public_timeline(@account)
  411. expect(results).not_to include(blocked_status)
  412. end
  413. it 'excludes statuses from accounts muted by the account' do
  414. muted = Fabricate(:account)
  415. Fabricate(:mute, account: @account, target_account: muted)
  416. muted_status = Fabricate(:status, account: muted)
  417. results = Status.as_public_timeline(@account)
  418. expect(results).not_to include(muted_status)
  419. end
  420. it 'excludes statuses from accounts from personally blocked domains' do
  421. blocked = Fabricate(:account, domain: 'example.com')
  422. @account.block_domain!(blocked.domain)
  423. blocked_status = Fabricate(:status, account: blocked)
  424. results = Status.as_public_timeline(@account)
  425. expect(results).not_to include(blocked_status)
  426. end
  427. context 'with language preferences' do
  428. it 'excludes statuses in languages not allowed by the account user' do
  429. user = Fabricate(:user, filtered_languages: [:fr])
  430. @account.update(user: user)
  431. en_status = Fabricate(:status, language: 'en')
  432. es_status = Fabricate(:status, language: 'es')
  433. fr_status = Fabricate(:status, language: 'fr')
  434. results = Status.as_public_timeline(@account)
  435. expect(results).to include(en_status)
  436. expect(results).to include(es_status)
  437. expect(results).not_to include(fr_status)
  438. end
  439. it 'includes all languages when user does not have a setting' do
  440. user = Fabricate(:user, filtered_languages: [])
  441. @account.update(user: user)
  442. en_status = Fabricate(:status, language: 'en')
  443. es_status = Fabricate(:status, language: 'es')
  444. results = Status.as_public_timeline(@account)
  445. expect(results).to include(en_status)
  446. expect(results).to include(es_status)
  447. end
  448. it 'includes all languages when account does not have a user' do
  449. expect(@account.user).to be_nil
  450. en_status = Fabricate(:status, language: 'en')
  451. es_status = Fabricate(:status, language: 'es')
  452. results = Status.as_public_timeline(@account)
  453. expect(results).to include(en_status)
  454. expect(results).to include(es_status)
  455. end
  456. end
  457. context 'where that account is silenced' do
  458. it 'includes statuses from other accounts that are silenced' do
  459. @account.update(silenced: true)
  460. other_silenced_account = Fabricate(:account, silenced: true)
  461. other_status = Fabricate(:status, account: other_silenced_account)
  462. results = Status.as_public_timeline(@account)
  463. expect(results).to include(other_status)
  464. end
  465. end
  466. end
  467. context 'with local-only statuses' do
  468. let(:status) { Fabricate(:status, local_only: true) }
  469. subject { Status.as_public_timeline(viewer) }
  470. context 'without a viewer' do
  471. let(:viewer) { nil }
  472. it 'excludes local-only statuses' do
  473. expect(subject).to_not include(status)
  474. end
  475. end
  476. context 'with a viewer' do
  477. let(:viewer) { Fabricate(:account, username: 'viewer') }
  478. it 'includes local-only statuses' do
  479. expect(subject).to include(status)
  480. end
  481. end
  482. # TODO: What happens if the viewer is remote?
  483. # Can the viewer be remote?
  484. # What prevents the viewer from being remote?
  485. end
  486. end
  487. describe '.as_tag_timeline' do
  488. it 'includes statuses with a tag' do
  489. tag = Fabricate(:tag)
  490. status = Fabricate(:status, tags: [tag])
  491. other = Fabricate(:status)
  492. results = Status.as_tag_timeline(tag)
  493. expect(results).to include(status)
  494. expect(results).not_to include(other)
  495. end
  496. it 'allows replies to be included' do
  497. original = Fabricate(:status)
  498. tag = Fabricate(:tag)
  499. status = Fabricate(:status, tags: [tag], in_reply_to_id: original.id)
  500. results = Status.as_tag_timeline(tag)
  501. expect(results).to include(status)
  502. end
  503. context 'on a local-only status' do
  504. let(:tag) { Fabricate(:tag) }
  505. let(:status) { Fabricate(:status, local_only: true, tags: [tag]) }
  506. context 'without a viewer' do
  507. let(:viewer) { nil }
  508. it 'filters the local-only status out of the result set' do
  509. expect(Status.as_tag_timeline(tag, viewer)).not_to include(status)
  510. end
  511. end
  512. context 'with a viewer' do
  513. let(:viewer) { Fabricate(:account, username: 'viewer', domain: nil) }
  514. it 'keeps the local-only status in the result set' do
  515. expect(Status.as_tag_timeline(tag, viewer)).to include(status)
  516. end
  517. end
  518. end
  519. end
  520. describe '.permitted_for' do
  521. subject { described_class.permitted_for(target_account, account).pluck(:visibility) }
  522. let(:target_account) { alice }
  523. let(:account) { bob }
  524. let!(:public_status) { Fabricate(:status, account: target_account, visibility: 'public') }
  525. let!(:unlisted_status) { Fabricate(:status, account: target_account, visibility: 'unlisted') }
  526. let!(:private_status) { Fabricate(:status, account: target_account, visibility: 'private') }
  527. let!(:direct_status) do
  528. Fabricate(:status, account: target_account, visibility: 'direct').tap do |status|
  529. Fabricate(:mention, status: status, account: account)
  530. end
  531. end
  532. let!(:other_direct_status) do
  533. Fabricate(:status, account: target_account, visibility: 'direct').tap do |status|
  534. Fabricate(:mention, status: status)
  535. end
  536. end
  537. context 'given nil' do
  538. let(:account) { nil }
  539. let(:direct_status) { nil }
  540. it { is_expected.to eq(%w(unlisted public)) }
  541. end
  542. context 'given blocked account' do
  543. before do
  544. target_account.block!(account)
  545. end
  546. it { is_expected.to be_empty }
  547. end
  548. context 'given same account' do
  549. let(:account) { target_account }
  550. it { is_expected.to eq(%w(direct direct private unlisted public)) }
  551. end
  552. context 'given followed account' do
  553. before do
  554. account.follow!(target_account)
  555. end
  556. it { is_expected.to eq(%w(direct private unlisted public)) }
  557. end
  558. context 'given unfollowed account' do
  559. it { is_expected.to eq(%w(direct unlisted public)) }
  560. end
  561. end
  562. describe 'before_validation' do
  563. it 'sets account being replied to correctly over intermediary nodes' do
  564. first_status = Fabricate(:status, account: bob)
  565. intermediary = Fabricate(:status, thread: first_status, account: alice)
  566. final = Fabricate(:status, thread: intermediary, account: alice)
  567. expect(final.in_reply_to_account_id).to eq bob.id
  568. end
  569. it 'creates new conversation for stand-alone status' do
  570. expect(Status.create(account: alice, text: 'First').conversation_id).to_not be_nil
  571. end
  572. it 'keeps conversation of parent node' do
  573. parent = Fabricate(:status, text: 'First')
  574. expect(Status.create(account: alice, thread: parent, text: 'Response').conversation_id).to eq parent.conversation_id
  575. end
  576. it 'sets `local` to true for status by local account' do
  577. expect(Status.create(account: alice, text: 'foo').local).to be true
  578. end
  579. it 'sets `local` to false for status by remote account' do
  580. alice.update(domain: 'example.com')
  581. expect(Status.create(account: alice, text: 'foo').local).to be false
  582. end
  583. end
  584. describe 'validation' do
  585. it 'disallow empty uri for remote status' do
  586. alice.update(domain: 'example.com')
  587. status = Fabricate.build(:status, uri: '', account: alice)
  588. expect(status).to model_have_error_on_field(:uri)
  589. end
  590. end
  591. describe 'after_create' do
  592. it 'saves ActivityPub uri as uri for local status' do
  593. status = Status.create(account: alice, text: 'foo')
  594. status.reload
  595. expect(status.uri).to start_with('https://')
  596. end
  597. end
  598. end