You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

166 lines
5.0 KiB

Change IDs to strings rather than numbers in API JSON output (#5019) * Fix JavaScript interface with long IDs Somewhat predictably, the JS interface handled IDs as numbers, which in JS are IEEE double-precision floats. This loses some precision when working with numbers as large as those generated by the new ID scheme, so we instead handle them here as strings. This is relatively simple, and doesn't appear to have caused any problems, but should definitely be tested more thoroughly than the built-in tests. Several days of use appear to support this working properly. BREAKING CHANGE: The major(!) change here is that IDs are now returned as strings by the REST endpoints, rather than as integers. In practice, relatively few changes were required to make the existing JS UI work with this change, but it will likely hit API clients pretty hard: it's an entirely different type to consume. (The one API client I tested, Tusky, handles this with no problems, however.) Twitter ran into this issue when introducing Snowflake IDs, and decided to instead introduce an `id_str` field in JSON responses. I have opted to *not* do that, and instead force all IDs to 64-bit integers represented by strings in one go. (I believe Twitter exacerbated their problem by rolling out the changes three times: once for statuses, once for DMs, and once for user IDs, as well as by leaving an integer ID value in JSON. As they said, "If you’re using the `id` field with JSON in a Javascript-related language, there is a very high likelihood that the integers will be silently munged by Javascript interpreters. In most cases, this will result in behavior such as being unable to load or delete a specific direct message, because the ID you're sending to the API is different than the actual identifier associated with the message." [1]) However, given that this is a significant change for API users, alternatives or a transition time may be appropriate. 1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html * Additional fixes for stringified IDs in JSON These should be the last two. These were identified using eslint to try to identify any plain casts to JavaScript numbers. (Some such casts are legitimate, but these were not.) Adding the following to .eslintrc.yml will identify casts to numbers: ~~~ no-restricted-syntax: - warn - selector: UnaryExpression[operator='+'] > :not(Literal) message: Avoid the use of unary + - selector: CallExpression[callee.name='Number'] message: Casting with Number() may coerce string IDs to numbers ~~~ The remaining three casts appear legitimate: two casts to array indices, one in a server to turn an environment variable into a number. * Back out RelationshipsController Change This was made to make a test a bit less flakey, but has nothing to do with this branch. * Change internal streaming payloads to stringified IDs as well Per https://github.com/tootsuite/mastodon/pull/5019#issuecomment-330736452 we need these changes to send deleted status IDs as strings, not integers.
6 years ago
  1. # frozen_string_literal: true
  2. class RemoveStatusService < BaseService
  3. include StreamEntryRenderer
  4. def call(status, **options)
  5. @payload = Oj.dump(event: :delete, payload: status.id.to_s)
  6. @status = status
  7. @account = status.account
  8. @tags = status.tags.pluck(:name).to_a
  9. @mentions = status.mentions.includes(:account).to_a
  10. @reblogs = status.reblogs.to_a
  11. @stream_entry = status.stream_entry
  12. @options = options
  13. remove_from_self if status.account.local?
  14. remove_from_followers
  15. remove_from_lists
  16. remove_from_affected
  17. remove_reblogs
  18. remove_from_hashtags
  19. remove_from_public
  20. remove_from_media if status.media_attachments.any?
  21. remove_from_direct if status.direct_visibility?
  22. @status.destroy!
  23. # There is no reason to send out Undo activities when the
  24. # cause is that the original object has been removed, since
  25. # original object being removed implicitly removes reblogs
  26. # of it. The Delete activity of the original is forwarded
  27. # separately.
  28. return if !@account.local? || @options[:original_removed]
  29. remove_from_remote_followers
  30. remove_from_remote_affected
  31. end
  32. private
  33. def remove_from_self
  34. FeedManager.instance.unpush_from_home(@account, @status)
  35. end
  36. def remove_from_followers
  37. @account.followers_for_local_distribution.reorder(nil).find_each do |follower|
  38. FeedManager.instance.unpush_from_home(follower, @status)
  39. end
  40. end
  41. def remove_from_lists
  42. @account.lists_for_local_distribution.select(:id, :account_id).reorder(nil).find_each do |list|
  43. FeedManager.instance.unpush_from_list(list, @status)
  44. end
  45. end
  46. def remove_from_affected
  47. @mentions.map(&:account).select(&:local?).each do |account|
  48. Redis.current.publish("timeline:#{account.id}", @payload)
  49. end
  50. end
  51. def remove_from_remote_affected
  52. # People who got mentioned in the status, or who
  53. # reblogged it from someone else might not follow
  54. # the author and wouldn't normally receive the
  55. # delete notification - so here, we explicitly
  56. # send it to them
  57. target_accounts = (@mentions.map(&:account).reject(&:local?) + @reblogs.map(&:account).reject(&:local?))
  58. target_accounts << @status.reblog.account if @status.reblog? && !@status.reblog.account.local?
  59. target_accounts.uniq!(&:id)
  60. # Ostatus
  61. NotificationWorker.push_bulk(target_accounts.select(&:ostatus?).uniq(&:domain)) do |target_account|
  62. [salmon_xml, @account.id, target_account.id]
  63. end
  64. # ActivityPub
  65. ActivityPub::DeliveryWorker.push_bulk(target_accounts.select(&:activitypub?).uniq(&:inbox_url)) do |target_account|
  66. [signed_activity_json, @account.id, target_account.inbox_url]
  67. end
  68. end
  69. def remove_from_remote_followers
  70. # OStatus
  71. Pubsubhubbub::RawDistributionWorker.perform_async(salmon_xml, @account.id)
  72. # ActivityPub
  73. ActivityPub::DeliveryWorker.push_bulk(@account.followers.inboxes) do |inbox_url|
  74. [signed_activity_json, @account.id, inbox_url]
  75. end
  76. relay! if relayable?
  77. end
  78. def relayable?
  79. @status.public_visibility?
  80. end
  81. def relay!
  82. ActivityPub::DeliveryWorker.push_bulk(Relay.enabled.pluck(:inbox_url)) do |inbox_url|
  83. [signed_activity_json, @account.id, inbox_url]
  84. end
  85. end
  86. def salmon_xml
  87. @salmon_xml ||= stream_entry_to_xml(@stream_entry)
  88. end
  89. def signed_activity_json
  90. @signed_activity_json ||= Oj.dump(ActivityPub::LinkedDataSignature.new(activity_json).sign!(@account))
  91. end
  92. def activity_json
  93. @activity_json ||= ActiveModelSerializers::SerializableResource.new(
  94. @status,
  95. serializer: @status.reblog? ? ActivityPub::UndoAnnounceSerializer : ActivityPub::DeleteSerializer,
  96. adapter: ActivityPub::Adapter
  97. ).as_json
  98. end
  99. def remove_reblogs
  100. # We delete reblogs of the status before the original status,
  101. # because once original status is gone, reblogs will disappear
  102. # without us being able to do all the fancy stuff
  103. @reblogs.each do |reblog|
  104. RemoveStatusService.new.call(reblog, original_removed: true)
  105. end
  106. end
  107. def remove_from_hashtags
  108. return unless @status.public_visibility?
  109. @tags.each do |hashtag|
  110. Redis.current.publish("timeline:hashtag:#{hashtag}", @payload)
  111. Redis.current.publish("timeline:hashtag:#{hashtag}:local", @payload) if @status.local?
  112. end
  113. end
  114. def remove_from_public
  115. return unless @status.public_visibility?
  116. Redis.current.publish('timeline:public', @payload)
  117. Redis.current.publish('timeline:public:local', @payload) if @status.local?
  118. end
  119. def remove_from_media
  120. return unless @status.public_visibility?
  121. Redis.current.publish('timeline:public:media', @payload)
  122. Redis.current.publish('timeline:public:local:media', @payload) if @status.local?
  123. end
  124. def remove_from_direct
  125. @mentions.each do |mention|
  126. Redis.current.publish("timeline:direct:#{mention.account.id}", @payload) if mention.account.local?
  127. end
  128. Redis.current.publish("timeline:direct:#{@account.id}", @payload) if @account.local?
  129. end
  130. def redis
  131. Redis.current
  132. end
  133. end