Feature conversations muting (#3017)
* Add <ostatus:conversation /> tag to Atom input/output
Only uses ref attribute (not href) because href would be
the alternate link that's always included also.
Creates new conversation for every non-reply status. Carries
over conversation for every reply. Keeps remote URIs verbatim,
generates local URIs on the fly like the rest of them.
* Conversation muting - prevents notifications that reference a conversation
(including replies, favourites, reblogs) from being created. API endpoints
/api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute
Currently no way to tell when a status/conversation is muted, so the web UI
only has a "disable notifications" button, doesn't work as a toggle
* Display "Dismiss notifications" on all statuses in notifications column, not just own
* Add "muted" as a boolean attribute on statuses JSON
For now always false on contained reblogs, since it's only relevant for
statuses returned from the notifications endpoint, which are not nested
Remove "Disable notifications" from detailed status view, since it's
only relevant in the notifications column
* Up max class length
* Remove pending test for conversation mute
* Add tests, clean up
* Rename to "mute conversation" and "unmute conversation"
* Raise validation error when trying to mute/unmute status without conversation
7 years ago Feature conversations muting (#3017)
* Add <ostatus:conversation /> tag to Atom input/output
Only uses ref attribute (not href) because href would be
the alternate link that's always included also.
Creates new conversation for every non-reply status. Carries
over conversation for every reply. Keeps remote URIs verbatim,
generates local URIs on the fly like the rest of them.
* Conversation muting - prevents notifications that reference a conversation
(including replies, favourites, reblogs) from being created. API endpoints
/api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute
Currently no way to tell when a status/conversation is muted, so the web UI
only has a "disable notifications" button, doesn't work as a toggle
* Display "Dismiss notifications" on all statuses in notifications column, not just own
* Add "muted" as a boolean attribute on statuses JSON
For now always false on contained reblogs, since it's only relevant for
statuses returned from the notifications endpoint, which are not nested
Remove "Disable notifications" from detailed status view, since it's
only relevant in the notifications column
* Up max class length
* Remove pending test for conversation mute
* Add tests, clean up
* Rename to "mute conversation" and "unmute conversation"
* Raise validation error when trying to mute/unmute status without conversation
7 years ago |
|
- # frozen_string_literal: true
-
- class NotifyService < BaseService
- def call(recipient, activity)
- @recipient = recipient
- @activity = activity
- @notification = Notification.new(account: @recipient, activity: @activity)
-
- return if recipient.user.nil? || blocked?
-
- create_notification
- send_email if email_enabled?
- rescue ActiveRecord::RecordInvalid
- return
- end
-
- private
-
- def blocked_mention?
- FeedManager.instance.filter?(:mentions, @notification.mention.status, @recipient.id)
- end
-
- def blocked_favourite?
- @recipient.muting?(@notification.from_account)
- end
-
- def blocked_follow?
- false
- end
-
- def blocked_reblog?
- false
- end
-
- def blocked_follow_request?
- false
- end
-
- def blocked?
- blocked = @recipient.suspended? # Skip if the recipient account is suspended anyway
- blocked ||= @recipient.id == @notification.from_account.id # Skip for interactions with self
- blocked ||= @recipient.domain_blocking?(@notification.from_account.domain) && !@recipient.following?(@notification.from_account) # Skip for domain blocked accounts
- blocked ||= @recipient.blocking?(@notification.from_account) # Skip for blocked accounts
- blocked ||= (@notification.from_account.silenced? && !@recipient.following?(@notification.from_account)) # Hellban
- blocked ||= (@recipient.user.settings.interactions['must_be_follower'] && !@notification.from_account.following?(@recipient)) # Options
- blocked ||= (@recipient.user.settings.interactions['must_be_following'] && !@recipient.following?(@notification.from_account)) # Options
- blocked ||= conversation_muted?
- blocked ||= send("blocked_#{@notification.type}?") # Type-dependent filters
- blocked
- end
-
- def conversation_muted?
- if @notification.target_status
- @recipient.muting_conversation?(@notification.target_status.conversation)
- else
- false
- end
- end
-
- def create_notification
- @notification.save!
- return unless @notification.browserable?
- Redis.current.publish("timeline:#{@recipient.id}", Oj.dump(event: :notification, payload: InlineRenderer.render(@notification, @recipient, :notification)))
- send_push_notifications
- end
-
- def send_push_notifications
- # HACK: Can be caused by quickly unfavouriting a status, since creating
- # a favourite and creating a notification are not wrapped in a transaction.
- return if @notification.activity.nil?
-
- sessions_with_subscriptions = @recipient.user.session_activations.where.not(web_push_subscription: nil)
- sessions_with_subscriptions_ids = sessions_with_subscriptions.select { |session| session.web_push_subscription.pushable? @notification }.map(&:id)
-
- WebPushNotificationWorker.push_bulk(sessions_with_subscriptions_ids) do |session_activation_id|
- [session_activation_id, @notification.id]
- end
- end
-
- def send_email
- NotificationMailer.public_send(@notification.type, @recipient, @notification).deliver_later
- end
-
- def email_enabled?
- @recipient.user.settings.notification_emails[@notification.type.to_s]
- end
- end
|