You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

170 lines
5.2 KiB

Change IDs to strings rather than numbers in API JSON output (#5019) * Fix JavaScript interface with long IDs Somewhat predictably, the JS interface handled IDs as numbers, which in JS are IEEE double-precision floats. This loses some precision when working with numbers as large as those generated by the new ID scheme, so we instead handle them here as strings. This is relatively simple, and doesn't appear to have caused any problems, but should definitely be tested more thoroughly than the built-in tests. Several days of use appear to support this working properly. BREAKING CHANGE: The major(!) change here is that IDs are now returned as strings by the REST endpoints, rather than as integers. In practice, relatively few changes were required to make the existing JS UI work with this change, but it will likely hit API clients pretty hard: it's an entirely different type to consume. (The one API client I tested, Tusky, handles this with no problems, however.) Twitter ran into this issue when introducing Snowflake IDs, and decided to instead introduce an `id_str` field in JSON responses. I have opted to *not* do that, and instead force all IDs to 64-bit integers represented by strings in one go. (I believe Twitter exacerbated their problem by rolling out the changes three times: once for statuses, once for DMs, and once for user IDs, as well as by leaving an integer ID value in JSON. As they said, "If you’re using the `id` field with JSON in a Javascript-related language, there is a very high likelihood that the integers will be silently munged by Javascript interpreters. In most cases, this will result in behavior such as being unable to load or delete a specific direct message, because the ID you're sending to the API is different than the actual identifier associated with the message." [1]) However, given that this is a significant change for API users, alternatives or a transition time may be appropriate. 1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html * Additional fixes for stringified IDs in JSON These should be the last two. These were identified using eslint to try to identify any plain casts to JavaScript numbers. (Some such casts are legitimate, but these were not.) Adding the following to .eslintrc.yml will identify casts to numbers: ~~~ no-restricted-syntax: - warn - selector: UnaryExpression[operator='+'] > :not(Literal) message: Avoid the use of unary + - selector: CallExpression[callee.name='Number'] message: Casting with Number() may coerce string IDs to numbers ~~~ The remaining three casts appear legitimate: two casts to array indices, one in a server to turn an environment variable into a number. * Back out RelationshipsController Change This was made to make a test a bit less flakey, but has nothing to do with this branch. * Change internal streaming payloads to stringified IDs as well Per https://github.com/tootsuite/mastodon/pull/5019#issuecomment-330736452 we need these changes to send deleted status IDs as strings, not integers.
7 years ago
  1. # frozen_string_literal: true
  2. class RemoveStatusService < BaseService
  3. include StreamEntryRenderer
  4. include Redisable
  5. include Payloadable
  6. def call(status, **options)
  7. @payload = Oj.dump(event: :delete, payload: status.id.to_s)
  8. @status = status
  9. @account = status.account
  10. @tags = status.tags.pluck(:name).to_a
  11. @mentions = status.active_mentions.includes(:account).to_a
  12. @reblogs = status.reblogs.includes(:account).to_a
  13. @stream_entry = status.stream_entry
  14. @options = options
  15. RedisLock.acquire(lock_options) do |lock|
  16. if lock.acquired?
  17. remove_from_self if status.account.local?
  18. remove_from_followers
  19. remove_from_lists
  20. remove_from_affected
  21. remove_reblogs
  22. remove_from_hashtags
  23. remove_from_public
  24. remove_from_media if status.media_attachments.any?
  25. remove_from_direct if status.direct_visibility?
  26. @status.destroy!
  27. else
  28. raise Mastodon::RaceConditionError
  29. end
  30. end
  31. # There is no reason to send out Undo activities when the
  32. # cause is that the original object has been removed, since
  33. # original object being removed implicitly removes reblogs
  34. # of it. The Delete activity of the original is forwarded
  35. # separately.
  36. return if !@account.local? || @options[:original_removed]
  37. remove_from_remote_followers
  38. remove_from_remote_affected
  39. end
  40. private
  41. def remove_from_self
  42. FeedManager.instance.unpush_from_home(@account, @status)
  43. FeedManager.instance.unpush_from_direct(@account, @status) if @status.direct_visibility?
  44. end
  45. def remove_from_followers
  46. @account.followers_for_local_distribution.reorder(nil).find_each do |follower|
  47. FeedManager.instance.unpush_from_home(follower, @status)
  48. end
  49. end
  50. def remove_from_lists
  51. @account.lists_for_local_distribution.select(:id, :account_id).reorder(nil).find_each do |list|
  52. FeedManager.instance.unpush_from_list(list, @status)
  53. end
  54. end
  55. def remove_from_affected
  56. @mentions.map(&:account).select(&:local?).each do |account|
  57. redis.publish("timeline:#{account.id}", @payload)
  58. end
  59. end
  60. def remove_from_remote_affected
  61. # People who got mentioned in the status, or who
  62. # reblogged it from someone else might not follow
  63. # the author and wouldn't normally receive the
  64. # delete notification - so here, we explicitly
  65. # send it to them
  66. target_accounts = (@mentions.map(&:account).reject(&:local?) + @reblogs.map(&:account).reject(&:local?))
  67. target_accounts << @status.reblog.account if @status.reblog? && !@status.reblog.account.local?
  68. target_accounts.uniq!(&:id)
  69. # Ostatus
  70. NotificationWorker.push_bulk(target_accounts.select(&:ostatus?).uniq(&:domain)) do |target_account|
  71. [salmon_xml, @account.id, target_account.id]
  72. end
  73. # ActivityPub
  74. ActivityPub::DeliveryWorker.push_bulk(target_accounts.select(&:activitypub?).uniq(&:preferred_inbox_url)) do |target_account|
  75. [signed_activity_json, @account.id, target_account.preferred_inbox_url]
  76. end
  77. end
  78. def remove_from_remote_followers
  79. # OStatus
  80. Pubsubhubbub::RawDistributionWorker.perform_async(salmon_xml, @account.id)
  81. # ActivityPub
  82. ActivityPub::DeliveryWorker.push_bulk(@account.followers.inboxes) do |inbox_url|
  83. [signed_activity_json, @account.id, inbox_url]
  84. end
  85. relay! if relayable?
  86. end
  87. def relayable?
  88. @status.public_visibility?
  89. end
  90. def relay!
  91. ActivityPub::DeliveryWorker.push_bulk(Relay.enabled.pluck(:inbox_url)) do |inbox_url|
  92. [signed_activity_json, @account.id, inbox_url]
  93. end
  94. end
  95. def salmon_xml
  96. @salmon_xml ||= stream_entry_to_xml(@stream_entry)
  97. end
  98. def signed_activity_json
  99. @signed_activity_json ||= Oj.dump(serialize_payload(@status, @status.reblog? ? ActivityPub::UndoAnnounceSerializer : ActivityPub::DeleteSerializer, signer: @account))
  100. end
  101. def remove_reblogs
  102. # We delete reblogs of the status before the original status,
  103. # because once original status is gone, reblogs will disappear
  104. # without us being able to do all the fancy stuff
  105. @reblogs.each do |reblog|
  106. RemoveStatusService.new.call(reblog, original_removed: true)
  107. end
  108. end
  109. def remove_from_hashtags
  110. @account.featured_tags.where(tag_id: @status.tags.pluck(:id)).each do |featured_tag|
  111. featured_tag.decrement(@status.id)
  112. end
  113. return unless @status.public_visibility?
  114. @tags.each do |hashtag|
  115. redis.publish("timeline:hashtag:#{hashtag}", @payload)
  116. redis.publish("timeline:hashtag:#{hashtag}:local", @payload) if @status.local?
  117. end
  118. end
  119. def remove_from_public
  120. return unless @status.public_visibility?
  121. redis.publish('timeline:public', @payload)
  122. redis.publish('timeline:public:local', @payload) if @status.local?
  123. end
  124. def remove_from_media
  125. return unless @status.public_visibility?
  126. redis.publish('timeline:public:media', @payload)
  127. redis.publish('timeline:public:local:media', @payload) if @status.local?
  128. end
  129. def remove_from_direct
  130. @mentions.each do |mention|
  131. FeedManager.instance.unpush_from_direct(mention.account, @status) if mention.account.local?
  132. end
  133. end
  134. def lock_options
  135. { redis: Redis.current, key: "distribute:#{@status.id}" }
  136. end
  137. end