Browse Source

Apply Rubocop Performance/BlockGivenWithExplicitBlock (#23441)

* Apply Rubocop Performance/BlockGivenWithExplicitBlock

* Unprefix used block parameter
closed-social-glitch-2
Nick Schonning 1 year ago
committed by GitHub
parent
commit
0d1f192c54
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
  1. +2
    -2
      app/helpers/application_helper.rb
  2. +2
    -2
      app/helpers/jsonld_helper.rb
  3. +1
    -1
      app/lib/extractor.rb
  4. +1
    -1
      app/models/trends/history.rb

+ 2
- 2
app/helpers/application_helper.rb View File

@ -67,7 +67,7 @@ module ApplicationHelper
def link_to_login(name = nil, html_options = nil, &block)
target = new_user_session_path
html_options = name if block_given?
html_options = name if block
if omniauth_only? && Devise.mappings[:user].omniauthable? && User.omniauth_providers.size == 1
target = omniauth_authorize_path(:user, User.omniauth_providers[0])
@ -75,7 +75,7 @@ module ApplicationHelper
html_options[:method] = :post
end
if block_given?
if block
link_to(target, html_options, &block)
else
link_to(name, target, html_options)

+ 2
- 2
app/helpers/jsonld_helper.rb View File

@ -213,7 +213,7 @@ module JsonLdHelper
end
end
def load_jsonld_context(url, _options = {}, &_block)
def load_jsonld_context(url, _options = {}, &block)
json = Rails.cache.fetch("jsonld:context:#{url}", expires_in: 30.days, raw: true) do
request = Request.new(:get, url)
request.add_headers('Accept' => 'application/ld+json')
@ -226,6 +226,6 @@ module JsonLdHelper
doc = JSON::LD::API::RemoteDocument.new(json, documentUrl: url)
block_given? ? yield(doc) : doc
block ? yield(doc) : doc
end
end

+ 1
- 1
app/lib/extractor.rb View File

@ -18,7 +18,7 @@ module Extractor
return [] if entities.empty?
entities = remove_overlapping_entities(entities)
entities.each(&block) if block_given?
entities.each(&block) if block
entities
end

+ 1
- 1
app/models/trends/history.rb View File

@ -87,7 +87,7 @@ class Trends::History
end
def each(&block)
if block_given?
if block
(0...7).map { |i| yield(get(i.days.ago)) }
else
to_enum(:each)

Loading…
Cancel
Save