Browse Source

Autofix Rubocop Security/IoMethods (#23757)

closed-social-glitch-2
Nick Schonning 1 year ago
committed by GitHub
parent
commit
35d032500b
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 10 deletions
  1. +0
    -7
      .rubocop_todo.yml
  2. +2
    -2
      spec/controllers/admin/export_domain_allows_controller_spec.rb
  3. +1
    -1
      spec/controllers/admin/export_domain_blocks_controller_spec.rb

+ 0
- 7
.rubocop_todo.yml View File

@ -1956,13 +1956,6 @@ Rails/WhereExists:
- 'spec/services/purge_domain_service_spec.rb'
- 'spec/services/unallow_domain_service_spec.rb'
# Offense count: 3
# This cop supports unsafe autocorrection (--autocorrect-all).
Security/IoMethods:
Exclude:
- 'spec/controllers/admin/export_domain_allows_controller_spec.rb'
- 'spec/controllers/admin/export_domain_blocks_controller_spec.rb'
# Offense count: 5
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/CaseLikeIf:

+ 2
- 2
spec/controllers/admin/export_domain_allows_controller_spec.rb View File

@ -14,7 +14,7 @@ RSpec.describe Admin::ExportDomainAllowsController, type: :controller do
get :export, params: { format: :csv }
expect(response).to have_http_status(200)
expect(response.body).to eq(IO.read(File.join(file_fixture_path, 'domain_allows.csv')))
expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_allows.csv')))
end
end
@ -30,7 +30,7 @@ RSpec.describe Admin::ExportDomainAllowsController, type: :controller do
# Domains should now be added
get :export, params: { format: :csv }
expect(response).to have_http_status(200)
expect(response.body).to eq(IO.read(File.join(file_fixture_path, 'domain_allows.csv')))
expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_allows.csv')))
end
it 'displays error on no file selected' do

+ 1
- 1
spec/controllers/admin/export_domain_blocks_controller_spec.rb View File

@ -16,7 +16,7 @@ RSpec.describe Admin::ExportDomainBlocksController, type: :controller do
get :export, params: { format: :csv }
expect(response).to have_http_status(200)
expect(response.body).to eq(IO.read(File.join(file_fixture_path, 'domain_blocks.csv')))
expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_blocks.csv')))
end
end

Loading…
Cancel
Save