Browse Source

Don't capture scheme-less URLs in the status (#5435)

Specifically, this fixes status length calculation to be same as JS side.

BTW, since this pattern used in not only preview card fetching, we
should extract it (with twitter-regex?) and write tests I think.
pull/4/head
unarist 6 years ago
committed by Eugen Rochko
parent
commit
3bc8924940
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      app/services/fetch_link_card_service.rb

+ 1
- 1
app/services/fetch_link_card_service.rb View File

@ -3,7 +3,7 @@
class FetchLinkCardService < BaseService
URL_PATTERN = %r{
( # $1 URL
(https?:\/\/) class="p">? # $2 Protocol (optional)
(https?:\/\/) # $2 Protocol (required)
(#{Twitter::Regex[:valid_domain]}) # $3 Domain(s)
(?::(#{Twitter::Regex[:valid_port_number]}))? # $4 Port number (optional)
(/#{Twitter::Regex[:valid_url_path]}*)? # $5 URL Path and anchor

Loading…
Cancel
Save