Browse Source

Improve background jobs params and error handling

closed-social-glitch-2
Eugen Rochko 7 years ago
parent
commit
6c28886317
5 changed files with 12 additions and 2 deletions
  1. +2
    -0
      app/workers/notification_worker.rb
  2. +1
    -1
      app/workers/pubsubhubbub/confirmation_worker.rb
  3. +5
    -1
      app/workers/pubsubhubbub/delivery_worker.rb
  4. +2
    -0
      app/workers/thread_resolve_worker.rb
  5. +2
    -0
      app/workers/unfavourite_worker.rb

+ 2
- 0
app/workers/notification_worker.rb View File

@ -3,6 +3,8 @@
class NotificationWorker class NotificationWorker
include Sidekiq::Worker include Sidekiq::Worker
sidekiq_options retry: 5
def perform(stream_entry_id, target_account_id) def perform(stream_entry_id, target_account_id)
SendInteractionService.new.call(StreamEntry.find(stream_entry_id), Account.find(target_account_id)) SendInteractionService.new.call(StreamEntry.find(stream_entry_id), Account.find(target_account_id))
end end

+ 1
- 1
app/workers/pubsubhubbub/confirmation_worker.rb View File

@ -4,7 +4,7 @@ class Pubsubhubbub::ConfirmationWorker
include Sidekiq::Worker include Sidekiq::Worker
include RoutingHelper include RoutingHelper
sidekiq_options queue: 'push'
sidekiq_options queue: 'push', retry: false
def perform(subscription_id, mode, secret = nil, lease_seconds = nil) def perform(subscription_id, mode, secret = nil, lease_seconds = nil)
subscription = Subscription.find(subscription_id) subscription = Subscription.find(subscription_id)

+ 5
- 1
app/workers/pubsubhubbub/delivery_worker.rb View File

@ -4,7 +4,11 @@ class Pubsubhubbub::DeliveryWorker
include Sidekiq::Worker include Sidekiq::Worker
include RoutingHelper include RoutingHelper
sidekiq_options queue: 'push', retry: 5
sidekiq_options queue: 'push', retry: 3, dead: false
sidekiq_retry_in do |count|
5 * (count + 1)
end
def perform(subscription_id, payload) def perform(subscription_id, payload)
subscription = Subscription.find(subscription_id) subscription = Subscription.find(subscription_id)

+ 2
- 0
app/workers/thread_resolve_worker.rb View File

@ -3,6 +3,8 @@
class ThreadResolveWorker class ThreadResolveWorker
include Sidekiq::Worker include Sidekiq::Worker
sidekiq_options retry: false
def perform(child_status_id, parent_url) def perform(child_status_id, parent_url)
child_status = Status.find(child_status_id) child_status = Status.find(child_status_id)
parent_status = FetchRemoteStatusService.new.call(parent_url) parent_status = FetchRemoteStatusService.new.call(parent_url)

+ 2
- 0
app/workers/unfavourite_worker.rb View File

@ -5,5 +5,7 @@ class UnfavouriteWorker
def perform(account_id, status_id) def perform(account_id, status_id)
UnfavouriteService.new.call(Account.find(account_id), Status.find(status_id)) UnfavouriteService.new.call(Account.find(account_id), Status.find(status_id))
rescue ActiveRecord::RecordNotFound
true
end end
end end

Loading…
Cancel
Save