From 84214b864c63aee08357a719ab386b8e4ed5b901 Mon Sep 17 00:00:00 2001 From: unarist Date: Sat, 21 Apr 2018 01:36:52 +0900 Subject: [PATCH] Ignore keyevents during text composition (#7205) KeyboardEvent.key may be physical key name (Escape, Tab, etc.) even in text composition and it causes hotkeys or suggestion selection. So we need to check e.which or e.isComposing. Checking e.which also allows us to avoid Esc key on compositionend in Safari. --- app/javascript/mastodon/components/autosuggest_textarea.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/javascript/mastodon/components/autosuggest_textarea.js b/app/javascript/mastodon/components/autosuggest_textarea.js index 5474771c9..a4f5cf50c 100644 --- a/app/javascript/mastodon/components/autosuggest_textarea.js +++ b/app/javascript/mastodon/components/autosuggest_textarea.js @@ -84,6 +84,12 @@ export default class AutosuggestTextarea extends ImmutablePureComponent { return; } + if (e.which === 229 || e.isComposing) { + // Ignore key events during text composition + // e.key may be a name of the physical key even in this case (e.x. Safari / Chrome on Mac) + return; + } + switch(e.key) { case 'Escape': if (suggestions.size === 0 || suggestionsHidden) {