Browse Source

Cover Admin::DomainBlocksController more (#3329)

Also domain_block fabricator now sets unique domains
pull/4/head
Akihiko Odaki (@fn_aki@pawoo.net) 5 years ago
committed by Eugen Rochko
parent
commit
8f991831b8
2 changed files with 31 additions and 5 deletions
  1. +30
    -4
      spec/controllers/admin/domain_blocks_controller_spec.rb
  2. +1
    -1
      spec/fabricators/domain_block_fabricator.rb

+ 30
- 4
spec/controllers/admin/domain_blocks_controller_spec.rb View File

@ -8,17 +8,30 @@ RSpec.describe Admin::DomainBlocksController, type: :controller do
end
describe 'GET #index' do
it 'returns http success' do
get :index
around do |example|
default_per_page = DomainBlock.default_per_page
DomainBlock.paginates_per 1
example.run
DomainBlock.paginates_per default_per_page
end
it 'renders domain blocks' do
2.times { Fabricate(:domain_block) }
get :index, params: { page: 2 }
assigned = assigns(:domain_blocks)
expect(assigned.count).to eq 1
expect(assigned.klass).to be DomainBlock
expect(response).to have_http_status(:success)
end
end
describe 'GET #new' do
it 'returns http success' do
it 'assigns a new domain block' do
get :new
expect(assigns(:domain_block)).to be_instance_of(DomainBlock)
expect(response).to have_http_status(:success)
end
end
@ -33,13 +46,25 @@ RSpec.describe Admin::DomainBlocksController, type: :controller do
end
describe 'POST #create' do
it 'blocks the domain' do
it 'blocks the domain when succeeded to save' do
allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } }
expect(DomainBlockWorker).to have_received(:perform_async)
expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.created_msg')
expect(response).to redirect_to(admin_domain_blocks_path)
end
it 'renders new when failed to save' do
Fabricate(:domain_block, domain: 'example.com')
allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } }
expect(DomainBlockWorker).not_to have_received(:perform_async)
expect(response).to render_template :new
end
end
describe 'DELETE #destroy' do
@ -50,6 +75,7 @@ RSpec.describe Admin::DomainBlocksController, type: :controller do
delete :destroy, params: { id: domain_block.id, domain_block: { retroactive: '1' } }
expect(service).to have_received(:call).with(domain_block, true)
expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.destroyed_msg')
expect(response).to redirect_to(admin_domain_blocks_path)
end
end

+ 1
- 1
spec/fabricators/domain_block_fabricator.rb View File

@ -1,3 +1,3 @@
Fabricator(:domain_block) do
domain "example.com"
domain { sequence(:domain) { |i| "#{i}#{Faker::Internet.domain_name}" } }
end

Loading…
Cancel
Save