Browse Source

Eagerly load statuses with the main query in Api::V1::BookmarksController (#14674)

This is same with commit 552e886b64 except
that it was for Api::V1::FavouritesController while this is for
Api::V1::BookmarksController.
master
Akihiko Odaki 4 years ago
committed by GitHub
parent
commit
b63ede5005
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
  1. +2
    -5
      app/controllers/api/v1/bookmarks_controller.rb

+ 2
- 5
app/controllers/api/v1/bookmarks_controller.rb View File

@ -17,14 +17,11 @@ class Api::V1::BookmarksController < Api::BaseController
end end
def cached_bookmarks def cached_bookmarks
cache_collection(
Status.reorder(nil).joins(:bookmarks).merge(results),
Status
)
cache_collection(results.map(&:status), Status)
end end
def results def results
@_results ||= account_bookmarks.paginate_by_id(
@_results ||= account_bookmarks.eager_load(:status).paginate_by_id(
limit_param(DEFAULT_STATUSES_LIMIT), limit_param(DEFAULT_STATUSES_LIMIT),
params_slice(:max_id, :since_id, :min_id) params_slice(:max_id, :since_id, :min_id)
) )

Loading…
Cancel
Save