Browse Source

Remove PuSH subscriptions when delivery is answered with a 4xx error

closed-social-glitch-2
Eugen Rochko 7 years ago
parent
commit
bda37489ac
1 changed files with 1 additions and 0 deletions
  1. +1
    -0
      app/workers/pubsubhubbub/delivery_worker.rb

+ 1
- 0
app/workers/pubsubhubbub/delivery_worker.rb View File

@ -22,6 +22,7 @@ class Pubsubhubbub::DeliveryWorker
.headers(headers)
.post(subscription.callback_url, body: payload)
return subscription.destroy! if response.code > 299 && response.code < 500 && response.code != 429 # HTTP 4xx means error is not temporary, except for 429 (throttling)
raise "Delivery failed for #{subscription.callback_url}: HTTP #{response.code}" unless response.code > 199 && response.code < 300
subscription.touch(:last_successful_delivery_at)

Loading…
Cancel
Save