From d772db43441ebc28655b76f3662f02fa7fd48839 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Thu, 6 Oct 2016 21:33:33 +0200 Subject: [PATCH] Fix #83 - if user cannot be found (or is self) throw error, don't return empty 200 This prevents the undefined profile from being opened in the first place on such an error --- app/services/follow_service.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/services/follow_service.rb b/app/services/follow_service.rb index 4caf55078..2a9dc82c3 100644 --- a/app/services/follow_service.rb +++ b/app/services/follow_service.rb @@ -5,7 +5,7 @@ class FollowService < BaseService def call(source_account, uri) target_account = follow_remote_account_service.call(uri) - return nil if target_account.nil? || target_account.id == source_account.id + raise ActiveRecord::RecordNotFound if target_account.nil? || target_account.id == source_account.id follow = source_account.follow!(target_account)