闭社主体 forked from https://github.com/tootsuite/mastodon
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

112 lines
3.6 KiB

Add follower synchronization mechanism (#14510) * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each
4 years ago
  1. # frozen_string_literal: true
  2. require 'rails_helper'
  3. RSpec.describe ActivityPub::InboxesController, type: :controller do
  4. let(:remote_account) { nil }
  5. before do
  6. allow(controller).to receive(:signed_request_account).and_return(remote_account)
  7. end
  8. describe 'POST #create' do
  9. context 'with signature' do
  10. let(:remote_account) { Fabricate(:account, domain: 'example.com', protocol: :activitypub) }
  11. before do
  12. post :create, body: '{}'
  13. end
  14. it 'returns http accepted' do
  15. expect(response).to have_http_status(202)
  16. end
  17. context 'for a specific account' do
  18. let(:account) { Fabricate(:account) }
  19. subject(:response) { post :create, params: { account_username: account.username }, body: '{}' }
  20. context 'when account is permanently suspended' do
  21. before do
  22. account.suspend!
  23. account.deletion_request.destroy
  24. end
  25. it 'returns http gone' do
  26. expect(response).to have_http_status(410)
  27. end
  28. end
  29. context 'when account is temporarily suspended' do
  30. before do
  31. account.suspend!
  32. end
  33. it 'returns http accepted' do
  34. expect(response).to have_http_status(202)
  35. end
  36. end
  37. end
  38. end
  39. context 'with Collection-Synchronization header' do
  40. let(:remote_account) { Fabricate(:account, followers_url: 'https://example.com/followers', domain: 'example.com', uri: 'https://example.com/actor', protocol: :activitypub) }
  41. let(:synchronization_collection) { remote_account.followers_url }
  42. let(:synchronization_url) { 'https://example.com/followers-for-domain' }
  43. let(:synchronization_hash) { 'somehash' }
  44. let(:synchronization_header) { "collectionId=\"#{synchronization_collection}\", digest=\"#{synchronization_hash}\", url=\"#{synchronization_url}\"" }
  45. before do
  46. allow(ActivityPub::FollowersSynchronizationWorker).to receive(:perform_async).and_return(nil)
  47. allow_any_instance_of(Account).to receive(:local_followers_hash).and_return('somehash')
  48. request.headers['Collection-Synchronization'] = synchronization_header
  49. post :create, body: '{}'
  50. end
  51. context 'with mismatching target collection' do
  52. let(:synchronization_collection) { 'https://example.com/followers2' }
  53. it 'does not start a synchronization job' do
  54. expect(ActivityPub::FollowersSynchronizationWorker).not_to have_received(:perform_async)
  55. end
  56. end
  57. context 'with mismatching domain in partial collection attribute' do
  58. let(:synchronization_url) { 'https://example.org/followers' }
  59. it 'does not start a synchronization job' do
  60. expect(ActivityPub::FollowersSynchronizationWorker).not_to have_received(:perform_async)
  61. end
  62. end
  63. context 'with matching digest' do
  64. it 'does not start a synchronization job' do
  65. expect(ActivityPub::FollowersSynchronizationWorker).not_to have_received(:perform_async)
  66. end
  67. end
  68. context 'with mismatching digest' do
  69. let(:synchronization_hash) { 'wronghash' }
  70. it 'starts a synchronization job' do
  71. expect(ActivityPub::FollowersSynchronizationWorker).to have_received(:perform_async)
  72. end
  73. end
  74. it 'returns http accepted' do
  75. expect(response).to have_http_status(202)
  76. end
  77. end
  78. context 'without signature' do
  79. before do
  80. post :create, body: '{}'
  81. end
  82. it 'returns http not authorized' do
  83. expect(response).to have_http_status(401)
  84. end
  85. end
  86. end
  87. end