Browse Source

Accessability fixes (#4432)

* fix(modal_root): Read type from props, not from component

* fix(status_list): Do not user event.path
closed-social-v3
Sorin Davidoi 7 years ago
committed by Eugen Rochko
parent
commit
634b71ed1d
2 changed files with 3 additions and 3 deletions
  1. +2
    -2
      app/javascript/mastodon/components/status_list.js
  2. +1
    -1
      app/javascript/mastodon/features/ui/components/modal_root.js

+ 2
- 2
app/javascript/mastodon/components/status_list.js View File

@ -109,9 +109,9 @@ export default class StatusList extends ImmutablePureComponent {
const article = (() => {
switch (e.key) {
case 'PageDown':
return e.nativeEvent.path[0].nodeName === 'ARTICLE' && e.nativeEvent.path[0].nextElementSibling;
return e.target.nodeName === 'ARTICLE' && e.target.nextElementSibling;
case 'PageUp':
return e.nativeEvent.path[0].nodeName === 'ARTICLE' && e.nativeEvent.path[0].previousElementSibling;
return e.target.nodeName === 'ARTICLE' && e.target.previousElementSibling;
case 'End':
return this.node.querySelector('[role="feed"] > article:last-of-type');
case 'Home':

+ 1
- 1
app/javascript/mastodon/features/ui/components/modal_root.js View File

@ -53,7 +53,7 @@ export default class ModalRoot extends React.PureComponent {
}
componentDidUpdate (prevProps) {
if (!this.type && !!prevProps.type) {
if (!this.props.type && !!prevProps.type) {
this.getSiblings().forEach(sibling => sibling.removeAttribute('inert'));
this.activeElement.focus();
this.activeElement = null;

Loading…
Cancel
Save