Browse Source

Create instance actor if it hasn't been properly seeded (#15693)

An uncommon but somewhat difficult to digagnose issue is dealing with
improperly-seeded databases. In such cases, instance-signed fetches will
fail with a ActiveRecord::RecordNotFound error, usually caught and handled
as generic 404, leading people to think the remote resource itself has not
been found, while it's the local instance actor that does not exist.

This commit changes the code so that failure to find the instance actor
automatically creates a new one, so that improperly-seeded databases do
not cause any issue.
closed-social-v3
Claire 3 years ago
committed by GitHub
parent
commit
acdeb162b8
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
  1. +1
    -1
      app/controllers/instance_actors_controller.rb
  2. +2
    -0
      app/models/concerns/account_finder_concern.rb

+ 1
- 1
app/controllers/instance_actors_controller.rb View File

@ -13,7 +13,7 @@ class InstanceActorsController < ApplicationController
private
def set_account
@account = Account.find(-99)
@account = Account.representative
end
def restrict_fields_to

+ 2
- 0
app/models/concerns/account_finder_concern.rb View File

@ -14,6 +14,8 @@ module AccountFinderConcern
def representative
Account.find(-99)
rescue ActiveRecord::RecordNotFound
Account.create!(id: -99, actor_type: 'Application', locked: true, username: Rails.configuration.x.local_domain)
end
def find_local(username)

Loading…
Cancel
Save