Browse Source

Fix Command-enter tooting

metaKey is only set correctly on keyDown, not keyUp, so this swaps to using that
master
Jessica Stokes 7 years ago
parent
commit
1da73ecade
No known key found for this signature in database GPG Key ID: E3DE5BE038F70FE9
2 changed files with 10 additions and 3 deletions
  1. +8
    -1
      app/assets/javascripts/components/components/autosuggest_textarea.jsx
  2. +2
    -2
      app/assets/javascripts/components/features/compose/components/compose_form.jsx

+ 8
- 1
app/assets/javascripts/components/components/autosuggest_textarea.jsx View File

@ -38,7 +38,8 @@ const AutosuggestTextarea = React.createClass({
onSuggestionsClearRequested: React.PropTypes.func.isRequired,
onSuggestionsFetchRequested: React.PropTypes.func.isRequired,
onChange: React.PropTypes.func.isRequired,
onKeyUp: React.PropTypes.func
onKeyUp: React.PropTypes.func,
onKeyDown: React.PropTypes.func
},
getInitialState () {
@ -108,6 +109,12 @@ const AutosuggestTextarea = React.createClass({
break;
}
if (e.defaultPrevented || !this.props.onKeyDown) {
return;
}
this.props.onKeyDown(e);
},
onBlur () {

+ 2
- 2
app/assets/javascripts/components/features/compose/components/compose_form.jsx View File

@ -49,7 +49,7 @@ const ComposeForm = React.createClass({
this.props.onChange(e.target.value);
},
handleKeyUp (e) {
handleKeyDown (e) {
if (e.keyCode === 13 && (e.ctrlKey || e.metaKey)) {
this.props.onSubmit();
}
@ -115,7 +115,7 @@ const ComposeForm = React.createClass({
value={this.props.text}
onChange={this.handleChange}
suggestions={this.props.suggestions}
onKeyUp={this.handleKeyUp}
onKeyDown={this.handleKeyDown}
onSuggestionsFetchRequested={this.onSuggestionsFetchRequested}
onSuggestionsClearRequested={this.onSuggestionsClearRequested}
onSuggestionSelected={this.onSuggestionSelected}

Loading…
Cancel
Save