From 76449df903de5b06ae22745a1a80ecf49a07e0d9 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Thu, 18 May 2017 00:38:18 +0200 Subject: [PATCH] Fix character counter not updating for bio (#3101) --- app/javascript/packs/public.js | 2 +- app/views/settings/profiles/show.html.haml | 4 ++-- config/locales/simple_form.en.yml | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/javascript/packs/public.js b/app/javascript/packs/public.js index 6aef2ffeef..e392bad186 100644 --- a/app/javascript/packs/public.js +++ b/app/javascript/packs/public.js @@ -101,7 +101,7 @@ document.addEventListener('DOMContentLoaded', () => { }); delegate(document, '.account_note', 'input', ({ target }) => { - const [noteCounter, ] = document.getElementsByClassName('.note-counter'); + const [noteCounter, ] = document.getElementsByClassName('note-counter'); noteCounter.textContent = 160 - length(target.value); }); }); diff --git a/app/views/settings/profiles/show.html.haml b/app/views/settings/profiles/show.html.haml index cce2d59f70..2b846006f8 100644 --- a/app/views/settings/profiles/show.html.haml +++ b/app/views/settings/profiles/show.html.haml @@ -5,8 +5,8 @@ = render 'shared/error_messages', object: @account .fields-group - = f.input :display_name, placeholder: t('simple_form.labels.defaults.display_name'), hint: t('simple_form.hints.defaults.display_name', count: "#{30 - @account.display_name.size}").html_safe - = f.input :note, placeholder: t('simple_form.labels.defaults.note'), hint: t('simple_form.hints.defaults.note', count: "#{160 - @account.note.size}").html_safe + = f.input :display_name, placeholder: t('simple_form.labels.defaults.display_name'), hint: t('simple_form.hints.defaults.display_name', count: 30 - @account.display_name.size).html_safe + = f.input :note, placeholder: t('simple_form.labels.defaults.note'), hint: t('simple_form.hints.defaults.note', count: 160 - @account.note.size).html_safe = f.input :avatar, wrapper: :with_label, input_html: { accept: AccountAvatar::IMAGE_MIME_TYPES.join(',') }, hint: t('simple_form.hints.defaults.avatar') = f.input :header, wrapper: :with_label, input_html: { accept: AccountHeader::IMAGE_MIME_TYPES.join(',') }, hint: t('simple_form.hints.defaults.header') diff --git a/config/locales/simple_form.en.yml b/config/locales/simple_form.en.yml index 8319d921df..74dc16efea 100644 --- a/config/locales/simple_form.en.yml +++ b/config/locales/simple_form.en.yml @@ -4,14 +4,14 @@ en: hints: defaults: avatar: PNG, GIF or JPG. At most 2MB. Will be downscaled to 120x120px - display_name: - one: '1 character left' - other: '%{count} characters left' + display_name: + one: '1 character left' + other: '%{count} characters left' header: PNG, GIF or JPG. At most 2MB. Will be downscaled to 700x335px locked: Requires you to manually approve followers and defaults post privacy to followers-only - note: - one: '1 character left' - other: '%{count} characters left' + note: + one: '1 character left' + other: '%{count} characters left' imports: data: CSV file exported from another Mastodon instance sessions: