Browse Source

fix(components/autosuggest_textarea): Race condition regarding onBlur (#3631)

master
Sorin Davidoi 7 years ago
committed by Eugen Rochko
parent
commit
8cf8ce4ac0
1 changed files with 2 additions and 8 deletions
  1. +2
    -8
      app/javascript/mastodon/components/autosuggest_textarea.js

+ 2
- 8
app/javascript/mastodon/components/autosuggest_textarea.js View File

@ -124,13 +124,7 @@ class AutosuggestTextarea extends ImmutablePureComponent {
}
onBlur = () => {
// If we hide the suggestions immediately, then this will prevent the
// onClick for the suggestions themselves from firing.
// Setting a short window for that to take place before hiding the
// suggestions ensures that can't happen.
setTimeout(() => {
this.setState({ suggestionsHidden: true });
}, 100);
this.setState({ suggestionsHidden: true });
}
onSuggestionClick = (e) => {
@ -191,7 +185,7 @@ class AutosuggestTextarea extends ImmutablePureComponent {
key={suggestion}
data-index={suggestion}
className={`autosuggest-textarea__suggestions__item ${i === selectedSuggestion ? 'selected' : ''}`}
onClick={this.onSuggestionClick}
onMouseDown={this.onSuggestionClick}
>
<AutosuggestAccountContainer id={suggestion} />
</div>

Loading…
Cancel
Save