You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

132 lines
4.7 KiB

Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes (#20597) * Allow import/export of instance-level domain blocks/allows (#1754) * Allow import/export of instance-level domain blocks/allows. Fixes #15095 * Pacify circleci * Address simple code review feedback * Add headers to exported CSV * Extract common import/export functionality to AdminExportControllerConcern * Add additional fields to instance-blocked domain export * Address review feedback * Split instance domain block/allow import/export into separate pages/controllers * Address code review feedback * Pacify DeepSource * Work around Paperclip::HasAttachmentFile for Rails 6 * Fix deprecated API warning in export tests * Remove after_commit workaround (cherry picked from commit 94e98864e39c010635e839fea984f2b4893bef1a) * Add confirmation page when importing blocked domains (#1773) * Move glitch-soc-specific strings to glitch-soc-specific locale files * Add confirmation page when importing blocked domains (cherry picked from commit b91196f4b73fff91997b8077619ae25b6d04a59e) * Fix authorization check in domain blocks controller (cherry picked from commit 75279377583c6e2aa04cc8d7380c593979630b38) * Fix error strings for domain blocks and email-domain blocks Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's" * Ran i18n-tasks normalize to address test failure * Removed unused admin.export_domain_blocks.not_permitted string Removing unused string as indicated by Check i18n * Fix tests (cherry picked from commit 9094c2f52c24e1c00b594e7c11cd00e4a07eb431) * Fix domain block export not exporting blocks with only media rejection (cherry picked from commit 26ff48ee48a5c03a2a4b0bd03fd322529e6bd960) * Fix various issues with domain block import - stop using Paperclip for processing domain allow/block imports - stop leaving temporary files - better error handling - assume CSV files are UTF-8-encoded (cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902) Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
  1. require 'rails_helper'
  2. RSpec.describe Admin::DomainBlocksController, type: :controller do
  3. render_views
  4. before do
  5. sign_in Fabricate(:user, role: UserRole.find_by(name: 'Admin')), scope: :user
  6. end
  7. describe 'GET #new' do
  8. it 'assigns a new domain block' do
  9. get :new
  10. expect(assigns(:domain_block)).to be_instance_of(DomainBlock)
  11. expect(response).to have_http_status(200)
  12. end
  13. end
  14. describe 'POST #batch' do
  15. it 'blocks the domains when succeeded to save' do
  16. allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
  17. post :batch, params: {
  18. save: '',
  19. form_domain_block_batch: {
  20. domain_blocks_attributes: {
  21. '0' => { enabled: '1', domain: 'example.com', severity: 'silence' },
  22. '1' => { enabled: '0', domain: 'mastodon.social', severity: 'suspend' },
  23. '2' => { enabled: '1', domain: 'mastodon.online', severity: 'suspend' }
  24. }
  25. }
  26. }
  27. expect(DomainBlockWorker).to have_received(:perform_async).exactly(2).times
  28. expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.created_msg')
  29. expect(response).to redirect_to(admin_instances_path(limited: '1'))
  30. end
  31. end
  32. describe 'POST #create' do
  33. it 'blocks the domain when succeeded to save' do
  34. allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
  35. post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } }
  36. expect(DomainBlockWorker).to have_received(:perform_async)
  37. expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.created_msg')
  38. expect(response).to redirect_to(admin_instances_path(limited: '1'))
  39. end
  40. it 'renders new when failed to save' do
  41. Fabricate(:domain_block, domain: 'example.com', severity: 'suspend')
  42. allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
  43. post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } }
  44. expect(DomainBlockWorker).not_to have_received(:perform_async)
  45. expect(response).to render_template :new
  46. end
  47. it 'allows upgrading a block' do
  48. Fabricate(:domain_block, domain: 'example.com', severity: 'silence')
  49. allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
  50. post :create, params: { domain_block: { domain: 'example.com', severity: 'silence', reject_media: true, reject_reports: true } }
  51. expect(DomainBlockWorker).to have_received(:perform_async)
  52. expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.created_msg')
  53. expect(response).to redirect_to(admin_instances_path(limited: '1'))
  54. end
  55. end
  56. describe 'PUT #update' do
  57. let!(:remote_account) { Fabricate(:account, domain: 'example.com') }
  58. let(:domain_block) { Fabricate(:domain_block, domain: 'example.com', severity: original_severity) }
  59. before do
  60. BlockDomainService.new.call(domain_block)
  61. end
  62. let(:subject) do
  63. post :update, params: { id: domain_block.id, domain_block: { domain: 'example.com', severity: new_severity } }
  64. end
  65. context 'downgrading a domain suspension to silence' do
  66. let(:original_severity) { 'suspend' }
  67. let(:new_severity) { 'silence' }
  68. it 'changes the block severity' do
  69. expect { subject }.to change { domain_block.reload.severity }.from('suspend').to('silence')
  70. end
  71. it 'undoes individual suspensions' do
  72. expect { subject }.to change { remote_account.reload.suspended? }.from(true).to(false)
  73. end
  74. it 'performs individual silences' do
  75. expect { subject }.to change { remote_account.reload.silenced? }.from(false).to(true)
  76. end
  77. end
  78. context 'upgrading a domain silence to suspend' do
  79. let(:original_severity) { 'silence' }
  80. let(:new_severity) { 'suspend' }
  81. it 'changes the block severity' do
  82. expect { subject }.to change { domain_block.reload.severity }.from('silence').to('suspend')
  83. end
  84. it 'undoes individual silences' do
  85. expect { subject }.to change { remote_account.reload.silenced? }.from(true).to(false)
  86. end
  87. it 'performs individual suspends' do
  88. expect { subject }.to change { remote_account.reload.suspended? }.from(false).to(true)
  89. end
  90. end
  91. end
  92. describe 'DELETE #destroy' do
  93. it 'unblocks the domain' do
  94. service = double(call: true)
  95. allow(UnblockDomainService).to receive(:new).and_return(service)
  96. domain_block = Fabricate(:domain_block)
  97. delete :destroy, params: { id: domain_block.id }
  98. expect(service).to have_received(:call).with(domain_block)
  99. expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.destroyed_msg')
  100. expect(response).to redirect_to(admin_instances_path(limited: '1'))
  101. end
  102. end
  103. end